Re: [PATCH v2] ussd: Recover idle state in case of response sending failure

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

Hi Philippe,

On 08/23/2012 11:27 AM, Philippe Nunes wrote:
> GCF test case 31.8.1.2.3 is rejecting the user response.
> Any subsequent USSD notification are not handled because USSD is always in
> state user-action.
> ---
>   src/ussd.c |   12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/src/ussd.c b/src/ussd.c
> index 74888b2..21e0164 100644
> --- a/src/ussd.c
> +++ b/src/ussd.c
> @@ -414,6 +414,18 @@ void ofono_ussd_notify(struct ofono_ussd *ussd, int status, int dcs,
>   		return;
>   	}
>
> +	if (status == OFONO_USSD_STATUS_TERMINATED&&
> +			(ussd->state == USSD_STATE_IDLE ||
> +			ussd->state == USSD_STATE_USER_ACTION)) {

This check makes no sense, why bother checking for ussd->state == 
USSD_STATE_IDLE?

> +		ussd_change_state(ussd, USSD_STATE_IDLE);
> +
> +		if (ussd->pending == NULL)
> +			return;
> +
> +		reply = __ofono_error_not_supported(ussd->pending);
> +		goto out;
> +	}
> +

I would handle it just like the 'Not Supported' case but with a new 
__ofono_error_network_terminated error reply.  Or perhaps re-use 
__ofono_error_canceled.

>   	if (status == OFONO_USSD_STATUS_NOT_SUPPORTED) {
>   		ussd_change_state(ussd, USSD_STATE_IDLE);
>

Regards,
-Denis