From: ludovic.desroches <ludovic.desroches@atmel.com>
To: Nikolaus Voss <n.voss@weinmann.de>
Cc: rmallon@gmail.com, nicolas.ferre@atmel.com,
linux-kernel@vger.kernel.org, balbi@ti.com,
h.feurstein@gmail.com, ludovic.desroches@atmel.com,
linux-i2c@vger.kernel.org, ben-linux@fluff.org,
adrian.yanes@aalto.fi, linux-arm-kernel@lists.infradead.org,
carsten.behling@garz-fricke.com
Subject: Re: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Tue, 28 Aug 2012 17:10:00 +0200 [thread overview]
Message-ID: <503CDF48.5080201@atmel.com> (raw)
In-Reply-To: <4f3dcfbf1e8eab3e251ab3558e9e1e9123643928.1345618760.git.n.voss@weinmann.de>
Hi Nikolaus,
I forgot one correction I did in your patch:
Le 11/08/2011 11:49 AM, Nikolaus Voss a écrit :
[...]
> diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c
> index 9295e90..27fddc1 100644
> --- a/arch/arm/mach-at91/at91sam9261_devices.c
> +++ b/arch/arm/mach-at91/at91sam9261_devices.c
> @@ -283,9 +283,18 @@ static struct i2c_gpio_platform_data pdata = {
> .udelay = 2, /* ~100 kHz */
> };
>
> +static const struct platform_device_id twi_ip_type = {
> + /*
> + * driver_data is 2 for SAM9261 compatible ip, see enum twi_ip_id in
> + * drivers/i2c/busses/i2c-at91.c
> + */
> + .driver_data = 2,
> +};
> +
> static struct platform_device at91sam9261_twi_device = {
> .name = "i2c-gpio",
> .id = -1,
> + .id_entry = &twi_ip_type,
> .dev.platform_data = &pdata,
> };
>
[...]
You add the id_entry to the i2c-gpio device instead of at91_i2c device.
Regards
Ludovic
WARNING: multiple messages have this Message-ID (diff)
From: ludovic.desroches@atmel.com (ludovic.desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Tue, 28 Aug 2012 17:10:00 +0200 [thread overview]
Message-ID: <503CDF48.5080201@atmel.com> (raw)
In-Reply-To: <4f3dcfbf1e8eab3e251ab3558e9e1e9123643928.1345618760.git.n.voss@weinmann.de>
Hi Nikolaus,
I forgot one correction I did in your patch:
Le 11/08/2011 11:49 AM, Nikolaus Voss a ?crit :
[...]
> diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c
> index 9295e90..27fddc1 100644
> --- a/arch/arm/mach-at91/at91sam9261_devices.c
> +++ b/arch/arm/mach-at91/at91sam9261_devices.c
> @@ -283,9 +283,18 @@ static struct i2c_gpio_platform_data pdata = {
> .udelay = 2, /* ~100 kHz */
> };
>
> +static const struct platform_device_id twi_ip_type = {
> + /*
> + * driver_data is 2 for SAM9261 compatible ip, see enum twi_ip_id in
> + * drivers/i2c/busses/i2c-at91.c
> + */
> + .driver_data = 2,
> +};
> +
> static struct platform_device at91sam9261_twi_device = {
> .name = "i2c-gpio",
> .id = -1,
> + .id_entry = &twi_ip_type,
> .dev.platform_data = &pdata,
> };
>
[...]
You add the id_entry to the i2c-gpio device instead of at91_i2c device.
Regards
Ludovic
next prev parent reply other threads:[~2012-08-28 15:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 6:59 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
2012-08-22 6:59 ` Nikolaus Voss
[not found] ` <cover.1345618760.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49 ` [PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver Nikolaus Voss
2011-11-08 10:49 ` Nikolaus Voss
2011-11-08 10:49 ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49 ` Nikolaus Voss
2012-08-27 10:16 ` ludovic.desroches
2012-08-27 10:16 ` ludovic.desroches
2012-08-27 10:40 ` Yanes Martinez Adrian
2012-08-27 10:40 ` Yanes Martinez Adrian
2012-08-27 12:04 ` ludovic.desroches
2012-08-27 12:04 ` ludovic.desroches
2012-08-27 12:45 ` Yanes Martinez Adrian
2012-08-27 12:45 ` Yanes Martinez Adrian
[not found] ` <BC0F374A1C27184AB96177CDFEC2F54225ECD36E-rZDk5e4OVTsRAxgRyUl6SBEi2Xg3O0b1@public.gmane.org>
2012-08-27 13:32 ` Voss, Nikolaus
2012-08-27 13:32 ` Voss, Nikolaus
2012-08-27 13:32 ` Voss, Nikolaus
2012-08-27 14:00 ` ludovic.desroches
2012-08-27 14:00 ` ludovic.desroches
2012-08-27 14:29 ` Voss, Nikolaus
2012-08-27 14:29 ` Voss, Nikolaus
2012-08-27 14:29 ` Voss, Nikolaus
2012-09-11 8:26 ` Nicolas Ferre
2012-09-11 8:26 ` Nicolas Ferre
[not found] ` <504EF5BF.2090404-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-11 22:13 ` Wolfram Sang
2012-09-11 22:13 ` Wolfram Sang
2012-09-11 22:13 ` Wolfram Sang
2012-08-30 7:35 ` ludovic.desroches
2012-08-30 7:35 ` ludovic.desroches
2012-08-28 15:10 ` ludovic.desroches [this message]
2012-08-28 15:10 ` ludovic.desroches
2012-08-28 15:32 ` Voss, Nikolaus
2012-08-28 15:32 ` Voss, Nikolaus
2011-11-08 11:09 ` [PATCH v11 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:09 ` Nikolaus Voss
2011-11-08 11:11 ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
2011-11-08 11:11 ` Nikolaus Voss
2012-08-27 10:24 ` ludovic.desroches
2012-08-27 10:24 ` ludovic.desroches
2012-08-27 13:22 ` Voss, Nikolaus
2012-08-27 13:22 ` Voss, Nikolaus
2012-08-27 13:27 ` ludovic.desroches
2012-08-27 13:27 ` ludovic.desroches
-- strict thread matches above, loose matches on Subject: below --
2012-08-29 7:28 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
[not found] ` <cover.1346225321.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49 ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49 ` Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503CDF48.5080201@atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=adrian.yanes@aalto.fi \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=carsten.behling@garz-fricke.com \
--cc=h.feurstein@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=n.voss@weinmann.de \
--cc=nicolas.ferre@atmel.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.