All of lore.kernel.org
 help / color / mirror / Atom feed
From: ludovic.desroches <ludovic.desroches@atmel.com>
To: "Voss, Nikolaus" <N.Voss@weinmann.de>
Cc: "'ben-linux@fluff.org'" <ben-linux@fluff.org>,
	"'carsten.behling@garz-fricke.com'"
	<carsten.behling@garz-fricke.com>,
	"'nicolas.ferre@atmel.com'" <nicolas.ferre@atmel.com>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
	"'balbi@ti.com'" <balbi@ti.com>,
	"'h.feurstein@gmail.com'" <h.feurstein@gmail.com>,
	"'ludovic.desroches'" <ludovic.desroches@atmel.com>,
	"'linux-i2c@vger.kernel.org'" <linux-i2c@vger.kernel.org>,
	'Yanes Martinez Adrian' <adrian.yanes@aalto.fi>,
	"'linux-arm-kernel@lists.infradead.org'"
	<linux-arm-kernel@lists.infradead.org>,
	"'rmallon@gmail.com'" <rmallon@gmail.com>
Subject: Re: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Thu, 30 Aug 2012 09:35:35 +0200	[thread overview]
Message-ID: <503F17C7.5010807@atmel.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D090EC3D6F6@wm021.weinmann.com>

Le 08/27/2012 03:32 PM, Voss, Nikolaus a écrit :
> Hi Adian,
>
> Yanes Martinez Adrian wrote on Monday, August 27, 2012 2:46 PM:
>> Le 08/27/2012 12:40 PM, Yanes Martinez Adrian a écrit :
>>> Hi Ludovic,
>>>
>>>> Tested on at91rm9200, at91sam9261, at91sam9g20 and at91sam9m10 with
>>>> eeprom, temperature sensor and rtc devices (and wolfson chip for
>>>> sam9g20).
>>>
>>> concerning the at91rm9200, what was the amount of bytes you
>> transmitted?
>>>
>>
>>> I have only checked that I can communicate with i2c devices so the
>>> amount is very low (1-4 bytes).
>>
>> IIRC it was from >7 bytes when the issues appeared.
>>
>>> Some months ago I performed some testing[1] with the previous version of
>>> the patch and the main conclusion was that the absence of PDC in the
>>> AT91RM9200 made this driver unusable in such platform.
>
> I didn't get your last post  in that thread. In my opinion RM9200 should really
> be excluded from being configured with this driver, what's your opinion
> Ludovic?
>

After investigation, the transmission issue may concern rm9200, 9261, 
9260 and 9263. The main cause of this issue is we do not have clock 
stretching.
Using a low clock frequency should reduce the underrun issue so this 
driver can be used on those chips but a warning have to be added to 
indicate this potential issue. I'll do it when I'll resend patches for 
DT support.


Regards

Ludovic

> Regards,
> Niko
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

WARNING: multiple messages have this Message-ID (diff)
From: ludovic.desroches@atmel.com (ludovic.desroches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Date: Thu, 30 Aug 2012 09:35:35 +0200	[thread overview]
Message-ID: <503F17C7.5010807@atmel.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D090EC3D6F6@wm021.weinmann.com>

Le 08/27/2012 03:32 PM, Voss, Nikolaus a ?crit :
> Hi Adian,
>
> Yanes Martinez Adrian wrote on Monday, August 27, 2012 2:46 PM:
>> Le 08/27/2012 12:40 PM, Yanes Martinez Adrian a ?crit :
>>> Hi Ludovic,
>>>
>>>> Tested on at91rm9200, at91sam9261, at91sam9g20 and at91sam9m10 with
>>>> eeprom, temperature sensor and rtc devices (and wolfson chip for
>>>> sam9g20).
>>>
>>> concerning the at91rm9200, what was the amount of bytes you
>> transmitted?
>>>
>>
>>> I have only checked that I can communicate with i2c devices so the
>>> amount is very low (1-4 bytes).
>>
>> IIRC it was from >7 bytes when the issues appeared.
>>
>>> Some months ago I performed some testing[1] with the previous version of
>>> the patch and the main conclusion was that the absence of PDC in the
>>> AT91RM9200 made this driver unusable in such platform.
>
> I didn't get your last post  in that thread. In my opinion RM9200 should really
> be excluded from being configured with this driver, what's your opinion
> Ludovic?
>

After investigation, the transmission issue may concern rm9200, 9261, 
9260 and 9263. The main cause of this issue is we do not have clock 
stretching.
Using a low clock frequency should reduce the underrun issue so this 
driver can be used on those chips but a warning have to be added to 
indicate this potential issue. I'll do it when I'll resend patches for 
DT support.


Regards

Ludovic

> Regards,
> Niko
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>

  parent reply	other threads:[~2012-08-30  7:35 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-22  6:59 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
2012-08-22  6:59 ` Nikolaus Voss
     [not found] ` <cover.1345618760.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49   ` [PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver Nikolaus Voss
2011-11-08 10:49     ` Nikolaus Voss
2011-11-08 10:49   ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49     ` Nikolaus Voss
2012-08-27 10:16     ` ludovic.desroches
2012-08-27 10:16       ` ludovic.desroches
2012-08-27 10:40       ` Yanes Martinez Adrian
2012-08-27 10:40         ` Yanes Martinez Adrian
2012-08-27 12:04         ` ludovic.desroches
2012-08-27 12:04           ` ludovic.desroches
2012-08-27 12:45           ` Yanes Martinez Adrian
2012-08-27 12:45             ` Yanes Martinez Adrian
     [not found]             ` <BC0F374A1C27184AB96177CDFEC2F54225ECD36E-rZDk5e4OVTsRAxgRyUl6SBEi2Xg3O0b1@public.gmane.org>
2012-08-27 13:32               ` Voss, Nikolaus
2012-08-27 13:32                 ` Voss, Nikolaus
2012-08-27 13:32                 ` Voss, Nikolaus
2012-08-27 14:00                 ` ludovic.desroches
2012-08-27 14:00                   ` ludovic.desroches
2012-08-27 14:29                   ` Voss, Nikolaus
2012-08-27 14:29                     ` Voss, Nikolaus
2012-08-27 14:29                     ` Voss, Nikolaus
2012-09-11  8:26                     ` Nicolas Ferre
2012-09-11  8:26                       ` Nicolas Ferre
     [not found]                       ` <504EF5BF.2090404-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-11 22:13                         ` Wolfram Sang
2012-09-11 22:13                           ` Wolfram Sang
2012-09-11 22:13                           ` Wolfram Sang
2012-08-30  7:35                 ` ludovic.desroches [this message]
2012-08-30  7:35                   ` ludovic.desroches
2012-08-28 15:10     ` ludovic.desroches
2012-08-28 15:10       ` ludovic.desroches
2012-08-28 15:32       ` Voss, Nikolaus
2012-08-28 15:32         ` Voss, Nikolaus
2011-11-08 11:09   ` [PATCH v11 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:09     ` Nikolaus Voss
2011-11-08 11:11   ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
2011-11-08 11:11     ` Nikolaus Voss
2012-08-27 10:24     ` ludovic.desroches
2012-08-27 10:24       ` ludovic.desroches
2012-08-27 13:22       ` Voss, Nikolaus
2012-08-27 13:22         ` Voss, Nikolaus
2012-08-27 13:27         ` ludovic.desroches
2012-08-27 13:27           ` ludovic.desroches
  -- strict thread matches above, loose matches on Subject: below --
2012-08-29  7:28 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
     [not found] ` <cover.1346225321.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49   ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49     ` Nikolaus Voss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503F17C7.5010807@atmel.com \
    --to=ludovic.desroches@atmel.com \
    --cc=N.Voss@weinmann.de \
    --cc=adrian.yanes@aalto.fi \
    --cc=balbi@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=carsten.behling@garz-fricke.com \
    --cc=h.feurstein@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=rmallon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.