* [PATCH] drm/exynos: Make g2d_pm_ops static
@ 2012-08-28 8:41 Sachin Kamat
2012-08-29 7:02 ` Joonyoung Shim
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2012-08-28 8:41 UTC (permalink / raw)
To: dri-devel; +Cc: patches, sachin.kamat
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
symbol 'g2d_pm_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index 6adfa4e..1065e90 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev)
}
#endif
-SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
+static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
struct platform_driver g2d_driver = {
.probe = g2d_probe,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/exynos: Make g2d_pm_ops static
2012-08-28 8:41 [PATCH] drm/exynos: Make g2d_pm_ops static Sachin Kamat
@ 2012-08-29 7:02 ` Joonyoung Shim
2012-08-29 8:03 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Joonyoung Shim @ 2012-08-29 7:02 UTC (permalink / raw)
To: Sachin Kamat; +Cc: dri-devel, patches
On 08/28/2012 05:41 PM, Sachin Kamat wrote:
> Fixes the following warning:
> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
> symbol 'g2d_pm_ops' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index 6adfa4e..1065e90 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev)
> }
> #endif
>
> -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
Right, it should be static but i don't get any warning message without
static.
Thanks.
>
> struct platform_driver g2d_driver = {
> .probe = g2d_probe,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/exynos: Make g2d_pm_ops static
2012-08-29 7:02 ` Joonyoung Shim
@ 2012-08-29 8:03 ` Sachin Kamat
2012-09-03 2:39 ` InKi Dae
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2012-08-29 8:03 UTC (permalink / raw)
To: Joonyoung Shim; +Cc: dri-devel, patches
On 29 August 2012 12:32, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> On 08/28/2012 05:41 PM, Sachin Kamat wrote:
>>
>> Fixes the following warning:
>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
>> symbol 'g2d_pm_ops' was not declared. Should it be static?
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>> index 6adfa4e..1065e90 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev)
>> }
>> #endif
>> -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>
>
> Right, it should be static but i don't get any warning message without
> static.
You will get it if you enable sparse checking while building the kernel.
>
> Thanks.
>
>
>> struct platform_driver g2d_driver = {
>> .probe = g2d_probe,
>
>
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/exynos: Make g2d_pm_ops static
2012-08-29 8:03 ` Sachin Kamat
@ 2012-09-03 2:39 ` InKi Dae
0 siblings, 0 replies; 4+ messages in thread
From: InKi Dae @ 2012-09-03 2:39 UTC (permalink / raw)
To: Sachin Kamat; +Cc: dri-devel, patches
Applied. Thanks.
2012/8/29 Sachin Kamat <sachin.kamat@linaro.org>:
> On 29 August 2012 12:32, Joonyoung Shim <jy0922.shim@samsung.com> wrote:
>> On 08/28/2012 05:41 PM, Sachin Kamat wrote:
>>>
>>> Fixes the following warning:
>>> drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
>>> symbol 'g2d_pm_ops' was not declared. Should it be static?
>>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
>>> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> index 6adfa4e..1065e90 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
>>> @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev)
>>> }
>>> #endif
>>> -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>>> +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume);
>>
>>
>> Right, it should be static but i don't get any warning message without
>> static.
>
> You will get it if you enable sparse checking while building the kernel.
>
>>
>> Thanks.
>>
>>
>>> struct platform_driver g2d_driver = {
>>> .probe = g2d_probe,
>>
>>
>
>
>
> --
> With warm regards,
> Sachin
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-03 2:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-28 8:41 [PATCH] drm/exynos: Make g2d_pm_ops static Sachin Kamat
2012-08-29 7:02 ` Joonyoung Shim
2012-08-29 8:03 ` Sachin Kamat
2012-09-03 2:39 ` InKi Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.