From: Rajendra Nayak <rnayak@ti.com>
To: "Turquette, Mike" <mturquette@ti.com>
Cc: paul@pwsan.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage
Date: Thu, 30 Aug 2012 14:09:00 +0530 [thread overview]
Message-ID: <503F26A4.3050902@ti.com> (raw)
In-Reply-To: <CAJOA=zM2sFsrdohooKp1+zsV_AK6dKnoN37+Gs2oskBUK4J00w@mail.gmail.com>
On Thursday 30 August 2012 05:45 AM, Turquette, Mike wrote:
> On Wed, Aug 29, 2012 at 1:56 AM, Rajendra Nayak<rnayak@ti.com> wrote:
>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>> index d7f55e4..a3831a2 100644
>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> @@ -3156,6 +3156,7 @@ static struct omap_clk omap44xx_clks[] = {
>> CLK(NULL, "dss_tv_clk",&dss_tv_clk, CK_443X),
>> CLK(NULL, "dss_48mhz_clk",&dss_48mhz_clk, CK_443X),
>> CLK(NULL, "dss_dss_clk",&dss_dss_clk, CK_443X),
>> + CLK(NULL, "dss_fck",&dss_fck, CK_443X),
>> CLK("omapdss_dss", "ick",&dss_fck, CK_443X),
>
> Is it right to re-use dss_fck for the "ick" here? I think it is due
> to omap4 modulemode stuff but I don't have DM in front of me and
> wanted a double-check...
yes, its because of the wierdness of DSS clocks where a so-called
optional clock is actually a function clock.
>
> Regards,
> Mike
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage
Date: Thu, 30 Aug 2012 14:09:00 +0530 [thread overview]
Message-ID: <503F26A4.3050902@ti.com> (raw)
In-Reply-To: <CAJOA=zM2sFsrdohooKp1+zsV_AK6dKnoN37+Gs2oskBUK4J00w@mail.gmail.com>
On Thursday 30 August 2012 05:45 AM, Turquette, Mike wrote:
> On Wed, Aug 29, 2012 at 1:56 AM, Rajendra Nayak<rnayak@ti.com> wrote:
>> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>> index d7f55e4..a3831a2 100644
>> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> @@ -3156,6 +3156,7 @@ static struct omap_clk omap44xx_clks[] = {
>> CLK(NULL, "dss_tv_clk",&dss_tv_clk, CK_443X),
>> CLK(NULL, "dss_48mhz_clk",&dss_48mhz_clk, CK_443X),
>> CLK(NULL, "dss_dss_clk",&dss_dss_clk, CK_443X),
>> + CLK(NULL, "dss_fck",&dss_fck, CK_443X),
>> CLK("omapdss_dss", "ick",&dss_fck, CK_443X),
>
> Is it right to re-use dss_fck for the "ick" here? I think it is due
> to omap4 modulemode stuff but I don't have DM in front of me and
> wanted a double-check...
yes, its because of the wierdness of DSS clocks where a so-called
optional clock is actually a function clock.
>
> Regards,
> Mike
next prev parent reply other threads:[~2012-08-30 8:39 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 8:56 [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-08-29 8:56 ` Rajendra Nayak
2012-08-29 8:56 ` [PATCH v4 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-08-29 8:56 ` Rajendra Nayak
2012-08-30 0:03 ` Turquette, Mike
2012-08-30 0:03 ` Turquette, Mike
2012-08-29 8:56 ` [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-08-29 8:56 ` Rajendra Nayak
2012-08-30 0:08 ` Russell King - ARM Linux
2012-08-30 0:08 ` Russell King - ARM Linux
2012-08-30 8:37 ` Rajendra Nayak
2012-08-30 8:37 ` Rajendra Nayak
2012-08-30 0:15 ` Turquette, Mike
2012-08-30 0:15 ` Turquette, Mike
2012-08-30 8:39 ` Rajendra Nayak [this message]
2012-08-30 8:39 ` Rajendra Nayak
2012-08-30 11:57 ` Benoit Cousson
2012-08-30 11:57 ` Benoit Cousson
2012-08-30 16:42 ` Tomi Valkeinen
2012-08-30 16:42 ` Tomi Valkeinen
2012-08-31 6:23 ` Archit Taneja
2012-08-31 6:23 ` Archit Taneja
2012-08-31 7:15 ` Tomi Valkeinen
2012-08-31 7:15 ` Tomi Valkeinen
2012-08-31 8:20 ` Archit Taneja
2012-08-31 8:20 ` Archit Taneja
2012-08-31 8:27 ` Tomi Valkeinen
2012-08-31 8:27 ` Tomi Valkeinen
2012-08-31 8:28 ` Archit Taneja
2012-08-31 8:28 ` Archit Taneja
2012-10-05 9:46 ` OMAP4 clock/pm fixes [was: " Archit Taneja
2012-10-05 9:46 ` Archit Taneja
2012-10-05 12:20 ` Benoit Cousson
2012-10-05 12:20 ` Benoit Cousson
2012-10-05 12:29 ` Archit Taneja
2012-10-05 12:29 ` Archit Taneja
2012-10-05 12:37 ` Rajendra Nayak
2012-10-05 12:37 ` Rajendra Nayak
2012-10-05 13:20 ` Archit Taneja
2012-10-05 13:20 ` Archit Taneja
2012-10-05 13:31 ` Rajendra Nayak
2012-10-05 13:31 ` Rajendra Nayak
2012-10-05 13:46 ` Archit Taneja
2012-10-05 13:46 ` Archit Taneja
2012-10-05 13:51 ` Benoit Cousson
2012-10-05 13:51 ` Benoit Cousson
2012-09-22 18:55 ` Paul Walmsley
2012-09-22 18:55 ` Paul Walmsley
2012-09-24 5:09 ` Rajendra Nayak
2012-09-24 5:09 ` Rajendra Nayak
2012-08-29 8:56 ` [PATCH v4 3/3] ARM: OMAP2+: clock: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-08-29 8:56 ` Rajendra Nayak
2012-08-30 20:56 ` [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Paul Walmsley
2012-08-30 20:56 ` Paul Walmsley
2012-08-31 5:03 ` Vaibhav Hiremath
2012-08-31 5:03 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503F26A4.3050902@ti.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@ti.com \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.