All of lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <archit@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	paul@pwsan.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, "Turquette,
	Mike" <mturquette@ti.com>
Subject: Re: OMAP4 clock/pm fixes [was: [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage
Date: Fri, 5 Oct 2012 19:16:28 +0530	[thread overview]
Message-ID: <506EE4B4.6010903@ti.com> (raw)
In-Reply-To: <506EE14E.4080500@ti.com>

On Friday 05 October 2012 07:01 PM, Rajendra Nayak wrote:
>> If the clkdm is in HW_AUTO, I can get DSS in sleep(STBYST and IDLEST all
>> set). Is this helpful? Can we just leave modulemode on all the time?
>> That'll be the best :)
>
> Is everything around DSS enabled by default in omap2plus? If so, I
> haven't seen Tero (who has been working on getting OMAP4 to sleep)
> complain about DSS causing him any trouble. So you should be good
> with whats already there atleast from 'not-gating-sleep' point of
> view.

DSS is selected only as a module in omap2plus_defconfig, so the DSS 
driver would never kick in with the defconfig.

The DSS hwmods would be initialised though. If I boot up linux-next with 
omap2plus_defconfig, I get:

CM_DSS_CLKSTCTRL 0x3
CM_DSS_DSS_CLKCTRL 0x00060002

So the module is in standby, but IDLEST is 0x2, which says DSS is idle 
only with respect to the interconnect. In the bootloader, IDLEST was 
0x3. So I don't know if that's a good thing or not.

Archit


WARNING: multiple messages have this Message-ID (diff)
From: archit@ti.com (Archit Taneja)
To: linux-arm-kernel@lists.infradead.org
Subject: OMAP4 clock/pm fixes [was: [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage
Date: Fri, 5 Oct 2012 19:16:28 +0530	[thread overview]
Message-ID: <506EE4B4.6010903@ti.com> (raw)
In-Reply-To: <506EE14E.4080500@ti.com>

On Friday 05 October 2012 07:01 PM, Rajendra Nayak wrote:
>> If the clkdm is in HW_AUTO, I can get DSS in sleep(STBYST and IDLEST all
>> set). Is this helpful? Can we just leave modulemode on all the time?
>> That'll be the best :)
>
> Is everything around DSS enabled by default in omap2plus? If so, I
> haven't seen Tero (who has been working on getting OMAP4 to sleep)
> complain about DSS causing him any trouble. So you should be good
> with whats already there atleast from 'not-gating-sleep' point of
> view.

DSS is selected only as a module in omap2plus_defconfig, so the DSS 
driver would never kick in with the defconfig.

The DSS hwmods would be initialised though. If I boot up linux-next with 
omap2plus_defconfig, I get:

CM_DSS_CLKSTCTRL 0x3
CM_DSS_DSS_CLKCTRL 0x00060002

So the module is in standby, but IDLEST is 0x2, which says DSS is idle 
only with respect to the interconnect. In the bootloader, IDLEST was 
0x3. So I don't know if that's a good thing or not.

Archit

  reply	other threads:[~2012-10-05 13:46 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29  8:56 [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Rajendra Nayak
2012-08-29  8:56 ` Rajendra Nayak
2012-08-29  8:56 ` [PATCH v4 1/3] ARM: omap: clk: add clk_prepare and clk_unprepare Rajendra Nayak
2012-08-29  8:56   ` Rajendra Nayak
2012-08-30  0:03   ` Turquette, Mike
2012-08-30  0:03     ` Turquette, Mike
2012-08-29  8:56 ` [PATCH v4 2/3] ARM: omap: hwmod: get rid of all omap_clk_get_by_name usage Rajendra Nayak
2012-08-29  8:56   ` Rajendra Nayak
2012-08-30  0:08   ` Russell King - ARM Linux
2012-08-30  0:08     ` Russell King - ARM Linux
2012-08-30  8:37     ` Rajendra Nayak
2012-08-30  8:37       ` Rajendra Nayak
2012-08-30  0:15   ` Turquette, Mike
2012-08-30  0:15     ` Turquette, Mike
2012-08-30  8:39     ` Rajendra Nayak
2012-08-30  8:39       ` Rajendra Nayak
2012-08-30 11:57       ` Benoit Cousson
2012-08-30 11:57         ` Benoit Cousson
2012-08-30 16:42         ` Tomi Valkeinen
2012-08-30 16:42           ` Tomi Valkeinen
2012-08-31  6:23           ` Archit Taneja
2012-08-31  6:23             ` Archit Taneja
2012-08-31  7:15             ` Tomi Valkeinen
2012-08-31  7:15               ` Tomi Valkeinen
2012-08-31  8:20               ` Archit Taneja
2012-08-31  8:20                 ` Archit Taneja
2012-08-31  8:27                 ` Tomi Valkeinen
2012-08-31  8:27                   ` Tomi Valkeinen
2012-08-31  8:28                   ` Archit Taneja
2012-08-31  8:28                     ` Archit Taneja
2012-10-05  9:46                     ` OMAP4 clock/pm fixes [was: " Archit Taneja
2012-10-05  9:46                       ` Archit Taneja
2012-10-05 12:20                       ` Benoit Cousson
2012-10-05 12:20                         ` Benoit Cousson
2012-10-05 12:29                         ` Archit Taneja
2012-10-05 12:29                           ` Archit Taneja
2012-10-05 12:37                           ` Rajendra Nayak
2012-10-05 12:37                             ` Rajendra Nayak
2012-10-05 13:20                             ` Archit Taneja
2012-10-05 13:20                               ` Archit Taneja
2012-10-05 13:31                               ` Rajendra Nayak
2012-10-05 13:31                                 ` Rajendra Nayak
2012-10-05 13:46                                 ` Archit Taneja [this message]
2012-10-05 13:46                                   ` Archit Taneja
2012-10-05 13:51                               ` Benoit Cousson
2012-10-05 13:51                                 ` Benoit Cousson
2012-09-22 18:55   ` Paul Walmsley
2012-09-22 18:55     ` Paul Walmsley
2012-09-24  5:09     ` Rajendra Nayak
2012-09-24  5:09       ` Rajendra Nayak
2012-08-29  8:56 ` [PATCH v4 3/3] ARM: OMAP2+: clock: Remove all direct dereferencing of struct clk Rajendra Nayak
2012-08-29  8:56   ` Rajendra Nayak
2012-08-30 20:56 ` [PATCH v4 0/3] Prepare for OMAP2+ movement to Common Clk Paul Walmsley
2012-08-30 20:56   ` Paul Walmsley
2012-08-31  5:03   ` Vaibhav Hiremath
2012-08-31  5:03     ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506EE4B4.6010903@ti.com \
    --to=archit@ti.com \
    --cc=b-cousson@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@ti.com \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.