From: Vlad Yasevich <vyasevich@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, eric.dumazet@gmail.com, sri@us.ibm.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion
Date: Mon, 10 Sep 2012 14:21:47 +0000 [thread overview]
Message-ID: <504DF77B.7070000@gmail.com> (raw)
In-Reply-To: <1347283338-4249-3-git-send-email-nicolas.dichtel@6wind.com>
On 09/10/2012 09:22 AM, Nicolas Dichtel wrote:
> When a policy is inserted or deleted, all dst should be recalculated.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> net/xfrm/xfrm_policy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index 741a32a..67f456d 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -602,6 +602,7 @@ int xfrm_policy_insert(int dir, struct xfrm_policy *policy, int excl)
> xfrm_pol_hold(policy);
> net->xfrm.policy_count[dir]++;
> atomic_inc(&flow_cache_genid);
> + rt_genid_bump(net);
> if (delpol)
> __xfrm_policy_unlink(delpol, dir);
> policy->index = delpol ? delpol->index : xfrm_gen_index(net, dir);
>
What about security_load_policy() and security_set_bools(). They also
bumps the flow_cache_genid by way of selinux_xfrm_notify_policyload().
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vyasevich@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, eric.dumazet@gmail.com, sri@us.ibm.com,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion
Date: Mon, 10 Sep 2012 10:21:47 -0400 [thread overview]
Message-ID: <504DF77B.7070000@gmail.com> (raw)
In-Reply-To: <1347283338-4249-3-git-send-email-nicolas.dichtel@6wind.com>
On 09/10/2012 09:22 AM, Nicolas Dichtel wrote:
> When a policy is inserted or deleted, all dst should be recalculated.
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> ---
> net/xfrm/xfrm_policy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index 741a32a..67f456d 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -602,6 +602,7 @@ int xfrm_policy_insert(int dir, struct xfrm_policy *policy, int excl)
> xfrm_pol_hold(policy);
> net->xfrm.policy_count[dir]++;
> atomic_inc(&flow_cache_genid);
> + rt_genid_bump(net);
> if (delpol)
> __xfrm_policy_unlink(delpol, dir);
> policy->index = delpol ? delpol->index : xfrm_gen_index(net, dir);
>
What about security_load_policy() and security_set_bools(). They also
bumps the flow_cache_genid by way of selinux_xfrm_notify_policyload().
-vlad
next prev parent reply other threads:[~2012-09-10 14:21 UTC|newest]
Thread overview: 104+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:47 [PATCH] sctp: check dst validity after IPsec operations Nicolas Dichtel
2012-09-06 17:40 ` Nicolas Dichtel
2012-09-06 16:04 ` Vlad Yasevich
2012-09-06 16:04 ` Vlad Yasevich
2012-09-06 16:40 ` Nicolas Dichtel
2012-09-06 16:40 ` Nicolas Dichtel
2012-09-06 17:03 ` Vlad Yasevich
2012-09-06 17:03 ` Vlad Yasevich
2012-09-07 12:24 ` Nicolas Dichtel
2012-09-07 12:24 ` Nicolas Dichtel
2012-09-07 12:07 ` Nicolas Dichtel
2012-09-07 12:07 ` Nicolas Dichtel
2012-09-06 18:10 ` David Miller
2012-09-06 18:10 ` David Miller
2012-09-07 13:47 ` Nicolas Dichtel
2012-09-07 13:47 ` Nicolas Dichtel
2012-09-07 13:55 ` [PATCH RFC net-next 0/2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-07 15:57 ` Nicolas Dichtel
2012-09-07 13:56 ` [PATCH 1/2] dst: take into account policy update on check() Nicolas Dichtel
2012-09-07 15:57 ` Nicolas Dichtel
2012-09-07 14:20 ` Vlad Yasevich
2012-09-07 14:20 ` Vlad Yasevich
2012-09-07 14:35 ` Eric Dumazet
2012-09-07 14:35 ` Eric Dumazet
2012-09-07 14:47 ` Nicolas Dichtel
2012-09-07 14:47 ` Nicolas Dichtel
2012-09-07 15:09 ` Eric Dumazet
2012-09-07 15:09 ` Eric Dumazet
2012-09-07 15:13 ` Nicolas Dichtel
2012-09-07 15:13 ` Nicolas Dichtel
2012-09-07 15:21 ` Eric Dumazet
2012-09-07 15:21 ` Eric Dumazet
2012-09-07 18:48 ` David Miller
2012-09-07 18:48 ` David Miller
2012-09-07 18:48 ` David Miller
2012-09-07 18:48 ` David Miller
2012-09-10 12:47 ` Nicolas Dichtel
2012-09-10 12:47 ` Nicolas Dichtel
2012-09-10 13:10 ` Eric Dumazet
2012-09-10 13:10 ` Eric Dumazet
2012-09-10 13:22 ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-10 13:22 ` Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-10 13:22 ` Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-10 13:22 ` Nicolas Dichtel
2012-09-10 14:21 ` Vlad Yasevich [this message]
2012-09-10 14:21 ` Vlad Yasevich
2012-09-10 14:56 ` Nicolas Dichtel
2012-09-10 14:56 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-11 8:09 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-11 8:09 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-11 8:09 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-11 8:09 ` Nicolas Dichtel
2012-09-11 8:09 ` [PATCH net-next v3 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-11 8:09 ` Nicolas Dichtel
2012-09-12 7:40 ` Eric Dumazet
2012-09-12 7:40 ` Eric Dumazet
2012-09-17 16:49 ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries David Miller
2012-09-17 16:49 ` David Miller
2012-09-17 18:14 ` Vlad Yasevich
2012-09-17 18:14 ` Vlad Yasevich
2012-09-17 18:25 ` David Miller
2012-09-17 18:25 ` David Miller
2012-09-17 19:52 ` Nicolas Dichtel
2012-09-17 19:52 ` Nicolas Dichtel
2012-09-17 19:54 ` David Miller
2012-09-17 19:54 ` David Miller
2012-09-18 20:08 ` David Miller
2012-09-18 20:08 ` David Miller
2012-09-10 13:22 ` [PATCH net-next v2 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-10 13:22 ` Nicolas Dichtel
2012-09-10 14:29 ` Vlad Yasevich
2012-09-10 14:29 ` Vlad Yasevich
2012-09-10 14:34 ` Nicolas Dichtel
2012-09-10 14:34 ` Nicolas Dichtel
2012-09-10 14:43 ` Vlad Yasevich
2012-09-10 14:43 ` Vlad Yasevich
2012-09-10 14:44 ` Nicolas Dichtel
2012-09-10 14:44 ` Nicolas Dichtel
2012-09-10 13:22 ` [PATCH net-next v2 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-10 13:22 ` Nicolas Dichtel
2012-09-10 14:35 ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Vlad Yasevich
2012-09-10 14:35 ` Vlad Yasevich
2012-09-10 14:38 ` Nicolas Dichtel
2012-09-10 14:38 ` Nicolas Dichtel
2012-09-10 17:18 ` David Miller
2012-09-10 17:18 ` David Miller
2012-09-10 17:59 ` Vlad Yasevich
2012-09-10 17:59 ` Vlad Yasevich
2012-09-10 18:01 ` David Miller
2012-09-10 18:01 ` David Miller
2012-09-22 16:49 ` Jan Engelhardt
2012-09-22 16:49 ` Jan Engelhardt
2012-09-07 14:51 ` [PATCH 1/2] dst: take into account policy update on check() Vlad Yasevich
2012-09-07 14:51 ` Vlad Yasevich
2012-09-07 15:08 ` Eric Dumazet
2012-09-07 15:08 ` Eric Dumazet
2012-09-07 13:56 ` [PATCH 2/2] ipv6: remove rt6i_flow_cache_genid field in rt6_info Nicolas Dichtel
2012-09-07 15:57 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DF77B.7070000@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.