* Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 15:10 Chris Ferron
0 siblings, 0 replies; 6+ messages in thread
From: Chris Ferron @ 2012-09-14 15:10 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2666 bytes --]
On 09/14/2012 03:23 AM, Sergey Senozhatsky wrote:
> On (09/14/12 13:46), Igor Zhbanov wrote:
>> Remove unneded escaping backslashes from CSS.
>> ---
>> src/powertop.css | 16 ++++++++--------
>> 1 files changed, 8 insertions(+), 8 deletions(-)
>>
> looks good to me, thank you Igor.
>
> -ss
>
Patch Merged
Thank You
-C
>> diff --git a/src/powertop.css b/src/powertop.css
>> index 087e384..5d303dc 100644
>> --- a/src/powertop.css
>> +++ b/src/powertop.css
>> @@ -21,14 +21,14 @@ $(document).ready(function(){
>> $('#tuning h2').addClass('hide');
>> $('#tuning table').addClass('hide');
>>
>> - $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
>> - $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
>> - $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
>> - $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
>> - $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
>> - $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
>> - $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
>> - $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
>> + $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
>> + $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
>> + $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
>> + $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
>> + $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
>> + $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
>> + $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
>> + $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
>> $('#top .SummaryButton').toggleClass('pressed');
>>
>> }
>> --
>> 1.7.5.4
>>
>> _______________________________________________
>> PowerTop mailing list
>> PowerTop(a)lists.01.org
>> https://lists.01.org/mailman/listinfo/powertop
>>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 10:29 Sergey Senozhatsky
0 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2012-09-14 10:29 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 3673 bytes --]
On (09/14/12 14:15), Igor Zhbanov wrote:
> Dear Paul,
>
> Paul Menzel wrote:
> >Am Freitag, den 14.09.2012, 13:46 +0400 schrieb Igor Zhbanov:
> >>Remove unneded escaping backslashes from CSS.
> >copying the summary into the body is not useful, because it adds no
> >further information.
> What to do when the commit summary describes all of the issue?
> Should I left body empty?
> >Please also add why the escaping was added beforehand and why it is
> >unneeded.
> I don't know why this particular escapes was added.
> In the file powertop.css there are lots of escaped quotes characters (")
> because later each line of this file will be wrapped inside of "LINE\n"
> to form a C array css[] in the file css.h.
>
> But I don't know the reason for putting backslashes before slash in a
> closing
> </div> tag for jQuery append() method. I don't know any special handling
> of slashes in append() method.
>
> Should I repost the patch with another description?
>
personally, I don't think so. it's rather hard to come up with commit message
when commit summary tells the whole story.
-ss
> >>---
> >> src/powertop.css | 16 ++++++++--------
> >> 1 files changed, 8 insertions(+), 8 deletions(-)
> >>
> >>diff --git a/src/powertop.css b/src/powertop.css
> >>index 087e384..5d303dc 100644
> >>--- a/src/powertop.css
> >>+++ b/src/powertop.css
> >>@@ -21,14 +21,14 @@ $(document).ready(function(){
> >> $('#tuning h2').addClass('hide');
> >> $('#tuning table').addClass('hide');
> >>- $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
> >>- $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
> >>- $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
> >>- $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
> >>- $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
> >>- $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
> >>- $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
> >>- $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
> >>+ $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
> >>+ $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
> >>+ $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
> >>+ $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
> >>+ $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
> >>+ $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
> >>+ $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
> >>+ $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
> >> $('#top .SummaryButton').toggleClass('pressed');
> >> }
>
> --
> Best regards,
> Igor Zhbanov,
> Expert Software Engineer,
> phone: +7 (495) 797 25 00 ext 3806
> e-mail: i.zhbanov(a)samsung.com
>
> ASWG, Moscow R&D center, Samsung Electronics
> 12 Dvintsev street, building 1
> 127018, Moscow, Russian Federation
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 10:23 Sergey Senozhatsky
0 siblings, 0 replies; 6+ messages in thread
From: Sergey Senozhatsky @ 2012-09-14 10:23 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]
On (09/14/12 13:46), Igor Zhbanov wrote:
> Remove unneded escaping backslashes from CSS.
> ---
> src/powertop.css | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
looks good to me, thank you Igor.
-ss
> diff --git a/src/powertop.css b/src/powertop.css
> index 087e384..5d303dc 100644
> --- a/src/powertop.css
> +++ b/src/powertop.css
> @@ -21,14 +21,14 @@ $(document).ready(function(){
> $('#tuning h2').addClass('hide');
> $('#tuning table').addClass('hide');
>
> - $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
> - $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
> - $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
> - $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
> - $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
> - $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
> - $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
> - $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
> + $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
> + $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
> + $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
> + $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
> + $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
> + $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
> + $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
> + $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
> $('#top .SummaryButton').toggleClass('pressed');
>
> }
> --
> 1.7.5.4
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 10:15 Igor Zhbanov
0 siblings, 0 replies; 6+ messages in thread
From: Igor Zhbanov @ 2012-09-14 10:15 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 3256 bytes --]
Dear Paul,
Paul Menzel wrote:
> Am Freitag, den 14.09.2012, 13:46 +0400 schrieb Igor Zhbanov:
>> Remove unneded escaping backslashes from CSS.
> copying the summary into the body is not useful, because it adds no
> further information.
What to do when the commit summary describes all of the issue?
Should I left body empty?
> Please also add why the escaping was added beforehand and why it is
> unneeded.
I don't know why this particular escapes was added.
In the file powertop.css there are lots of escaped quotes characters (")
because later each line of this file will be wrapped inside of "LINE\n"
to form a C array css[] in the file css.h.
But I don't know the reason for putting backslashes before slash in a
closing
</div> tag for jQuery append() method. I don't know any special handling
of slashes in append() method.
Should I repost the patch with another description?
>> ---
>> src/powertop.css | 16 ++++++++--------
>> 1 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/src/powertop.css b/src/powertop.css
>> index 087e384..5d303dc 100644
>> --- a/src/powertop.css
>> +++ b/src/powertop.css
>> @@ -21,14 +21,14 @@ $(document).ready(function(){
>> $('#tuning h2').addClass('hide');
>> $('#tuning table').addClass('hide');
>>
>> - $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
>> - $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
>> - $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
>> - $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
>> - $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
>> - $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
>> - $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
>> - $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
>> + $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
>> + $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
>> + $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
>> + $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
>> + $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
>> + $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
>> + $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
>> + $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
>> $('#top .SummaryButton').toggleClass('pressed');
>>
>> }
--
Best regards,
Igor Zhbanov,
Expert Software Engineer,
phone: +7 (495) 797 25 00 ext 3806
e-mail: i.zhbanov(a)samsung.com
ASWG, Moscow R&D center, Samsung Electronics
12 Dvintsev street, building 1
127018, Moscow, Russian Federation
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 10:02 Paul Menzel
0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2012-09-14 10:02 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2384 bytes --]
Dear Igor,
Am Freitag, den 14.09.2012, 13:46 +0400 schrieb Igor Zhbanov:
> Remove unneded escaping backslashes from CSS.
copying the summary into the body is not useful, because it adds no
further information.
Please also add why the escaping was added beforehand and why it is
unneeded.
> ---
> src/powertop.css | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/powertop.css b/src/powertop.css
> index 087e384..5d303dc 100644
> --- a/src/powertop.css
> +++ b/src/powertop.css
> @@ -21,14 +21,14 @@ $(document).ready(function(){
> $('#tuning h2').addClass('hide');
> $('#tuning table').addClass('hide');
>
> - $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
> - $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
> - $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
> - $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
> - $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
> - $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
> - $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
> - $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
> + $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
> + $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
> + $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
> + $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
> + $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
> + $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
> + $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
> + $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
> $('#top .SummaryButton').toggleClass('pressed');
>
> }
Thanks,
Paul
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* [Powertop] [PATCH] Remove unneded escaping backslashes from CSS
@ 2012-09-14 9:46 Igor Zhbanov
0 siblings, 0 replies; 6+ messages in thread
From: Igor Zhbanov @ 2012-09-14 9:46 UTC (permalink / raw)
To: powertop
[-- Attachment #1: Type: text/plain, Size: 2059 bytes --]
Remove unneded escaping backslashes from CSS.
---
src/powertop.css | 16 ++++++++--------
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/powertop.css b/src/powertop.css
index 087e384..5d303dc 100644
--- a/src/powertop.css
+++ b/src/powertop.css
@@ -21,14 +21,14 @@ $(document).ready(function(){
$('#tuning h2').addClass('hide');
$('#tuning table').addClass('hide');
- $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info<\\/div>');
- $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary<\\/div>');
- $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle<\\/div>');
- $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency<\\/div>');
- $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info<\\/div>');
- $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info<\\/div>');
- $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning<\\/div>');
- $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All<\\/div>');
+ $('#top').append('<div class=\"SystemButton\" onclick=\"toggleSystem()\">System Info</div>');
+ $('#top').append('<div class=\"SummaryButton\" onclick=\"toggleSummary()\">Summary</div>');
+ $('#top').append('<div class=\"CpuidleButton\" onclick=\"toggleCpuidle()\">CPU Idle</div>');
+ $('#top').append('<div class=\"CpufreqButton\" onclick=\"toggleCpufreq()\">CPU Frequency</div>');
+ $('#top').append('<div class=\"SoftwareButton\" onclick=\"toggleSoftware()\">Software info</div>');
+ $('#top').append('<div class=\"DeviceButton\" onclick=\"toggleDevice()\">Device Info</div>');
+ $('#top').append('<div class=\"TuningButton\" onclick=\"toggleTuning()\">Tuning</div>');
+ $('#top').append('<div class=\"AllButton\" onclick=\"toggleAll()\">All</div>');
$('#top .SummaryButton').toggleClass('pressed');
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-14 15:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 15:10 [Powertop] [PATCH] Remove unneded escaping backslashes from CSS Chris Ferron
-- strict thread matches above, loose matches on Subject: below --
2012-09-14 10:29 Sergey Senozhatsky
2012-09-14 10:23 Sergey Senozhatsky
2012-09-14 10:15 Igor Zhbanov
2012-09-14 10:02 Paul Menzel
2012-09-14 9:46 Igor Zhbanov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.