From: Lars-Peter Clausen <lars@metafoo.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iio: dac/ad5755: signedness bug in ad5755_setup_pdata()
Date: Wed, 19 Sep 2012 17:08:05 +0000 [thread overview]
Message-ID: <5059FBF5.7070703@metafoo.de> (raw)
In-Reply-To: <20120919062700.GA28864@elgon.mountain>
On 09/19/2012 08:27 AM, Dan Carpenter wrote:
> We need "ret" to be signed for the error handling to work correctly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks,
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> index e6dbe5f..5db3506 100644
> --- a/drivers/iio/dac/ad5755.c
> +++ b/drivers/iio/dac/ad5755.c
> @@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev,
> const struct ad5755_platform_data *pdata)
> {
> struct ad5755_state *st = iio_priv(indio_dev);
> - unsigned int ret;
> unsigned int val;
> unsigned int i;
> + int ret;
>
> if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE ||
> pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ ||
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] iio: dac/ad5755: signedness bug in ad5755_setup_pdata()
Date: Wed, 19 Sep 2012 19:08:05 +0200 [thread overview]
Message-ID: <5059FBF5.7070703@metafoo.de> (raw)
In-Reply-To: <20120919062700.GA28864@elgon.mountain>
On 09/19/2012 08:27 AM, Dan Carpenter wrote:
> We need "ret" to be signed for the error handling to work correctly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks,
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
> diff --git a/drivers/iio/dac/ad5755.c b/drivers/iio/dac/ad5755.c
> index e6dbe5f..5db3506 100644
> --- a/drivers/iio/dac/ad5755.c
> +++ b/drivers/iio/dac/ad5755.c
> @@ -451,9 +451,9 @@ static int __devinit ad5755_setup_pdata(struct iio_dev *indio_dev,
> const struct ad5755_platform_data *pdata)
> {
> struct ad5755_state *st = iio_priv(indio_dev);
> - unsigned int ret;
> unsigned int val;
> unsigned int i;
> + int ret;
>
> if (pdata->dc_dc_phase > AD5755_DC_DC_PHASE_90_DEGREE ||
> pdata->dc_dc_freq > AD5755_DC_DC_FREQ_650kHZ ||
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-19 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 6:27 [patch] iio: dac/ad5755: signedness bug in ad5755_setup_pdata() Dan Carpenter
2012-09-19 6:27 ` Dan Carpenter
2012-09-19 17:08 ` Lars-Peter Clausen [this message]
2012-09-19 17:08 ` Lars-Peter Clausen
2012-09-22 9:11 ` Jonathan Cameron
2012-09-22 9:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059FBF5.7070703@metafoo.de \
--to=lars@metafoo.de \
--cc=dan.carpenter@oracle.com \
--cc=jic23@cam.ac.uk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.