From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Jon Mason <jdmason@kudzu.us>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
<linux-driver@qlogic.com>, <linux-scsi@vger.kernel.org>,
PCI <linux-pci@vger.kernel.org>,
Saurav Kashyap <saurav.kashyap@qlogic.com>,
Chad Dupuis <chad.dupuis@qlogic.com>
Subject: Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug
Date: Thu, 20 Sep 2012 20:26:18 +0800 [thread overview]
Message-ID: <505B0B6A.2050709@huawei.com> (raw)
In-Reply-To: <505A7599.5070103@huawei.com>
On 2012/9/20 9:47, Yijing Wang wrote:
>>> We compared the two situations after BIOS initialization, and found Max Payload Size in DEVCTRL is 256B
>>> if FC card had been installed, if the slot is empty, Max Payload Size is 128B. We force it to be 128B when
>>> FC card installed when system boot up. Finally pci hotplug becomes ok. So I suspect maybe our PCIe hardware
>>> has problem supporting 256B.
>>
>> Ah, this sounds like something I've been worried about for a while,
>> i.e., do we handle MPS correctly when we hot-add devices?
>>
>> Yijing, I'm not quite clear on what you're observing. I guess you're
>> saying that if an FC card is installed at boot, the BIOS sets MPS to
>> 256, and that if no FC card is installed, the BIOS sets MPS to 128?
>
> Yes.
>
>> You haven't mentioned any Linux boot options, so I assume you haven't
>> tried any. Does "pci=pcie_bus_safe" make any difference?
>
> Yes, I don't add any Linux boot options before. I will try this boot option
> "pci=pcie_bus_safe".
>
>> Jon, here's a pointer to the beginning of the thread:
>> http://marc.info/?l=linux-pci&m=134770460302298&w=2 (full dmesg log at
>> http://marc.info/?l=linux-scsi&m=134788365823217&w=2). I'm not sure
>> we have enough in the dmesg log to diagnose an issue like this. I
>> wonder if it would be useful to log the current setting, so we could
>> notice BIOS default differences like this one.
>>
Hi Bjorn,
After add "pci=pcie_bus_safe" boot options, Hot-plug for FC card is OK.
It's great! Thanks for your help!
Giri, it's not the fc card problem, we fix this problem by add boot option
"pci=pcie_bus_safe" which force the MPS of the entire system to the smallest
possible.
Thanks
Yijing
>> Bjorn
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> .
>>
>
>
--
Thanks!
Yijing
WARNING: multiple messages have this Message-ID (diff)
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Giridhar Malavali <giridhar.malavali@qlogic.com>
Cc: Jon Mason <jdmason@kudzu.us>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
linux-driver@qlogic.com, linux-scsi@vger.kernel.org,
PCI <linux-pci@vger.kernel.org>,
Saurav Kashyap <saurav.kashyap@qlogic.com>,
Chad Dupuis <chad.dupuis@qlogic.com>
Subject: Re: Fail to probe qla2xxx fiber channel card while doing pci hotplug
Date: Thu, 20 Sep 2012 20:26:18 +0800 [thread overview]
Message-ID: <505B0B6A.2050709@huawei.com> (raw)
In-Reply-To: <505A7599.5070103@huawei.com>
On 2012/9/20 9:47, Yijing Wang wrote:
>>> We compared the two situations after BIOS initialization, and found Max Payload Size in DEVCTRL is 256B
>>> if FC card had been installed, if the slot is empty, Max Payload Size is 128B. We force it to be 128B when
>>> FC card installed when system boot up. Finally pci hotplug becomes ok. So I suspect maybe our PCIe hardware
>>> has problem supporting 256B.
>>
>> Ah, this sounds like something I've been worried about for a while,
>> i.e., do we handle MPS correctly when we hot-add devices?
>>
>> Yijing, I'm not quite clear on what you're observing. I guess you're
>> saying that if an FC card is installed at boot, the BIOS sets MPS to
>> 256, and that if no FC card is installed, the BIOS sets MPS to 128?
>
> Yes.
>
>> You haven't mentioned any Linux boot options, so I assume you haven't
>> tried any. Does "pci=pcie_bus_safe" make any difference?
>
> Yes, I don't add any Linux boot options before. I will try this boot option
> "pci=pcie_bus_safe".
>
>> Jon, here's a pointer to the beginning of the thread:
>> http://marc.info/?l=linux-pci&m=134770460302298&w=2 (full dmesg log at
>> http://marc.info/?l=linux-scsi&m=134788365823217&w=2). I'm not sure
>> we have enough in the dmesg log to diagnose an issue like this. I
>> wonder if it would be useful to log the current setting, so we could
>> notice BIOS default differences like this one.
>>
Hi Bjorn,
After add "pci=pcie_bus_safe" boot options, Hot-plug for FC card is OK.
It's great! Thanks for your help!
Giri, it's not the fc card problem, we fix this problem by add boot option
"pci=pcie_bus_safe" which force the MPS of the entire system to the smallest
possible.
Thanks
Yijing
>> Bjorn
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> .
>>
>
>
--
Thanks!
Yijing
next prev parent reply other threads:[~2012-09-20 12:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 10:22 Fail to probe qla2xxx fiber channel card while doing pci hotplug Yijing Wang
2012-09-15 10:22 ` Yijing Wang
2012-09-16 3:30 ` Bjorn Helgaas
2012-09-17 12:06 ` Yijing Wang
2012-09-17 18:15 ` Giridhar Malavali
2012-09-18 1:26 ` Yijing Wang
2012-09-18 17:54 ` Bjorn Helgaas
2012-09-18 23:49 ` Giridhar Malavali
2012-09-20 1:27 ` Yijing Wang
2012-09-19 1:50 ` Yijing Wang
2012-09-19 1:50 ` Yijing Wang
2012-09-19 13:39 ` Bjorn Helgaas
2012-09-19 15:31 ` Jiang Liu
2012-09-20 1:39 ` Yijing Wang
2012-09-20 1:39 ` Yijing Wang
2012-09-20 1:47 ` Yijing Wang
2012-09-20 1:47 ` Yijing Wang
2012-09-20 12:26 ` Yijing Wang [this message]
2012-09-20 12:26 ` Yijing Wang
2012-09-20 15:46 ` Bjorn Helgaas
2012-09-20 15:58 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B0B6A.2050709@huawei.com \
--to=wangyijing@huawei.com \
--cc=andrew.vasquez@qlogic.com \
--cc=bhelgaas@google.com \
--cc=chad.dupuis@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=jdmason@kudzu.us \
--cc=linux-driver@qlogic.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.