* [PATCH] perf: Fix parallel build
@ 2012-09-20 23:53 Eric Sandeen
2012-09-21 0:24 ` Namhyung Kim
2012-09-21 1:12 ` [PATCH V2] " Eric Sandeen
0 siblings, 2 replies; 9+ messages in thread
From: Eric Sandeen @ 2012-09-20 23:53 UTC (permalink / raw)
To: kernel list; +Cc: Arnaldo Carvalho de Melo
Parallel builds of perf were failing for me on a 32p box, with:
* new build flags or prefix
util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
...
make: *** [util/pmu-flex.o] Error 1
make: *** Waiting for unfinished jobs....
This can pretty quickly be seen by adding a sleep in front of
the bison call in tools/perf/Makefile and running make -j4 on a
smaller box:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
Adding the following dependency fixes it for me:
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index bad726a..6c389d9 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -219,7 +219,7 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l
$(OUTPUT)util/parse-events-bison.c: util/parse-events.y
$(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
-$(OUTPUT)util/pmu-flex.c: util/pmu.l
+$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
$(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] perf: Fix parallel build
2012-09-20 23:53 [PATCH] perf: Fix parallel build Eric Sandeen
@ 2012-09-21 0:24 ` Namhyung Kim
2012-09-21 1:08 ` Eric Sandeen
2012-09-21 1:12 ` [PATCH V2] " Eric Sandeen
1 sibling, 1 reply; 9+ messages in thread
From: Namhyung Kim @ 2012-09-21 0:24 UTC (permalink / raw)
To: Eric Sandeen; +Cc: kernel list, Arnaldo Carvalho de Melo
Hi Eric,
On Thu, 20 Sep 2012 18:53:01 -0500, Eric Sandeen wrote:
> Parallel builds of perf were failing for me on a 32p box, with:
>
> * new build flags or prefix
> util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
>
> ...
>
> make: *** [util/pmu-flex.o] Error 1
> make: *** Waiting for unfinished jobs....
>
> This can pretty quickly be seen by adding a sleep in front of
> the bison call in tools/perf/Makefile and running make -j4 on a
> smaller box:
>
> sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
>
> Adding the following dependency fixes it for me:
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index bad726a..6c389d9 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
> @@ -219,7 +219,7 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l
> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
>
> -$(OUTPUT)util/pmu-flex.c: util/pmu.l
> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
>
> $(OUTPUT)util/pmu-bison.c: util/pmu.y
I guess the $(OUTPUT)util/parse-events-flex.c: line has the same
problem. Could you check and submit a patch for that too?
Thanks,
Namhyung
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] perf: Fix parallel build
2012-09-21 0:24 ` Namhyung Kim
@ 2012-09-21 1:08 ` Eric Sandeen
0 siblings, 0 replies; 9+ messages in thread
From: Eric Sandeen @ 2012-09-21 1:08 UTC (permalink / raw)
To: Namhyung Kim; +Cc: kernel list, Arnaldo Carvalho de Melo
On 9/20/12 7:24 PM, Namhyung Kim wrote:
> Hi Eric,
>
> On Thu, 20 Sep 2012 18:53:01 -0500, Eric Sandeen wrote:
>> Parallel builds of perf were failing for me on a 32p box, with:
>>
>> * new build flags or prefix
>> util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
>>
>> ...
>>
>> make: *** [util/pmu-flex.o] Error 1
>> make: *** Waiting for unfinished jobs....
>>
>> This can pretty quickly be seen by adding a sleep in front of
>> the bison call in tools/perf/Makefile and running make -j4 on a
>> smaller box:
>>
>> sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
>>
>> Adding the following dependency fixes it for me:
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
>> index bad726a..6c389d9 100644
>> --- a/tools/perf/Makefile
>> +++ b/tools/perf/Makefile
>> @@ -219,7 +219,7 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l
>> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
>> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
>>
>> -$(OUTPUT)util/pmu-flex.c: util/pmu.l
>> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
>> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
>>
>> $(OUTPUT)util/pmu-bison.c: util/pmu.y
>
> I guess the $(OUTPUT)util/parse-events-flex.c: line has the same
> problem. Could you check and submit a patch for that too?
>
> Thanks,
> Namhyung
>
Whoops you are right, will resent V2 shortly, thanks.
-Eric
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V2] perf: Fix parallel build
2012-09-20 23:53 [PATCH] perf: Fix parallel build Eric Sandeen
2012-09-21 0:24 ` Namhyung Kim
@ 2012-09-21 1:12 ` Eric Sandeen
2012-09-21 2:07 ` Namhyung Kim
1 sibling, 1 reply; 9+ messages in thread
From: Eric Sandeen @ 2012-09-21 1:12 UTC (permalink / raw)
To: kernel list; +Cc: Arnaldo Carvalho de Melo, Namhyung Kim
Parallel builds of perf were failing for me on a 32p box, with:
* new build flags or prefix
util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
...
make: *** [util/pmu-flex.o] Error 1
make: *** Waiting for unfinished jobs....
This can pretty quickly be seen by adding a sleep in front of
the bison calls in tools/perf/Makefile and running make -j4 on a
smaller box i.e.:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
Adding the following dependencies fixes it for me.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: Fix other bison dependency caught by Namhyung Kim <namhyung@kernel.org>, thanks.
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 35655c3..8d883de 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -221,13 +221,13 @@ export PERL_PATH
FLEX = flex
BISON= bison
-$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
+$(OUTPUT)util/parse-events-flex.c: util/parse-events.l util/parse-events-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
$(OUTPUT)util/parse-events-bison.c: util/parse-events.y
$(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
-$(OUTPUT)util/pmu-flex.c: util/pmu.l
+$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
$(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH V2] perf: Fix parallel build
2012-09-21 1:12 ` [PATCH V2] " Eric Sandeen
@ 2012-09-21 2:07 ` Namhyung Kim
2012-09-21 2:25 ` Eric Sandeen
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
0 siblings, 2 replies; 9+ messages in thread
From: Namhyung Kim @ 2012-09-21 2:07 UTC (permalink / raw)
To: Eric Sandeen; +Cc: kernel list, Arnaldo Carvalho de Melo
Hi again,
On Thu, 20 Sep 2012 20:12:50 -0500, Eric Sandeen wrote:
> -$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
> +$(OUTPUT)util/parse-events-flex.c: util/parse-events.l util/parse-events-bison.c
I realized that the generated *-bison.c files should have $(OUTPUT)
prefix since they can be under another directory than *.[ly] files.
> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
>
> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
>
> -$(OUTPUT)util/pmu-flex.c: util/pmu.l
> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
Ditto.
Thanks,
Namhyung
> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
>
> $(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] perf: Fix parallel build
2012-09-21 2:07 ` Namhyung Kim
@ 2012-09-21 2:25 ` Eric Sandeen
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
1 sibling, 0 replies; 9+ messages in thread
From: Eric Sandeen @ 2012-09-21 2:25 UTC (permalink / raw)
To: Namhyung Kim; +Cc: kernel list, Arnaldo Carvalho de Melo
On 9/20/12 9:07 PM, Namhyung Kim wrote:
> Hi again,
>
> On Thu, 20 Sep 2012 20:12:50 -0500, Eric Sandeen wrote:
>> -$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
>> +$(OUTPUT)util/parse-events-flex.c: util/parse-events.l util/parse-events-bison.c
>
> I realized that the generated *-bison.c files should have $(OUTPUT)
> prefix since they can be under another directory than *.[ly] files.
>
>
>> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
>>
>> $(OUTPUT)util/parse-events-bison.c: util/parse-events.y
>> $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
>>
>> -$(OUTPUT)util/pmu-flex.c: util/pmu.l
>> +$(OUTPUT)util/pmu-flex.c: util/pmu.l util/pmu-bison.c
>
> Ditto.
Sorry. Too long since I worked on Makefiles :(
V3 soon ;)
-Eric
> Thanks,
> Namhyung
>
>
>> $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
>>
>> $(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH V3] perf: Fix parallel build
2012-09-21 2:07 ` Namhyung Kim
2012-09-21 2:25 ` Eric Sandeen
@ 2012-09-21 2:31 ` Eric Sandeen
2012-09-21 2:27 ` Namhyung Kim
2012-09-27 4:25 ` [tip:perf/core] perf tools: " tip-bot for Eric Sandeen
1 sibling, 2 replies; 9+ messages in thread
From: Eric Sandeen @ 2012-09-21 2:31 UTC (permalink / raw)
To: Namhyung Kim; +Cc: kernel list, Arnaldo Carvalho de Melo
Parallel builds of perf were failing for me on a 32p box, with:
* new build flags or prefix
util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
...
make: *** [util/pmu-flex.o] Error 1
make: *** Waiting for unfinished jobs....
This can pretty quickly be seen by adding a sleep in front of
the bison calls in tools/perf/Makefile and running make -j4 on a
smaller box i.e.:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
Adding the following dependencies fixes it for me.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
V2: Fix other bison dependency caught by Namhyung Kim <namhyung@kernel.org>, thanks.
V3: Add $(OUTPUT) to generated deps, thanks again.
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 35655c3..01325cd 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -221,13 +221,13 @@ export PERL_PATH
FLEX = flex
BISON= bison
-$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
+$(OUTPUT)util/parse-events-flex.c: util/parse-events.l $(OUTPUT)util/parse-events-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
$(OUTPUT)util/parse-events-bison.c: util/parse-events.y
$(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
-$(OUTPUT)util/pmu-flex.c: util/pmu.l
+$(OUTPUT)util/pmu-flex.c: util/pmu.l $(OUTPUT)util/pmu-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
$(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH V3] perf: Fix parallel build
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
@ 2012-09-21 2:27 ` Namhyung Kim
2012-09-27 4:25 ` [tip:perf/core] perf tools: " tip-bot for Eric Sandeen
1 sibling, 0 replies; 9+ messages in thread
From: Namhyung Kim @ 2012-09-21 2:27 UTC (permalink / raw)
To: Eric Sandeen; +Cc: kernel list, Arnaldo Carvalho de Melo, Jiri Olsa
On Thu, 20 Sep 2012 21:31:44 -0500, Eric Sandeen wrote:
> Parallel builds of perf were failing for me on a 32p box, with:
>
> * new build flags or prefix
> util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
>
> ...
>
> make: *** [util/pmu-flex.o] Error 1
> make: *** Waiting for unfinished jobs....
>
> This can pretty quickly be seen by adding a sleep in front of
> the bison calls in tools/perf/Makefile and running make -j4 on a
> smaller box i.e.:
>
> sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
>
> Adding the following dependencies fixes it for me.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks for fixing this!
Namhyung
^ permalink raw reply [flat|nested] 9+ messages in thread
* [tip:perf/core] perf tools: Fix parallel build
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
2012-09-21 2:27 ` Namhyung Kim
@ 2012-09-27 4:25 ` tip-bot for Eric Sandeen
1 sibling, 0 replies; 9+ messages in thread
From: tip-bot for Eric Sandeen @ 2012-09-27 4:25 UTC (permalink / raw)
To: linux-tip-commits; +Cc: acme, linux-kernel, hpa, mingo, tglx, namhyung, sandeen
Commit-ID: e6048fb8602648eabee96476b2703807d5e89409
Gitweb: http://git.kernel.org/tip/e6048fb8602648eabee96476b2703807d5e89409
Author: Eric Sandeen <sandeen@redhat.com>
AuthorDate: Thu, 20 Sep 2012 21:31:44 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 21 Sep 2012 12:13:21 -0300
perf tools: Fix parallel build
Parallel builds of perf were failing for me on a 32p box, with:
* new build flags or prefix
util/pmu.l:7:23: error: pmu-bison.h: No such file or directory
...
make: *** [util/pmu-flex.o] Error 1
make: *** Waiting for unfinished jobs....
This can pretty quickly be seen by adding a sleep in front of the bison
calls in tools/perf/Makefile and running make -j4 on a smaller box i.e.:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c
Adding the following dependencies fixes it for me.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/505BD190.40707@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
index 5077f8e..3ae6a59 100644
--- a/tools/perf/Makefile
+++ b/tools/perf/Makefile
@@ -233,13 +233,13 @@ export PERL_PATH
FLEX = flex
BISON= bison
-$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
+$(OUTPUT)util/parse-events-flex.c: util/parse-events.l $(OUTPUT)util/parse-events-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c
$(OUTPUT)util/parse-events-bison.c: util/parse-events.y
$(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c
-$(OUTPUT)util/pmu-flex.c: util/pmu.l
+$(OUTPUT)util/pmu-flex.c: util/pmu.l $(OUTPUT)util/pmu-bison.c
$(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c
$(OUTPUT)util/pmu-bison.c: util/pmu.y
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-09-27 4:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-20 23:53 [PATCH] perf: Fix parallel build Eric Sandeen
2012-09-21 0:24 ` Namhyung Kim
2012-09-21 1:08 ` Eric Sandeen
2012-09-21 1:12 ` [PATCH V2] " Eric Sandeen
2012-09-21 2:07 ` Namhyung Kim
2012-09-21 2:25 ` Eric Sandeen
2012-09-21 2:31 ` [PATCH V3] " Eric Sandeen
2012-09-21 2:27 ` Namhyung Kim
2012-09-27 4:25 ` [tip:perf/core] perf tools: " tip-bot for Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.