From: Ying Xue <ying.xue@windriver.com>
To: Michael Christie <michaelc@cs.wisc.edu>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] iscsi: Don't disable BH on BH context
Date: Fri, 21 Sep 2012 17:16:21 +0800 [thread overview]
Message-ID: <505C3065.9040802@windriver.com> (raw)
In-Reply-To: <7B2DD735-D51F-4037-A651-2E02684DFFD1@cs.wisc.edu>
Michael Christie wrote:
> On Aug 20, 2012, at 8:28 PM, Ying Xue <ying.xue@windriver.com> wrote:
>
>
>> Since we have already in BH context when iscsi_sw_tcp_write_space()
>> is called, it's unnecessary to disable BH.
>>
>
> Hey,
>
> I do don't think this is right anymore. It looks like it can be called in sock_setsockopt.
>
>
I just finds it seems this is an unnecessary action to disable BH on BH
context when I look through iscsi code.
If you can confirm the iscsi_sw_tcp_write_space() is also called in
process context, please ignore the noise.
Regards,
Ying
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>> Acked-by: Michael Christie <michaelc@cs.wisc.edu>
>> ---
>> drivers/scsi/iscsi_tcp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
>> index 9220861..d763857 100644
>> --- a/drivers/scsi/iscsi_tcp.c
>> +++ b/drivers/scsi/iscsi_tcp.c
>> @@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
>> struct iscsi_sw_tcp_conn *tcp_sw_conn;
>> void (*old_write_space)(struct sock *);
>>
>> - read_lock_bh(&sk->sk_callback_lock);
>> + read_lock(&sk->sk_callback_lock);
>> conn = sk->sk_user_data;
>> if (!conn) {
>> read_unlock_bh(&sk->sk_callback_lock);
>> @@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
>> tcp_conn = conn->dd_data;
>> tcp_sw_conn = tcp_conn->dd_data;
>> old_write_space = tcp_sw_conn->old_write_space;
>> - read_unlock_bh(&sk->sk_callback_lock);
>> + read_unlock(&sk->sk_callback_lock);
>>
>> old_write_space(sk);
>>
>> --
>> 1.7.11
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
next prev parent reply other threads:[~2012-09-21 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-21 1:28 [PATCH] iscsi: Don't disable BH on BH context Ying Xue
2012-09-21 8:44 ` Michael Christie
2012-09-21 9:16 ` Ying Xue [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 7:47 Ying Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505C3065.9040802@windriver.com \
--to=ying.xue@windriver.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.