* [PATCH] iscsi: Don't disable BH on BH context
@ 2012-08-21 1:28 Ying Xue
2012-09-21 8:44 ` Michael Christie
0 siblings, 1 reply; 4+ messages in thread
From: Ying Xue @ 2012-08-21 1:28 UTC (permalink / raw)
To: michaelc; +Cc: linux-scsi
Since we have already in BH context when iscsi_sw_tcp_write_space()
is called, it's unnecessary to disable BH.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Michael Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/iscsi_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 9220861..d763857 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
struct iscsi_sw_tcp_conn *tcp_sw_conn;
void (*old_write_space)(struct sock *);
- read_lock_bh(&sk->sk_callback_lock);
+ read_lock(&sk->sk_callback_lock);
conn = sk->sk_user_data;
if (!conn) {
read_unlock_bh(&sk->sk_callback_lock);
@@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
tcp_conn = conn->dd_data;
tcp_sw_conn = tcp_conn->dd_data;
old_write_space = tcp_sw_conn->old_write_space;
- read_unlock_bh(&sk->sk_callback_lock);
+ read_unlock(&sk->sk_callback_lock);
old_write_space(sk);
--
1.7.11
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iscsi: Don't disable BH on BH context
2012-08-21 1:28 [PATCH] iscsi: Don't disable BH on BH context Ying Xue
@ 2012-09-21 8:44 ` Michael Christie
2012-09-21 9:16 ` Ying Xue
0 siblings, 1 reply; 4+ messages in thread
From: Michael Christie @ 2012-09-21 8:44 UTC (permalink / raw)
To: Ying Xue; +Cc: linux-scsi
On Aug 20, 2012, at 8:28 PM, Ying Xue <ying.xue@windriver.com> wrote:
> Since we have already in BH context when iscsi_sw_tcp_write_space()
> is called, it's unnecessary to disable BH.
Hey,
I do don't think this is right anymore. It looks like it can be called in sock_setsockopt.
>
> Signed-off-by: Ying Xue <ying.xue@windriver.com>
> Acked-by: Michael Christie <michaelc@cs.wisc.edu>
> ---
> drivers/scsi/iscsi_tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index 9220861..d763857 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
> struct iscsi_sw_tcp_conn *tcp_sw_conn;
> void (*old_write_space)(struct sock *);
>
> - read_lock_bh(&sk->sk_callback_lock);
> + read_lock(&sk->sk_callback_lock);
> conn = sk->sk_user_data;
> if (!conn) {
> read_unlock_bh(&sk->sk_callback_lock);
> @@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
> tcp_conn = conn->dd_data;
> tcp_sw_conn = tcp_conn->dd_data;
> old_write_space = tcp_sw_conn->old_write_space;
> - read_unlock_bh(&sk->sk_callback_lock);
> + read_unlock(&sk->sk_callback_lock);
>
> old_write_space(sk);
>
> --
> 1.7.11
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iscsi: Don't disable BH on BH context
2012-09-21 8:44 ` Michael Christie
@ 2012-09-21 9:16 ` Ying Xue
0 siblings, 0 replies; 4+ messages in thread
From: Ying Xue @ 2012-09-21 9:16 UTC (permalink / raw)
To: Michael Christie; +Cc: linux-scsi
Michael Christie wrote:
> On Aug 20, 2012, at 8:28 PM, Ying Xue <ying.xue@windriver.com> wrote:
>
>
>> Since we have already in BH context when iscsi_sw_tcp_write_space()
>> is called, it's unnecessary to disable BH.
>>
>
> Hey,
>
> I do don't think this is right anymore. It looks like it can be called in sock_setsockopt.
>
>
I just finds it seems this is an unnecessary action to disable BH on BH
context when I look through iscsi code.
If you can confirm the iscsi_sw_tcp_write_space() is also called in
process context, please ignore the noise.
Regards,
Ying
>> Signed-off-by: Ying Xue <ying.xue@windriver.com>
>> Acked-by: Michael Christie <michaelc@cs.wisc.edu>
>> ---
>> drivers/scsi/iscsi_tcp.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
>> index 9220861..d763857 100644
>> --- a/drivers/scsi/iscsi_tcp.c
>> +++ b/drivers/scsi/iscsi_tcp.c
>> @@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
>> struct iscsi_sw_tcp_conn *tcp_sw_conn;
>> void (*old_write_space)(struct sock *);
>>
>> - read_lock_bh(&sk->sk_callback_lock);
>> + read_lock(&sk->sk_callback_lock);
>> conn = sk->sk_user_data;
>> if (!conn) {
>> read_unlock_bh(&sk->sk_callback_lock);
>> @@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
>> tcp_conn = conn->dd_data;
>> tcp_sw_conn = tcp_conn->dd_data;
>> old_write_space = tcp_sw_conn->old_write_space;
>> - read_unlock_bh(&sk->sk_callback_lock);
>> + read_unlock(&sk->sk_callback_lock);
>>
>> old_write_space(sk);
>>
>> --
>> 1.7.11
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iscsi: Don't disable BH on BH context
@ 2012-08-20 7:47 Ying Xue
0 siblings, 0 replies; 4+ messages in thread
From: Ying Xue @ 2012-08-20 7:47 UTC (permalink / raw)
To: michaelc; +Cc: linux-kernel
Since we have already in BH context when iscsi_sw_tcp_write_space()
is called, it's unnecessary to disable BH.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
---
drivers/scsi/iscsi_tcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 9220861..d763857 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
struct iscsi_sw_tcp_conn *tcp_sw_conn;
void (*old_write_space)(struct sock *);
- read_lock_bh(&sk->sk_callback_lock);
+ read_lock(&sk->sk_callback_lock);
conn = sk->sk_user_data;
if (!conn) {
read_unlock_bh(&sk->sk_callback_lock);
@@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
tcp_conn = conn->dd_data;
tcp_sw_conn = tcp_conn->dd_data;
old_write_space = tcp_sw_conn->old_write_space;
- read_unlock_bh(&sk->sk_callback_lock);
+ read_unlock(&sk->sk_callback_lock);
old_write_space(sk);
--
1.7.11
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-21 9:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-21 1:28 [PATCH] iscsi: Don't disable BH on BH context Ying Xue
2012-09-21 8:44 ` Michael Christie
2012-09-21 9:16 ` Ying Xue
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 7:47 Ying Xue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.