From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/3] kbuild: introduce cmd_dtc_cpp
Date: Thu, 27 Sep 2012 09:39:28 -0600 [thread overview]
Message-ID: <50647330.9030306@wwwdotorg.org> (raw)
In-Reply-To: <20120927054438.GM17667@game.jcrosoft.org>
On 09/26/2012 11:44 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:06 Tue 25 Sep , Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> cmd_dtc_cpp runs the C pre-processor on the input .dts file before
>> passing it to dtc for final compilation. This allows used of #define
>> within the .dts file.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>> scripts/Makefile.lib | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 0be6f11..e3a149e 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -266,6 +266,9 @@ $(obj)/%.dtb.S: $(obj)/%.dtb
>> quiet_cmd_dtc = DTC $@
>> cmd_dtc = $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -d $(depfile) $<
>>
>> +quiet_cmd_dtc_cpp = DTC+CPP $@
>> +cmd_dtc_cpp = $(CC) -E -Wp,-MD,$(depfile) -xc $< | $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -
>
> this should go to Makefile.build
Hmm. Consistency with the existing cmd_dtc right above would dictate
otherwise.
> and we should keep the same nomecalture as lds with lds.S
>
> here dts.S
I don't agree; see my previous response to the same assertion.
> and is it possible to cmd with it
I don't understand the question.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Jean-Christophe PLAGNIOL-VILLARD
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [RFC PATCH 1/3] kbuild: introduce cmd_dtc_cpp
Date: Thu, 27 Sep 2012 09:39:28 -0600 [thread overview]
Message-ID: <50647330.9030306@wwwdotorg.org> (raw)
In-Reply-To: <20120927054438.GM17667-RQcB7r2h9QmfDR2tN2SG5Ni2O/JbrIOy@public.gmane.org>
On 09/26/2012 11:44 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 13:06 Tue 25 Sep , Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> cmd_dtc_cpp runs the C pre-processor on the input .dts file before
>> passing it to dtc for final compilation. This allows used of #define
>> within the .dts file.
>>
>> Signed-off-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> scripts/Makefile.lib | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 0be6f11..e3a149e 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -266,6 +266,9 @@ $(obj)/%.dtb.S: $(obj)/%.dtb
>> quiet_cmd_dtc = DTC $@
>> cmd_dtc = $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -d $(depfile) $<
>>
>> +quiet_cmd_dtc_cpp = DTC+CPP $@
>> +cmd_dtc_cpp = $(CC) -E -Wp,-MD,$(depfile) -xc $< | $(objtree)/scripts/dtc/dtc -O dtb -o $@ -b 0 $(DTC_FLAGS) -
>
> this should go to Makefile.build
Hmm. Consistency with the existing cmd_dtc right above would dictate
otherwise.
> and we should keep the same nomecalture as lds with lds.S
>
> here dts.S
I don't agree; see my previous response to the same assertion.
> and is it possible to cmd with it
I don't understand the question.
next prev parent reply other threads:[~2012-09-27 15:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 19:06 [RFC PATCH 0/3] ARM: use C pre-processor with dtc Stephen Warren
2012-09-25 19:06 ` Stephen Warren
2012-09-25 19:06 ` [RFC PATCH 1/3] kbuild: introduce cmd_dtc_cpp Stephen Warren
2012-09-25 19:06 ` Stephen Warren
2012-09-27 5:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 5:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 15:39 ` Stephen Warren [this message]
2012-09-27 15:39 ` Stephen Warren
2012-09-27 17:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 17:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-25 19:06 ` [RFC PATCH 2/3] ARM: use cmd_dtc_cpp for compilation of *.dts-cpp to *.dtb Stephen Warren
2012-09-25 19:06 ` Stephen Warren
2012-09-27 5:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 5:47 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 15:40 ` Stephen Warren
2012-09-27 15:40 ` Stephen Warren
2012-09-25 19:06 ` [RFC PATCH 3/3] ARM: tegra: compile all DT files with cpp Stephen Warren
2012-09-25 19:06 ` Stephen Warren
2012-09-25 19:35 ` [RFC PATCH 0/3] ARM: use C pre-processor with dtc Scott Wood
2012-09-25 19:35 ` Scott Wood
2012-09-25 19:51 ` Mark Brown
2012-09-25 19:51 ` Mark Brown
2012-09-25 19:59 ` Scott Wood
2012-09-25 19:59 ` Scott Wood
2012-09-25 20:05 ` Stephen Warren
2012-09-25 20:05 ` Stephen Warren
2012-09-25 20:05 ` Mark Brown
2012-09-25 20:05 ` Mark Brown
2012-09-25 19:51 ` Stephen Warren
2012-09-25 19:51 ` Stephen Warren
2012-09-25 23:46 ` Tony Lindgren
2012-09-25 23:46 ` Tony Lindgren
2012-09-27 5:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 5:40 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 15:38 ` Stephen Warren
2012-09-27 15:38 ` Stephen Warren
2012-09-27 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-27 17:27 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50647330.9030306@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.