All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [GIT PULL] drbd-8.3 updates
Date: Wed, 03 Oct 2012 14:49:02 +0200	[thread overview]
Message-ID: <506C343E.60203@kernel.dk> (raw)
In-Reply-To: <10403443.3yRLLBkj5b@fat-tyre>

On 2012-10-03 12:07, Philipp Reisner wrote:
> Am Mittwoch, 3. Oktober 2012, 11:24:09 schrieben Sie:
>>> Not pulled. Two reasons:
>>>
>>> - It's late (in the merge window)
>>> - and it's not based off my for-3.7/drivers branch, hence I get a ton of
>>>
>>>   unrelated changes with a pull into that branch.
>>
>> Hi Jens,
>>
>> I can rebase it for you in a few hours. Would influence this your decission?
>>
> 
> Hi Jens,
> 
> Is there a convenient way for me to find our when it is the right time
> to send pull requests your way? (i.e. a notification when you create your
> for-3.x/drivers branch)

The right time is anytime between -rc1 and -rcN for the previous
release, where N is the last released -rc for that series. IOW, I should
have it before the next merge window opens, not a days into that window.

> Rebasing it on your drivers tree was trivial, here is the updated pull
> request:
> 
> The following changes since commit fab74e7a8f0f8d0af2356c28aa60d55f9e6f5f8b:
> 
>   loop: Make explicit loop device destruction lazy (2012-09-28 10:42:23 +0200)
> 
> are available in the git repository at:
> 
>   git://git.drbd.org/linux-drbd.git for-jens
> 
> for you to fetch changes up to 61e8114a682b0e868696f8363ed03e5fd4c750d1:
> 
>   drbd: log request sector offset and size for IO errors (2012-10-03 11:54:45 +0200)

Thanks, one question before this is pulled in:

> Philipp Reisner (6):
>       drbd: Add a drbd directory to sysfs
>       drbd: expose the data generation identifiers via sysfs

What are these? It's sitting in /sys/block/<dev>/drbd/, I don't see any
documentation or justification for that.

Why isn't it off in debugfs or similar instead?

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [GIT PULL] drbd-8.3 updates
Date: Wed, 03 Oct 2012 14:49:02 +0200	[thread overview]
Message-ID: <506C343E.60203@kernel.dk> (raw)
In-Reply-To: <10403443.3yRLLBkj5b@fat-tyre>

On 2012-10-03 12:07, Philipp Reisner wrote:
> Am Mittwoch, 3. Oktober 2012, 11:24:09 schrieben Sie:
>>> Not pulled. Two reasons:
>>>
>>> - It's late (in the merge window)
>>> - and it's not based off my for-3.7/drivers branch, hence I get a ton of
>>>
>>>   unrelated changes with a pull into that branch.
>>
>> Hi Jens,
>>
>> I can rebase it for you in a few hours. Would influence this your decission?
>>
> 
> Hi Jens,
> 
> Is there a convenient way for me to find our when it is the right time
> to send pull requests your way? (i.e. a notification when you create your
> for-3.x/drivers branch)

The right time is anytime between -rc1 and -rcN for the previous
release, where N is the last released -rc for that series. IOW, I should
have it before the next merge window opens, not a days into that window.

> Rebasing it on your drivers tree was trivial, here is the updated pull
> request:
> 
> The following changes since commit fab74e7a8f0f8d0af2356c28aa60d55f9e6f5f8b:
> 
>   loop: Make explicit loop device destruction lazy (2012-09-28 10:42:23 +0200)
> 
> are available in the git repository at:
> 
>   git://git.drbd.org/linux-drbd.git for-jens
> 
> for you to fetch changes up to 61e8114a682b0e868696f8363ed03e5fd4c750d1:
> 
>   drbd: log request sector offset and size for IO errors (2012-10-03 11:54:45 +0200)

Thanks, one question before this is pulled in:

> Philipp Reisner (6):
>       drbd: Add a drbd directory to sysfs
>       drbd: expose the data generation identifiers via sysfs

What are these? It's sitting in /sys/block/<dev>/drbd/, I don't see any
documentation or justification for that.

Why isn't it off in debugfs or similar instead?

-- 
Jens Axboe


  reply	other threads:[~2012-10-03 12:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 13:02 [Drbd-dev] [GIT PULL] drbd-8.3 updates Philipp Reisner
2012-10-02 13:02 ` Philipp Reisner
2012-10-03  6:44 ` [Drbd-dev] " Jens Axboe
2012-10-03  6:44   ` Jens Axboe
2012-10-03  9:24   ` [Drbd-dev] " Philipp Reisner
2012-10-03  9:24     ` Philipp Reisner
2012-10-03 10:07     ` [Drbd-dev] " Philipp Reisner
2012-10-03 10:07       ` Philipp Reisner
2012-10-03 12:49       ` Jens Axboe [this message]
2012-10-03 12:49         ` Jens Axboe
2012-10-03 13:49         ` [Drbd-dev] " Philipp Reisner
2012-10-03 13:49           ` Philipp Reisner
2012-10-03 14:04           ` [Drbd-dev] " Jens Axboe
2012-10-03 14:04             ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2012-05-10 12:19 [Drbd-dev] " Philipp Reisner
2012-05-16  6:45 ` Robert Kim App and Facebook Marketing
2012-05-18 14:22 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506C343E.60203@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.