All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [GIT PULL] drbd-8.3 updates
Date: Wed, 03 Oct 2012 16:04:08 +0200	[thread overview]
Message-ID: <506C45D8.7000306@kernel.dk> (raw)
In-Reply-To: <1646250.CkOtqoMF8x@fat-tyre>

On 2012-10-03 15:49, Philipp Reisner wrote:
>> Thanks, one question before this is pulled in:
>>> Philipp Reisner (6):
>>>       drbd: Add a drbd directory to sysfs
>>>       drbd: expose the data generation identifiers via sysfs
>>
>> What are these? It's sitting in /sys/block/<dev>/drbd/, I don't see any
>> documentation or justification for that.
>>
>> Why isn't it off in debugfs or similar instead?
> 
> The long-time goal is to get rid of the /proc/drbd virtual file, and
> present the information that was there in a more structured way in /sys.
> 
> This patch adds a very first step into that direction. Later we intend to
> have here things like the connections state, device roles, statistics
> counters there.
> 
> When coming up with the layout we used the sysfs presence of software raid 
> as example.

Software raid is different, though, in that it's a class/type of device.
So for drbd, I'd still recommend you look outside of the regular
/sys/block hierarchy for adding something like this.

> I have removed it from this pull-request, so that there is more time for
> consideration before the next merge window.

Thanks, pulled.

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [GIT PULL] drbd-8.3 updates
Date: Wed, 03 Oct 2012 16:04:08 +0200	[thread overview]
Message-ID: <506C45D8.7000306@kernel.dk> (raw)
In-Reply-To: <1646250.CkOtqoMF8x@fat-tyre>

On 2012-10-03 15:49, Philipp Reisner wrote:
>> Thanks, one question before this is pulled in:
>>> Philipp Reisner (6):
>>>       drbd: Add a drbd directory to sysfs
>>>       drbd: expose the data generation identifiers via sysfs
>>
>> What are these? It's sitting in /sys/block/<dev>/drbd/, I don't see any
>> documentation or justification for that.
>>
>> Why isn't it off in debugfs or similar instead?
> 
> The long-time goal is to get rid of the /proc/drbd virtual file, and
> present the information that was there in a more structured way in /sys.
> 
> This patch adds a very first step into that direction. Later we intend to
> have here things like the connections state, device roles, statistics
> counters there.
> 
> When coming up with the layout we used the sysfs presence of software raid 
> as example.

Software raid is different, though, in that it's a class/type of device.
So for drbd, I'd still recommend you look outside of the regular
/sys/block hierarchy for adding something like this.

> I have removed it from this pull-request, so that there is more time for
> consideration before the next merge window.

Thanks, pulled.

-- 
Jens Axboe


  reply	other threads:[~2012-10-03 14:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 13:02 [Drbd-dev] [GIT PULL] drbd-8.3 updates Philipp Reisner
2012-10-02 13:02 ` Philipp Reisner
2012-10-03  6:44 ` [Drbd-dev] " Jens Axboe
2012-10-03  6:44   ` Jens Axboe
2012-10-03  9:24   ` [Drbd-dev] " Philipp Reisner
2012-10-03  9:24     ` Philipp Reisner
2012-10-03 10:07     ` [Drbd-dev] " Philipp Reisner
2012-10-03 10:07       ` Philipp Reisner
2012-10-03 12:49       ` [Drbd-dev] " Jens Axboe
2012-10-03 12:49         ` Jens Axboe
2012-10-03 13:49         ` [Drbd-dev] " Philipp Reisner
2012-10-03 13:49           ` Philipp Reisner
2012-10-03 14:04           ` Jens Axboe [this message]
2012-10-03 14:04             ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2012-05-10 12:19 [Drbd-dev] " Philipp Reisner
2012-05-16  6:45 ` Robert Kim App and Facebook Marketing
2012-05-18 14:22 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506C45D8.7000306@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.