Re: [Qemu-devel] Ping [PATCH 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

["Andreas Färber" <afaerber@suse.de>]

Am 05.10.2012 15:20, schrieb Alberto Garcia:
> On Fri, Aug 31, 2012 at 06:09:11PM +0200, Andreas Färber wrote:
> 
>>> Ping
>>
>> We are currently in Hard Freeze, new devices will not get accepted
>> before the release, and our review may focus on bug fixes.
>>
>> http://wiki.qemu.org/Planning/1.2
>>
>> I remember having had a brief look through your patches and
>> they looked pretty good modeling- and style-wise for an initial
>> submission. Don't know the hardware though and haven't tested the
>> patches so far.
> 
> I wrote a small blog post about the work, including a bit more
> information on how to test it:
> 
> http://blogs.igalia.com/berto/2012/10/03/industrypack-qemu-and-linuxcon/

Thanks for the illustrative blog post.

One thing caught my eye: Wouldn't it make more sense to call the device
"ipoctal232"? Octal doesn't indicate of what there are eight. ;)

> Is there anything else I should do in order to have this reviewed, or
> should I contact someone else?

Paul and Peter are the ones with experience reviewing UARTs, I think.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg