From: Paolo Bonzini <pbonzini@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Sasha Levin <levinsasha928@gmail.com>,
avi@redhat.com, Thomas Lendacky <tahm@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/3] virtio-net: inline header support
Date: Sat, 06 Oct 2012 14:54:03 +0200 [thread overview]
Message-ID: <507029EB.2050405@redhat.com> (raw)
In-Reply-To: <87391t1nkq.fsf__40391.6521034718$1349505001$gmane$org@rustcorp.com.au>
Il 05/10/2012 07:43, Rusty Russell ha scritto:
>> > struct virtio_scsi_req_cmd {
>> > // Read-only
>> > u8 lun[8];
>> > u64 id;
>> > u8 task_attr;
>> > u8 prio;
>> > u8 crn;
>> > char cdb[cdb_size];
>> > char dataout[];
>> > // Write-only part
>> > u32 sense_len;
>> > u32 residual;
>> > u16 status_qualifier;
>> > u8 status;
>> > u8 response;
>> > u8 sense[sense_size];
>> > char datain[];
>> > };
>> >
>> > where cdb_size and sense_size come from configuration space. The device
>> > right now expects everything before dataout/datain to be in a single
>> > descriptor, but that's in no way part of the spec. Am I missing
>> > something egregious?
> Since you wrote it, I hope not :)
Yeah, I guess the confusion came from cdb_size and sense_size being in
configuration space.
> That's good. But virtio_blk's scsi command is insoluble AFAICT. As I
> said to Anthony, the best rules are "always" and "never", so I'd really
> rather not have to grandfather that in.
It is, but we can add a rule that if the (transport) flag
VIRTIO_RING_F_ANY_HEADER_SG is set, the cdb field is always 32 bytes in
virtio-blk.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sasha Levin <levinsasha928@gmail.com>,
virtualization@lists.linux-foundation.org,
Thomas Lendacky <tahm@linux.vnet.ibm.com>,
avi@redhat.com
Subject: Re: [PATCH 0/3] virtio-net: inline header support
Date: Sat, 06 Oct 2012 14:54:03 +0200 [thread overview]
Message-ID: <507029EB.2050405@redhat.com> (raw)
In-Reply-To: <87391t1nkq.fsf__40391.6521034718$1349505001$gmane$org@rustcorp.com.au>
Il 05/10/2012 07:43, Rusty Russell ha scritto:
>> > struct virtio_scsi_req_cmd {
>> > // Read-only
>> > u8 lun[8];
>> > u64 id;
>> > u8 task_attr;
>> > u8 prio;
>> > u8 crn;
>> > char cdb[cdb_size];
>> > char dataout[];
>> > // Write-only part
>> > u32 sense_len;
>> > u32 residual;
>> > u16 status_qualifier;
>> > u8 status;
>> > u8 response;
>> > u8 sense[sense_size];
>> > char datain[];
>> > };
>> >
>> > where cdb_size and sense_size come from configuration space. The device
>> > right now expects everything before dataout/datain to be in a single
>> > descriptor, but that's in no way part of the spec. Am I missing
>> > something egregious?
> Since you wrote it, I hope not :)
Yeah, I guess the confusion came from cdb_size and sense_size being in
configuration space.
> That's good. But virtio_blk's scsi command is insoluble AFAICT. As I
> said to Anthony, the best rules are "always" and "never", so I'd really
> rather not have to grandfather that in.
It is, but we can add a rule that if the (transport) flag
VIRTIO_RING_F_ANY_HEADER_SG is set, the cdb field is always 32 bytes in
virtio-blk.
Paolo
next prev parent reply other threads:[~2012-10-06 12:54 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 9:26 [PATCH 0/3] virtio-net: inline header support Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-09-28 9:26 ` [PATCH 1/3] virtio: add API to query ring capacity Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-09-28 9:26 ` [PATCH 2/3] virtio-net: correct capacity math on ring full Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-10-04 0:24 ` Rusty Russell
2012-09-28 9:26 ` [PATCH 3/3] virtio-net: put virtio net header inline with data Michael S. Tsirkin
2012-09-28 9:26 ` Michael S. Tsirkin
2012-10-03 6:44 ` [PATCH 0/3] virtio-net: inline header support Rusty Russell
2012-10-03 10:53 ` Paolo Bonzini
2012-10-03 10:53 ` Paolo Bonzini
2012-10-04 0:11 ` Rusty Russell
2012-10-04 7:09 ` Paolo Bonzini
2012-10-04 12:51 ` Rusty Russell
2012-10-04 13:23 ` Paolo Bonzini
2012-10-05 5:43 ` Rusty Russell
2012-10-06 12:54 ` Paolo Bonzini [this message]
2012-10-06 12:54 ` Paolo Bonzini
2012-10-09 4:59 ` Rusty Russell
2012-10-09 4:59 ` Rusty Russell
2012-10-09 7:27 ` Paolo Bonzini
2012-10-09 7:27 ` Paolo Bonzini
2012-10-11 0:03 ` Rusty Russell
2012-10-11 0:03 ` Rusty Russell
2012-10-11 11:04 ` Michael S. Tsirkin
2012-10-11 11:04 ` Michael S. Tsirkin
2012-10-11 22:37 ` Rusty Russell
2012-10-11 22:37 ` Rusty Russell
2012-10-12 7:38 ` Paolo Bonzini
2012-10-12 7:38 ` Paolo Bonzini
2012-10-12 11:52 ` Cornelia Huck
2012-10-12 11:52 ` Cornelia Huck
2012-10-05 5:43 ` Rusty Russell
2012-10-03 6:44 ` Rusty Russell
2012-10-03 7:10 ` Rusty Russell
2012-10-04 1:24 ` Anthony Liguori
2012-10-04 3:34 ` Rusty Russell
2012-10-04 4:29 ` Anthony Liguori
2012-10-04 7:44 ` Rusty Russell
2012-10-05 7:47 ` Paolo Bonzini
2012-10-05 7:47 ` Paolo Bonzini
2012-10-08 21:31 ` Michael S. Tsirkin
2012-10-08 21:31 ` Michael S. Tsirkin
2012-10-04 1:35 ` Anthony Liguori
2012-10-04 5:17 ` Rusty Russell
2012-10-08 20:41 ` Michael S. Tsirkin
2012-10-08 20:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507029EB.2050405@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tahm@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.