* [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
@ 2012-10-08 9:23 Tapani Pälli
2012-10-08 11:43 ` Oliver McFadden
2012-10-10 17:01 ` Chad Versace
0 siblings, 2 replies; 5+ messages in thread
From: Tapani Pälli @ 2012-10-08 9:23 UTC (permalink / raw)
To: dri-devel
From: Haitao Huang <haitao.huang@intel.com>
Export necessary header files used by other components for Android,
such as libva intel-driver, gralloc, hwcomposer, etc.
Signed-off-by: Haitao Huang <haitao.huang@intel.com>
[chad: Fixed inconsistent indentation.]
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
---
Android.mk | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Android.mk b/Android.mk
index 1029dc6..68db5df 100644
--- a/Android.mk
+++ b/Android.mk
@@ -1,5 +1,5 @@
#
-# Copyright © 2011 Intel Corporation
+# Copyright © 2011-2012 Intel Corporation
#
# Permission is hereby granted, free of charge, to any person obtaining a
# copy of this software and associated documentation files (the "Software"),
@@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
LOCAL_CFLAGS := \
-DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
+LOCAL_COPY_HEADERS := \
+ xf86drm.h \
+ include/drm/drm_fourcc.h \
+ include/drm/drm.h \
+ include/drm/drm_mode.h \
+ include/drm/drm_sarea.h \
+ include/drm/i915_drm.h \
+ intel/intel_bufmgr.h \
+
+LOCAL_COPY_HEADERS_TO := libdrm
include $(BUILD_SHARED_LIBRARY)
include $(LOCAL_PATH)/intel/Android.mk
--
1.7.11.7
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
2012-10-08 9:23 [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2 Tapani Pälli
@ 2012-10-08 11:43 ` Oliver McFadden
2012-10-08 12:45 ` Tapani Pälli
2012-10-10 17:01 ` Chad Versace
1 sibling, 1 reply; 5+ messages in thread
From: Oliver McFadden @ 2012-10-08 11:43 UTC (permalink / raw)
To: Tapani Pälli; +Cc: dri-devel
On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote:
> From: Haitao Huang <haitao.huang@intel.com>
>
> Export necessary header files used by other components for Android,
> such as libva intel-driver, gralloc, hwcomposer, etc.
>
> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
> [chad: Fixed inconsistent indentation.]
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
> ---
Normal syntax is "Subject: [PATCH v2 N/M] ..." You should add a comment
here describing the v1..v2 diff.
> Android.mk | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Android.mk b/Android.mk
> index 1029dc6..68db5df 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,5 +1,5 @@
> #
> -# Copyright © 2011 Intel Corporation
> +# Copyright © 2011-2012 Intel Corporation
> #
> # Permission is hereby granted, free of charge, to any person obtaining a
> # copy of this software and associated documentation files (the "Software"),
> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
> LOCAL_CFLAGS := \
> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>
> +LOCAL_COPY_HEADERS := \
> + xf86drm.h \
> + include/drm/drm_fourcc.h \
> + include/drm/drm.h \
> + include/drm/drm_mode.h \
> + include/drm/drm_sarea.h \
> + include/drm/i915_drm.h \
> + intel/intel_bufmgr.h \
> +
> +LOCAL_COPY_HEADERS_TO := libdrm
> include $(BUILD_SHARED_LIBRARY)
>
> include $(LOCAL_PATH)/intel/Android.mk
> --
> 1.7.11.7
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Oliver McFadden.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
2012-10-08 11:43 ` Oliver McFadden
@ 2012-10-08 12:45 ` Tapani Pälli
0 siblings, 0 replies; 5+ messages in thread
From: Tapani Pälli @ 2012-10-08 12:45 UTC (permalink / raw)
To: Oliver McFadden; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1916 bytes --]
On 10/08/2012 02:43 PM, Oliver McFadden wrote:
> On Mon, Oct 08, 2012 at 12:23:56PM +0300, Tapani Pälli wrote:
>> From: Haitao Huang <haitao.huang@intel.com>
>>
>> Export necessary header files used by other components for Android,
>> such as libva intel-driver, gralloc, hwcomposer, etc.
>>
>> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
>> [chad: Fixed inconsistent indentation.]
>> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>> ---
>
> Normal syntax is "Subject: [PATCH v2 N/M] ..." You should add a comment
> here describing the v1..v2 diff.
ok, I took away the gerrit 'change-id' row, I'll send v3 with your
suggested changes.
>> Android.mk | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 1029dc6..68db5df 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,5 +1,5 @@
>> #
>> -# Copyright © 2011 Intel Corporation
>> +# Copyright © 2011-2012 Intel Corporation
>> #
>> # Permission is hereby granted, free of charge, to any person obtaining a
>> # copy of this software and associated documentation files (the "Software"),
>> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>> LOCAL_CFLAGS := \
>> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>
>> +LOCAL_COPY_HEADERS := \
>> + xf86drm.h \
>> + include/drm/drm_fourcc.h \
>> + include/drm/drm.h \
>> + include/drm/drm_mode.h \
>> + include/drm/drm_sarea.h \
>> + include/drm/i915_drm.h \
>> + intel/intel_bufmgr.h \
>> +
>> +LOCAL_COPY_HEADERS_TO := libdrm
>> include $(BUILD_SHARED_LIBRARY)
>>
>> include $(LOCAL_PATH)/intel/Android.mk
>> --
>> 1.7.11.7
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
// Tapani
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 551 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
2012-10-08 9:23 [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2 Tapani Pälli
2012-10-08 11:43 ` Oliver McFadden
@ 2012-10-10 17:01 ` Chad Versace
2012-10-11 8:55 ` Tapani Pälli
1 sibling, 1 reply; 5+ messages in thread
From: Chad Versace @ 2012-10-10 17:01 UTC (permalink / raw)
To: Tapani Pälli; +Cc: dri-devel
Is the only difference between v2 and v1 of this patch the removal of the
Change-ID tag?
On 10/08/2012 02:23 AM, Tapani Pälli wrote:
> From: Haitao Huang <haitao.huang@intel.com>
>
> Export necessary header files used by other components for Android,
> such as libva intel-driver, gralloc, hwcomposer, etc.
>
> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
> [chad: Fixed inconsistent indentation.]
> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
> ---
> Android.mk | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/Android.mk b/Android.mk
> index 1029dc6..68db5df 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,5 +1,5 @@
> #
> -# Copyright © 2011 Intel Corporation
> +# Copyright © 2011-2012 Intel Corporation
> #
> # Permission is hereby granted, free of charge, to any person obtaining a
> # copy of this software and associated documentation files (the "Software"),
> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
> LOCAL_CFLAGS := \
> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>
> +LOCAL_COPY_HEADERS := \
> + xf86drm.h \
> + include/drm/drm_fourcc.h \
> + include/drm/drm.h \
> + include/drm/drm_mode.h \
> + include/drm/drm_sarea.h \
> + include/drm/i915_drm.h \
> + intel/intel_bufmgr.h \
> +
> +LOCAL_COPY_HEADERS_TO := libdrm
> include $(BUILD_SHARED_LIBRARY)
>
> include $(LOCAL_PATH)/intel/Android.mk
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2
2012-10-10 17:01 ` Chad Versace
@ 2012-10-11 8:55 ` Tapani Pälli
0 siblings, 0 replies; 5+ messages in thread
From: Tapani Pälli @ 2012-10-11 8:55 UTC (permalink / raw)
To: Chad Versace; +Cc: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1728 bytes --]
On 10/10/2012 08:01 PM, Chad Versace wrote:
> Is the only difference between v2 and v1 of this patch the removal of the
> Change-ID tag?
yep that is the diff (sorry for not noting it), there is the v3 as well
where I've removed the [] comment per Oliver's suggestion.
> On 10/08/2012 02:23 AM, Tapani Pälli wrote:
>> From: Haitao Huang <haitao.huang@intel.com>
>>
>> Export necessary header files used by other components for Android,
>> such as libva intel-driver, gralloc, hwcomposer, etc.
>>
>> Signed-off-by: Haitao Huang <haitao.huang@intel.com>
>> [chad: Fixed inconsistent indentation.]
>> Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
>> ---
>> Android.mk | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 1029dc6..68db5df 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,5 +1,5 @@
>> #
>> -# Copyright © 2011 Intel Corporation
>> +# Copyright © 2011-2012 Intel Corporation
>> #
>> # Permission is hereby granted, free of charge, to any person obtaining a
>> # copy of this software and associated documentation files (the "Software"),
>> @@ -45,6 +45,16 @@ LOCAL_C_INCLUDES := \
>> LOCAL_CFLAGS := \
>> -DHAVE_LIBDRM_ATOMIC_PRIMITIVES=1
>>
>> +LOCAL_COPY_HEADERS := \
>> + xf86drm.h \
>> + include/drm/drm_fourcc.h \
>> + include/drm/drm.h \
>> + include/drm/drm_mode.h \
>> + include/drm/drm_sarea.h \
>> + include/drm/i915_drm.h \
>> + intel/intel_bufmgr.h \
>> +
>> +LOCAL_COPY_HEADERS_TO := libdrm
>> include $(BUILD_SHARED_LIBRARY)
>>
>> include $(LOCAL_PATH)/intel/Android.mk
>>
>
--
// Tapani
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 551 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-11 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-08 9:23 [PATCH] Android.mk: use LOCAL_COPY_HEADERS to export headers. v2 Tapani Pälli
2012-10-08 11:43 ` Oliver McFadden
2012-10-08 12:45 ` Tapani Pälli
2012-10-10 17:01 ` Chad Versace
2012-10-11 8:55 ` Tapani Pälli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.