All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <b-cousson@ti.com>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data
Date: Thu, 18 Oct 2012 10:08:30 +0200	[thread overview]
Message-ID: <507FB8FE.6010003@ti.com> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com>

Hi Anil,

On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote:
> On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote:
>> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
>> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
>> adds child node inside i2c2 node with i2c slave address.
>>
>> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
>> also reduces I2C2 clock frequency to 100KHz from 400KHz because the
>> maximum clock frequency of SMBus is 100KHz.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>>  arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 3b1f313..d99aa0f 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -49,7 +49,7 @@
>>  
>>  		i2c2: i2c@4802a000 {
>>  			status = "okay";
>> -			clock-frequency = <400000>;
>> +			clock-frequency = <100000>;
>>  
>>  			lis331dlh: lis331dlh@18 {
>>  				compatible = "st,lis331dlh", "st,lis3lv02d";
>> @@ -79,6 +79,11 @@
>>  				st,max-limit-z = <750>;
>>  			};
>>  
>> +			tsl2550: tsl2550@39 {
>> +				compatible = "taos,tsl2550";
>> +				reg = <0x39>;
>> +			};
>> +
>>  			tmp275: tmp275@48 {
>>  				compatible = "ti,tmp275";
>>  				reg = <0x48>;
> 
> Hi Tony/Benoit,
> 
> If there are no comments in this patch could you please take this in?

Have you updated the binding documentation to list the device?

It should be in:
Documentation/devicetree/bindings/i2c/trivial-devices.txt

Please Cc as well the DT ml.

Regards,
Benoit


WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data
Date: Thu, 18 Oct 2012 10:08:30 +0200	[thread overview]
Message-ID: <507FB8FE.6010003@ti.com> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com>

Hi Anil,

On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote:
> On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote:
>> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
>> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
>> adds child node inside i2c2 node with i2c slave address.
>>
>> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
>> also reduces I2C2 clock frequency to 100KHz from 400KHz because the
>> maximum clock frequency of SMBus is 100KHz.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>>  arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 3b1f313..d99aa0f 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -49,7 +49,7 @@
>>  
>>  		i2c2: i2c at 4802a000 {
>>  			status = "okay";
>> -			clock-frequency = <400000>;
>> +			clock-frequency = <100000>;
>>  
>>  			lis331dlh: lis331dlh at 18 {
>>  				compatible = "st,lis331dlh", "st,lis3lv02d";
>> @@ -79,6 +79,11 @@
>>  				st,max-limit-z = <750>;
>>  			};
>>  
>> +			tsl2550: tsl2550 at 39 {
>> +				compatible = "taos,tsl2550";
>> +				reg = <0x39>;
>> +			};
>> +
>>  			tmp275: tmp275 at 48 {
>>  				compatible = "ti,tmp275";
>>  				reg = <0x48>;
> 
> Hi Tony/Benoit,
> 
> If there are no comments in this patch could you please take this in?

Have you updated the binding documentation to list the device?

It should be in:
Documentation/devicetree/bindings/i2c/trivial-devices.txt

Please Cc as well the DT ml.

Regards,
Benoit

  reply	other threads:[~2012-10-18  8:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21 15:49 [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data AnilKumar Ch
2012-09-21 15:49 ` AnilKumar Ch
2012-10-18  5:46 ` AnilKumar, Chimata
2012-10-18  5:46   ` AnilKumar, Chimata
2012-10-18  8:08   ` Benoit Cousson [this message]
2012-10-18  8:08     ` Benoit Cousson
2012-10-18 11:24     ` AnilKumar, Chimata
2012-10-18 11:24       ` AnilKumar, Chimata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507FB8FE.6010003@ti.com \
    --to=b-cousson@ti.com \
    --cc=anilkumar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.