* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
@ 2012-10-09 15:50 Dominick Grift
2012-10-10 13:35 ` Christopher J. PeBenito
0 siblings, 1 reply; 6+ messages in thread
From: Dominick Grift @ 2012-10-09 15:50 UTC (permalink / raw)
To: refpolicy
Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
index e5aee97..2d1520d 100644
--- a/policy/modules/roles/staff.te
+++ b/policy/modules/roles/staff.te
@@ -93,7 +93,7 @@
')
optional_policy(`
- gnome_role(staff_r, staff_t)
+ gnome_role_gconfd(staff_r, staff_t)
')
optional_policy(`
diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
index 44c198a..1803cfd 100644
--- a/policy/modules/roles/sysadm.te
+++ b/policy/modules/roles/sysadm.te
@@ -459,7 +459,7 @@
')
optional_policy(`
- gnome_role(sysadm_r, sysadm_t)
+ gnome_role_gconfd(sysadm_r, sysadm_t)
')
optional_policy(`
diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
index 9f6d4c3..e354193 100644
--- a/policy/modules/roles/unprivuser.te
+++ b/policy/modules/roles/unprivuser.te
@@ -66,7 +66,7 @@
')
optional_policy(`
- gnome_role(user_r, user_t)
+ gnome_role_gconfd(user_r, user_t)
')
optional_policy(`
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
2012-10-09 15:50 [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd Dominick Grift
@ 2012-10-10 13:35 ` Christopher J. PeBenito
2012-10-10 14:10 ` Dominick Grift
0 siblings, 1 reply; 6+ messages in thread
From: Christopher J. PeBenito @ 2012-10-10 13:35 UTC (permalink / raw)
To: refpolicy
On 10/09/12 11:50, Dominick Grift wrote:
> Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
> diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
> index e5aee97..2d1520d 100644
> --- a/policy/modules/roles/staff.te
> +++ b/policy/modules/roles/staff.te
> @@ -93,7 +93,7 @@
> ')
>
> optional_policy(`
> - gnome_role(staff_r, staff_t)
> + gnome_role_gconfd(staff_r, staff_t)
> ')
>
> optional_policy(`
> diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
> index 44c198a..1803cfd 100644
> --- a/policy/modules/roles/sysadm.te
> +++ b/policy/modules/roles/sysadm.te
> @@ -459,7 +459,7 @@
> ')
>
> optional_policy(`
> - gnome_role(sysadm_r, sysadm_t)
> + gnome_role_gconfd(sysadm_r, sysadm_t)
> ')
>
> optional_policy(`
> diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
> index 9f6d4c3..e354193 100644
> --- a/policy/modules/roles/unprivuser.te
> +++ b/policy/modules/roles/unprivuser.te
> @@ -66,7 +66,7 @@
> ')
> optional_policy(`
> - gnome_role(user_r, user_t)
> + gnome_role_gconfd(user_r, user_t)
> ')
>
> optional_policy(`
Why was gnome_role() deprecated in the first place?
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
2012-10-10 13:35 ` Christopher J. PeBenito
@ 2012-10-10 14:10 ` Dominick Grift
2012-10-10 14:22 ` Dominick Grift
0 siblings, 1 reply; 6+ messages in thread
From: Dominick Grift @ 2012-10-10 14:10 UTC (permalink / raw)
To: refpolicy
On Wed, 2012-10-10 at 09:35 -0400, Christopher J. PeBenito wrote:
> On 10/09/12 11:50, Dominick Grift wrote:
> > Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
> > diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
> > index e5aee97..2d1520d 100644
> > --- a/policy/modules/roles/staff.te
> > +++ b/policy/modules/roles/staff.te
> > @@ -93,7 +93,7 @@
> > ')
> >
> > optional_policy(`
> > - gnome_role(staff_r, staff_t)
> > + gnome_role_gconfd(staff_r, staff_t)
> > ')
> >
> > optional_policy(`
> > diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
> > index 44c198a..1803cfd 100644
> > --- a/policy/modules/roles/sysadm.te
> > +++ b/policy/modules/roles/sysadm.te
> > @@ -459,7 +459,7 @@
> > ')
> >
> > optional_policy(`
> > - gnome_role(sysadm_r, sysadm_t)
> > + gnome_role_gconfd(sysadm_r, sysadm_t)
> > ')
> >
> > optional_policy(`
> > diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
> > index 9f6d4c3..e354193 100644
> > --- a/policy/modules/roles/unprivuser.te
> > +++ b/policy/modules/roles/unprivuser.te
> > @@ -66,7 +66,7 @@
> > ')
>
> > optional_policy(`
> > - gnome_role(user_r, user_t)
> > + gnome_role_gconfd(user_r, user_t)
> > ')
> >
> > optional_policy(`
>
> Why was gnome_role() deprecated in the first place?
>
I just decided that this would possibly give more flexibility later.
Gnome is a big project and one might want to enforce restrictions on
parts of it rather than all of it in some cases.
But the main reason is because it is a bit cleaner. Some gnome apps need
to be prefixed while others do not.
Of course you could just ignore the prefix param for apps that do not
need it but i decided to do it like this.
So its basically a combination of the two considerations above
It guess "for practical reasons"
^ permalink raw reply [flat|nested] 6+ messages in thread
* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
2012-10-10 14:10 ` Dominick Grift
@ 2012-10-10 14:22 ` Dominick Grift
2012-10-19 13:17 ` Christopher J. PeBenito
0 siblings, 1 reply; 6+ messages in thread
From: Dominick Grift @ 2012-10-10 14:22 UTC (permalink / raw)
To: refpolicy
On Wed, 2012-10-10 at 16:10 +0200, Dominick Grift wrote:
>
> On Wed, 2012-10-10 at 09:35 -0400, Christopher J. PeBenito wrote:
> > On 10/09/12 11:50, Dominick Grift wrote:
> > > Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
> > > diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
> > > index e5aee97..2d1520d 100644
> > > --- a/policy/modules/roles/staff.te
> > > +++ b/policy/modules/roles/staff.te
> > > @@ -93,7 +93,7 @@
> > > ')
> > >
> > > optional_policy(`
> > > - gnome_role(staff_r, staff_t)
> > > + gnome_role_gconfd(staff_r, staff_t)
> > > ')
> > >
> > > optional_policy(`
> > > diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
> > > index 44c198a..1803cfd 100644
> > > --- a/policy/modules/roles/sysadm.te
> > > +++ b/policy/modules/roles/sysadm.te
> > > @@ -459,7 +459,7 @@
> > > ')
> > >
> > > optional_policy(`
> > > - gnome_role(sysadm_r, sysadm_t)
> > > + gnome_role_gconfd(sysadm_r, sysadm_t)
> > > ')
> > >
> > > optional_policy(`
> > > diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
> > > index 9f6d4c3..e354193 100644
> > > --- a/policy/modules/roles/unprivuser.te
> > > +++ b/policy/modules/roles/unprivuser.te
> > > @@ -66,7 +66,7 @@
> > > ')
> >
> > > optional_policy(`
> > > - gnome_role(user_r, user_t)
> > > + gnome_role_gconfd(user_r, user_t)
> > > ')
> > >
> > > optional_policy(`
> >
> > Why was gnome_role() deprecated in the first place?
> >
There is now also a gnome_role_gkeyringd() but its not called yet
because its a work in progress ( it depends on freedeskop
config/cache/data dirs)
So for example
Fedora will probably call gnome_role_gkeyringd() but not
gnome_role_gconfd()
If you pile them all in one huge template then that allows for less
flexibility
^ permalink raw reply [flat|nested] 6+ messages in thread
* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
2012-10-10 14:22 ` Dominick Grift
@ 2012-10-19 13:17 ` Christopher J. PeBenito
2012-10-19 13:28 ` Dominick Grift
0 siblings, 1 reply; 6+ messages in thread
From: Christopher J. PeBenito @ 2012-10-19 13:17 UTC (permalink / raw)
To: refpolicy
On 10/10/12 10:22, Dominick Grift wrote:
>
>
> On Wed, 2012-10-10 at 16:10 +0200, Dominick Grift wrote:
>>
>> On Wed, 2012-10-10 at 09:35 -0400, Christopher J. PeBenito wrote:
>>> On 10/09/12 11:50, Dominick Grift wrote:
>>>> Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
>>>> diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
>>>> index e5aee97..2d1520d 100644
>>>> --- a/policy/modules/roles/staff.te
>>>> +++ b/policy/modules/roles/staff.te
>>>> @@ -93,7 +93,7 @@
>>>> ')
>>>>
>>>> optional_policy(`
>>>> - gnome_role(staff_r, staff_t)
>>>> + gnome_role_gconfd(staff_r, staff_t)
>>>> ')
>>>>
>>>> optional_policy(`
>>>> diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
>>>> index 44c198a..1803cfd 100644
>>>> --- a/policy/modules/roles/sysadm.te
>>>> +++ b/policy/modules/roles/sysadm.te
>>>> @@ -459,7 +459,7 @@
>>>> ')
>>>>
>>>> optional_policy(`
>>>> - gnome_role(sysadm_r, sysadm_t)
>>>> + gnome_role_gconfd(sysadm_r, sysadm_t)
>>>> ')
>>>>
>>>> optional_policy(`
>>>> diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
>>>> index 9f6d4c3..e354193 100644
>>>> --- a/policy/modules/roles/unprivuser.te
>>>> +++ b/policy/modules/roles/unprivuser.te
>>>> @@ -66,7 +66,7 @@
>>>> ')
>>>
>>>> optional_policy(`
>>>> - gnome_role(user_r, user_t)
>>>> + gnome_role_gconfd(user_r, user_t)
>>>> ')
>>>>
>>>> optional_policy(`
>>>
>>> Why was gnome_role() deprecated in the first place?
>>>
>
> There is now also a gnome_role_gkeyringd() but its not called yet
> because its a work in progress ( it depends on freedeskop
> config/cache/data dirs)
>
> So for example
>
> Fedora will probably call gnome_role_gkeyringd() but not
> gnome_role_gconfd()
>
> If you pile them all in one huge template then that allows for less
> flexibility
No. I think it abstracts the gnome complexities away from other modules, and puts it where it rightly belongs, in the gnome module.
--
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd
2012-10-19 13:17 ` Christopher J. PeBenito
@ 2012-10-19 13:28 ` Dominick Grift
0 siblings, 0 replies; 6+ messages in thread
From: Dominick Grift @ 2012-10-19 13:28 UTC (permalink / raw)
To: refpolicy
On Fri, 2012-10-19 at 09:17 -0400, Christopher J. PeBenito wrote:
> On 10/10/12 10:22, Dominick Grift wrote:
> >
> >
> > On Wed, 2012-10-10 at 16:10 +0200, Dominick Grift wrote:
> >>
> >> On Wed, 2012-10-10 at 09:35 -0400, Christopher J. PeBenito wrote:
> >>> On 10/09/12 11:50, Dominick Grift wrote:
> >>>> Signed-off-by: Dominick Grift <dominick.grift@gmail.com>
> >>>> diff --git a/policy/modules/roles/staff.te b/policy/modules/roles/staff.te
> >>>> index e5aee97..2d1520d 100644
> >>>> --- a/policy/modules/roles/staff.te
> >>>> +++ b/policy/modules/roles/staff.te
> >>>> @@ -93,7 +93,7 @@
> >>>> ')
> >>>>
> >>>> optional_policy(`
> >>>> - gnome_role(staff_r, staff_t)
> >>>> + gnome_role_gconfd(staff_r, staff_t)
> >>>> ')
> >>>>
> >>>> optional_policy(`
> >>>> diff --git a/policy/modules/roles/sysadm.te b/policy/modules/roles/sysadm.te
> >>>> index 44c198a..1803cfd 100644
> >>>> --- a/policy/modules/roles/sysadm.te
> >>>> +++ b/policy/modules/roles/sysadm.te
> >>>> @@ -459,7 +459,7 @@
> >>>> ')
> >>>>
> >>>> optional_policy(`
> >>>> - gnome_role(sysadm_r, sysadm_t)
> >>>> + gnome_role_gconfd(sysadm_r, sysadm_t)
> >>>> ')
> >>>>
> >>>> optional_policy(`
> >>>> diff --git a/policy/modules/roles/unprivuser.te b/policy/modules/roles/unprivuser.te
> >>>> index 9f6d4c3..e354193 100644
> >>>> --- a/policy/modules/roles/unprivuser.te
> >>>> +++ b/policy/modules/roles/unprivuser.te
> >>>> @@ -66,7 +66,7 @@
> >>>> ')
> >>>
> >>>> optional_policy(`
> >>>> - gnome_role(user_r, user_t)
> >>>> + gnome_role_gconfd(user_r, user_t)
> >>>> ')
> >>>>
> >>>> optional_policy(`
> >>>
> >>> Why was gnome_role() deprecated in the first place?
> >>>
> >
> > There is now also a gnome_role_gkeyringd() but its not called yet
> > because its a work in progress ( it depends on freedeskop
> > config/cache/data dirs)
> >
> > So for example
> >
> > Fedora will probably call gnome_role_gkeyringd() but not
> > gnome_role_gconfd()
> >
> > If you pile them all in one huge template then that allows for less
> > flexibility
>
> No. I think it abstracts the gnome complexities away from other modules, and puts it where it rightly belongs, in the gnome module.
>
What do you mean? it is in the gnome module
its just a different template...
We can use the gnome_role later to compile the seperate templates in the
one for people that want to calls them all
But we need to support people that are only interested in calling a
single template
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-19 13:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-09 15:50 [refpolicy] [PATCH] Change deprecated gnome_role to new gnome_role_gconfd Dominick Grift
2012-10-10 13:35 ` Christopher J. PeBenito
2012-10-10 14:10 ` Dominick Grift
2012-10-10 14:22 ` Dominick Grift
2012-10-19 13:17 ` Christopher J. PeBenito
2012-10-19 13:28 ` Dominick Grift
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.