* [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
@ 2012-10-24 14:42 ` Peter Senna Tschudin
0 siblings, 0 replies; 5+ messages in thread
From: Peter Senna Tschudin @ 2012-10-24 14:42 UTC (permalink / raw)
To: airlied
Cc: airlied, alexander.deucher, maraeo, jglisse, dri-devel,
linux-kernel, kernel-janitors, Peter Senna Tschudin
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
The full version of the semantic patch can be found at:
http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
index 573ed1b..5daf0c5 100644
--- a/drivers/gpu/drm/radeon/evergreen_cs.c
+++ b/drivers/gpu/drm/radeon/evergreen_cs.c
@@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
/* macro tile width & height */
palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
- mtileb = (palign / 8) * (halign / 8) * tileb;;
+ mtileb = (palign / 8) * (halign / 8) * tileb;
mtile_pr = surf->nbx / palign;
mtile_ps = (mtile_pr * surf->nby) / halign;
surf->layer_size = mtile_ps * mtileb * slice_pt;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
@ 2012-10-24 14:42 ` Peter Senna Tschudin
0 siblings, 0 replies; 5+ messages in thread
From: Peter Senna Tschudin @ 2012-10-24 14:42 UTC (permalink / raw)
To: airlied
Cc: airlied, alexander.deucher, maraeo, jglisse, dri-devel,
linux-kernel, kernel-janitors, Peter Senna Tschudin
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
The full version of the semantic patch can be found at:
http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
index 573ed1b..5daf0c5 100644
--- a/drivers/gpu/drm/radeon/evergreen_cs.c
+++ b/drivers/gpu/drm/radeon/evergreen_cs.c
@@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
/* macro tile width & height */
palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
- mtileb = (palign / 8) * (halign / 8) * tileb;;
+ mtileb = (palign / 8) * (halign / 8) * tileb;
mtile_pr = surf->nbx / palign;
mtile_ps = (mtile_pr * surf->nby) / halign;
surf->layer_size = mtile_ps * mtileb * slice_pt;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
2012-10-24 14:42 ` Peter Senna Tschudin
(?)
@ 2012-10-24 16:17 ` walter harms
-1 siblings, 0 replies; 5+ messages in thread
From: walter harms @ 2012-10-24 16:17 UTC (permalink / raw)
To: kernel-janitors
Am 24.10.2012 16:42, schrieb Peter Senna Tschudin:
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> statement S;
> position p,p1;
> @@
> S@p1;@p
>
> @script:python r2@
> p << r1.p;
> p1 << r1.p1;
> @@
> if p[0].line != p1[0].line_end:
> cocci.include_match(False)
> @@
> position r1.p;
> @@
> -;@p
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
>
> ---
>
> The full version of the semantic patch can be found at:
> http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
>
> drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 573ed1b..5daf0c5 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
> /* macro tile width & height */
> palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
> halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
> - mtileb = (palign / 8) * (halign / 8) * tileb;;
> + mtileb = (palign / 8) * (halign / 8) * tileb;
mmh, that can be reduced to:
mtileb = surf->bankw * track->npipes * surf->bankh * surf->nbanks * tileb;
is this an improvement ? It look less complicated that the original one.
re,
wh
> mtile_pr = surf->nbx / palign;
> mtile_ps = (mtile_pr * surf->nby) / halign;
> surf->layer_size = mtile_ps * mtileb * slice_pt;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
2012-10-24 14:42 ` Peter Senna Tschudin
@ 2012-10-25 13:53 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2012-10-25 13:53 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: airlied, kernel-janitors, linux-kernel, dri-devel, jglisse,
alexander.deucher, airlied
On Wed, Oct 24, 2012 at 10:42 AM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> statement S;
> position p,p1;
> @@
> S@p1;@p
>
> @script:python r2@
> p << r1.p;
> p1 << r1.p1;
> @@
> if p[0].line != p1[0].line_end:
> cocci.include_match(False)
> @@
> position r1.p;
> @@
> -;@p
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Thanks! I've added this to my patch queue.
Alex
>
> ---
>
> The full version of the semantic patch can be found at:
> http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
>
> drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 573ed1b..5daf0c5 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
> /* macro tile width & height */
> palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
> halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
> - mtileb = (palign / 8) * (halign / 8) * tileb;;
> + mtileb = (palign / 8) * (halign / 8) * tileb;
> mtile_pr = surf->nbx / palign;
> mtile_ps = (mtile_pr * surf->nby) / halign;
> surf->layer_size = mtile_ps * mtileb * slice_pt;
> --
> 1.7.11.7
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon
@ 2012-10-25 13:53 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2012-10-25 13:53 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: airlied, kernel-janitors, linux-kernel, dri-devel, jglisse,
alexander.deucher, airlied
On Wed, Oct 24, 2012 at 10:42 AM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r1@
> statement S;
> position p,p1;
> @@
> S@p1;@p
>
> @script:python r2@
> p << r1.p;
> p1 << r1.p1;
> @@
> if p[0].line != p1[0].line_end:
> cocci.include_match(False)
> @@
> position r1.p;
> @@
> -;@p
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Thanks! I've added this to my patch queue.
Alex
>
> ---
>
> The full version of the semantic patch can be found at:
> http://www.mail-archive.com/cocci@systeme.lip6.fr/msg00014.html
>
> drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index 573ed1b..5daf0c5 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -264,7 +264,7 @@ static int evergreen_surface_check_2d(struct radeon_cs_parser *p,
> /* macro tile width & height */
> palign = (8 * surf->bankw * track->npipes) * surf->mtilea;
> halign = (8 * surf->bankh * surf->nbanks) / surf->mtilea;
> - mtileb = (palign / 8) * (halign / 8) * tileb;;
> + mtileb = (palign / 8) * (halign / 8) * tileb;
> mtile_pr = surf->nbx / palign;
> mtile_ps = (mtile_pr * surf->nby) / halign;
> surf->layer_size = mtile_ps * mtileb * slice_pt;
> --
> 1.7.11.7
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-25 13:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 14:42 [PATCH] drivers/gpu/drm/radeon/evergreen_cs.c: Remove unnecessary semicolon Peter Senna Tschudin
2012-10-24 14:42 ` Peter Senna Tschudin
2012-10-24 16:17 ` walter harms
2012-10-25 13:53 ` Alex Deucher
2012-10-25 13:53 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.