All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>,
	Christoffer Dall <c.dall@virtualopensystems.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Alexander Graf <agraf@suse.de>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	kvm-ppc <kvm-ppc@vger.kernel.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [kvmarm] [RFC PATCH 0/3] KVM: ARM: Get rid of hardcoded VGIC addresses
Date: Thu, 25 Oct 2012 16:32:29 +0000	[thread overview]
Message-ID: <5089699D.3050004@siemens.com> (raw)
In-Reply-To: <5089656A.9010704@redhat.com>

On 2012-10-25 18:14, Paolo Bonzini wrote:
> Il 24/10/2012 02:50, Paul Mackerras ha scritto:
>> So we could indeed use the existing KVM_CREATE_IRQCHIP to tell KVM to
>> create a presentation controller per vcpu.  But then how do we tell
>> KVM how many source controllers we want and how many interrupts each
>> source controller should handle?  The source controllers are not tied
>> to any particular vcpu, and a source controller could potentially have
>> 100s of interrupts or more (particularly with MSIs).  Configuration of
>> each source fits into 64 bits, so if we tried to use KVM_SET_IRQCHIP
>> for configuring a source controller we'd be limited to 64 interrupts
>> per source controller.
> 
> As Jan said, there's more than a few similarities between the x86 and
> PPC model.
> 
> Taking inspiration from the x86 API, configuring the source controller
> seems to be more of a task for KVM_SET_GSI_ROUTING (a very x86-centric
> name, I must admit).

For wiring things together, I agree. But the IOAPIC has a fixed number
of input lines per chip, Power needs to configure them. I don't think
deriving this from addressed lines is the best solution. Some lines may
be configured (too) late, when the chip should have defined its
configuration already.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>,
	Christoffer Dall <c.dall@virtualopensystems.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Alexander Graf <agraf@suse.de>,
	"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	kvm-ppc <kvm-ppc@vger.kernel.org>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [kvmarm] [RFC PATCH 0/3] KVM: ARM: Get rid of hardcoded VGIC addresses
Date: Thu, 25 Oct 2012 18:32:29 +0200	[thread overview]
Message-ID: <5089699D.3050004@siemens.com> (raw)
In-Reply-To: <5089656A.9010704@redhat.com>

On 2012-10-25 18:14, Paolo Bonzini wrote:
> Il 24/10/2012 02:50, Paul Mackerras ha scritto:
>> So we could indeed use the existing KVM_CREATE_IRQCHIP to tell KVM to
>> create a presentation controller per vcpu.  But then how do we tell
>> KVM how many source controllers we want and how many interrupts each
>> source controller should handle?  The source controllers are not tied
>> to any particular vcpu, and a source controller could potentially have
>> 100s of interrupts or more (particularly with MSIs).  Configuration of
>> each source fits into 64 bits, so if we tried to use KVM_SET_IRQCHIP
>> for configuring a source controller we'd be limited to 64 interrupts
>> per source controller.
> 
> As Jan said, there's more than a few similarities between the x86 and
> PPC model.
> 
> Taking inspiration from the x86 API, configuring the source controller
> seems to be more of a task for KVM_SET_GSI_ROUTING (a very x86-centric
> name, I must admit).

For wiring things together, I agree. But the IOAPIC has a fixed number
of input lines per chip, Power needs to configure them. I don't think
deriving this from addressed lines is the best solution. Some lines may
be configured (too) late, when the chip should have defined its
configuration already.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-10-25 16:32 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-14  0:04 [RFC PATCH 0/3] KVM: ARM: Get rid of hardcoded VGIC addresses Christoffer Dall
2012-10-14  0:04 ` [RFC PATCH 1/3] KVM: ARM: Introduce KVM_INIT_IRQCHIP ioctl Christoffer Dall
2012-10-17 20:21   ` Peter Maydell
2012-10-17 20:23     ` Christoffer Dall
2012-10-17 20:31       ` Peter Maydell
2012-10-17 20:39         ` Christoffer Dall
2012-10-18 12:20   ` Avi Kivity
2012-10-19 18:42     ` Christoffer Dall
2012-10-14  0:04 ` [RFC PATCH 2/3] KVM: ARM: Introduce KVM_SET_DEVICE_ADDRESS ioctl Christoffer Dall
2012-10-17 20:29   ` Peter Maydell
2012-10-19 18:46     ` Christoffer Dall
2012-10-19 20:24       ` Peter Maydell
2012-10-19 20:27         ` Christoffer Dall
2012-10-19 20:33           ` Christoffer Dall
2012-10-14  0:04 ` [RFC PATCH 3/3] KVM: ARM: Split KVM_CREATE_IRQCHIP and KVM_INIT_IRQCHIP Christoffer Dall
2012-10-18 11:15   ` Peter Maydell
2012-10-17 20:38 ` [kvmarm] [RFC PATCH 0/3] KVM: ARM: Get rid of hardcoded VGIC addresses Alexander Graf
2012-10-17 20:38   ` Alexander Graf
2012-10-17 20:39   ` Christoffer Dall
2012-10-17 20:39     ` Christoffer Dall
2012-10-17 21:19     ` Benjamin Herrenschmidt
2012-10-17 21:19       ` Benjamin Herrenschmidt
2012-10-17 22:10     ` Paul Mackerras
2012-10-17 22:10       ` Paul Mackerras
2012-10-17 23:58       ` Benjamin Herrenschmidt
2012-10-17 23:58         ` Benjamin Herrenschmidt
2012-10-18 13:48         ` Christoffer Dall
2012-10-18 13:48           ` Christoffer Dall
2012-10-18 13:49           ` Alexander Graf
2012-10-18 13:49             ` Alexander Graf
2012-10-18 15:25             ` Avi Kivity
2012-10-18 15:25               ` Avi Kivity
2012-10-23 10:48           ` Jan Kiszka
2012-10-23 10:48             ` Jan Kiszka
2012-10-23 10:52             ` Peter Maydell
2012-10-23 10:52               ` Peter Maydell
2012-10-23 11:00               ` Jan Kiszka
2012-10-23 11:00                 ` Jan Kiszka
2012-10-23 11:04                 ` Peter Maydell
2012-10-23 11:04                   ` Peter Maydell
2012-10-23 11:08                   ` Jan Kiszka
2012-10-23 11:08                     ` Jan Kiszka
2012-10-24  0:50             ` Paul Mackerras
2012-10-24  0:50               ` Paul Mackerras
2012-10-25 11:57               ` Jan Kiszka
2012-10-25 11:57                 ` Jan Kiszka
2012-10-25 16:14               ` Paolo Bonzini
2012-10-25 16:14                 ` Paolo Bonzini
2012-10-25 16:32                 ` Jan Kiszka [this message]
2012-10-25 16:32                   ` Jan Kiszka
2012-10-25 18:27                   ` Paolo Bonzini
2012-10-25 18:27                     ` Paolo Bonzini
2012-10-25 19:40                     ` Benjamin Herrenschmidt
2012-10-25 19:40                       ` Benjamin Herrenschmidt
2012-10-26  9:58                       ` Paolo Bonzini
2012-10-26  9:58                         ` Paolo Bonzini
2012-10-26 10:09                         ` Peter Maydell
2012-10-26 10:09                           ` Peter Maydell
2012-10-26 10:15                           ` Paolo Bonzini
2012-10-26 10:15                             ` Paolo Bonzini
2012-10-26 10:22                             ` Jan Kiszka
2012-10-26 10:22                               ` Jan Kiszka
2012-10-26 10:44                             ` Benjamin Herrenschmidt
2012-10-26 10:44                               ` Benjamin Herrenschmidt
2012-10-26 11:00                               ` Jan Kiszka
2012-10-26 11:00                                 ` Jan Kiszka
2012-10-26 11:09                                 ` Benjamin Herrenschmidt
2012-10-26 11:09                                   ` Benjamin Herrenschmidt
2012-10-26 11:57                                   ` Paolo Bonzini
2012-10-26 11:57                                     ` Paolo Bonzini
2012-10-26 12:08                                     ` Peter Maydell
2012-10-26 12:08                                       ` Peter Maydell
2012-10-26 12:41                                       ` Jan Kiszka
2012-10-26 12:41                                         ` Jan Kiszka
2012-10-26 20:21                                     ` Benjamin Herrenschmidt
2012-10-26 20:21                                       ` Benjamin Herrenschmidt
2012-10-26 11:17                               ` Peter Maydell
2012-10-26 11:17                                 ` Peter Maydell
2012-10-26 11:39                                 ` Benjamin Herrenschmidt
2012-10-26 11:39                                   ` Benjamin Herrenschmidt
2012-10-26 12:39                                   ` Jan Kiszka
2012-10-26 12:39                                     ` Jan Kiszka
2012-10-26 20:45                                     ` Benjamin Herrenschmidt
2012-10-26 20:45                                       ` Benjamin Herrenschmidt
2012-10-26 22:03                                       ` Benjamin Herrenschmidt
2012-10-26 22:03                                         ` Benjamin Herrenschmidt
2012-10-27  8:06                                         ` Jan Kiszka
2012-10-27  8:06                                           ` Jan Kiszka
2012-10-27 10:01                                         ` Peter Maydell
2012-10-27 10:01                                           ` Peter Maydell
2012-10-28 22:19                                           ` Benjamin Herrenschmidt
2012-10-28 22:19                                             ` Benjamin Herrenschmidt
2012-10-26 10:37                         ` Benjamin Herrenschmidt
2012-10-26 10:37                           ` Benjamin Herrenschmidt
2012-10-26 10:40                           ` Paolo Bonzini
2012-10-26 10:40                             ` Paolo Bonzini
2012-10-26 10:47                             ` Benjamin Herrenschmidt
2012-10-26 10:47                               ` Benjamin Herrenschmidt
2012-10-26 11:47                               ` Paolo Bonzini
2012-10-26 11:47                                 ` Paolo Bonzini
2012-10-25 19:39                 ` Benjamin Herrenschmidt
2012-10-25 19:39                   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5089699D.3050004@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=c.dall@virtualopensystems.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=paulus@samba.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.