From: Michal Marek <mmarek@suse.cz>
To: "Yaakov (Cygwin/X)" <yselkowitz@users.sourceforge.net>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable
Date: Tue, 30 Oct 2012 14:24:31 +0100 [thread overview]
Message-ID: <508FD50F.1060105@suse.cz> (raw)
In-Reply-To: <1350352380-5324-1-git-send-email-yselkowitz@users.sourceforge.net>
On 16.10.2012 03:53, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
> scripts/pnmtologo to all autogenerated .c files. An explicit rule
> is required on platforms where the .exe suffix is used for hostprogs.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> ---
> Michal,
>
> This was originally sent to linux-fbdev, but was forwarded to linux-kbuild
> (but not you) on 12 June. It has yet to be applied to Linus' tree yet, though.
>
> Also applies to all 3.x stable branches
>
> drivers/video/logo/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 3b43781..3854dbb 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
> extra-y += $(call logo-cfiles,_gray256,pgm)
>
> pnmtologo := scripts/pnmtologo
> +$(pnmtologo): $(objtree)/scripts/pnmtologo
Please add an explanation to the changelog how it works.
scripts/pnmtologo is dependent on $(objtree)/scripts/pnmtologo (same
file??), how does it fix the problem that the file is called
scripts/pnmtologo.exe on Cygwin? I do not see any rule for hostprog.exe
-> hostprog in our makefiles.
Michal
next prev parent reply other threads:[~2012-10-30 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 1:53 [PATCH] fbdev: make scripts/pnmtologo dependency portable Yaakov (Cygwin/X)
2012-10-30 13:24 ` Michal Marek [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 23:02 Yaakov (Cygwin/X)
2012-06-12 7:32 ` Geert Uytterhoeven
2012-06-12 7:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FD50F.1060105@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=yselkowitz@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.