* [PATCH] fbdev: make scripts/pnmtologo dependency portable
@ 2012-06-11 23:02 Yaakov (Cygwin/X)
2012-06-12 7:32 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Yaakov (Cygwin/X) @ 2012-06-11 23:02 UTC (permalink / raw)
To: linux-fbdev
From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
scripts/pnmtologo to all autogenerated .c files. An explicit rule
is required on platforms where the .exe suffix is used for hostprogs.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
---
Also applies to all 3.x stable branches
drivers/video/logo/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 3b43781..3854dbb 100644
--- a/drivers/video/logo/Makefile
+++ b/drivers/video/logo/Makefile
@@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
extra-y += $(call logo-cfiles,_gray256,pgm)
pnmtologo := scripts/pnmtologo
+$(pnmtologo): $(objtree)/scripts/pnmtologo
# Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
quiet_cmd_logo = LOGO $@
--
1.7.9
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable
2012-06-11 23:02 Yaakov (Cygwin/X)
@ 2012-06-12 7:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2012-06-12 7:32 UTC (permalink / raw)
To: Yaakov (Cygwin/X); +Cc: linux-fbdev, linux-kbuild
Cc linux-kbuild added
On Tue, Jun 12, 2012 at 1:02 AM, Yaakov (Cygwin/X)
<yselkowitz@users.sourceforge.net> wrote:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
> scripts/pnmtologo to all autogenerated .c files. An explicit rule
> is required on platforms where the .exe suffix is used for hostprogs.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> ---
> Also applies to all 3.x stable branches
>
> drivers/video/logo/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 3b43781..3854dbb 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
> extra-y += $(call logo-cfiles,_gray256,pgm)
>
> pnmtologo := scripts/pnmtologo
> +$(pnmtologo): $(objtree)/scripts/pnmtologo
>
> # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
> quiet_cmd_logo = LOGO $@
> --
> 1.7.9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable
@ 2012-06-12 7:32 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2012-06-12 7:32 UTC (permalink / raw)
To: Yaakov (Cygwin/X); +Cc: linux-fbdev, linux-kbuild
Cc linux-kbuild added
On Tue, Jun 12, 2012 at 1:02 AM, Yaakov (Cygwin/X)
<yselkowitz@users.sourceforge.net> wrote:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
> scripts/pnmtologo to all autogenerated .c files. An explicit rule
> is required on platforms where the .exe suffix is used for hostprogs.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> ---
> Also applies to all 3.x stable branches
>
> drivers/video/logo/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 3b43781..3854dbb 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
> extra-y += $(call logo-cfiles,_gray256,pgm)
>
> pnmtologo := scripts/pnmtologo
> +$(pnmtologo): $(objtree)/scripts/pnmtologo
>
> # Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
> quiet_cmd_logo = LOGO $@
> --
> 1.7.9
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] fbdev: make scripts/pnmtologo dependency portable
@ 2012-10-16 1:53 Yaakov (Cygwin/X)
2012-10-30 13:24 ` Michal Marek
0 siblings, 1 reply; 5+ messages in thread
From: Yaakov (Cygwin/X) @ 2012-10-16 1:53 UTC (permalink / raw)
To: mmarek; +Cc: linux-kbuild
From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
scripts/pnmtologo to all autogenerated .c files. An explicit rule
is required on platforms where the .exe suffix is used for hostprogs.
Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
---
Michal,
This was originally sent to linux-fbdev, but was forwarded to linux-kbuild
(but not you) on 12 June. It has yet to be applied to Linus' tree yet, though.
Also applies to all 3.x stable branches
drivers/video/logo/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
index 3b43781..3854dbb 100644
--- a/drivers/video/logo/Makefile
+++ b/drivers/video/logo/Makefile
@@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
extra-y += $(call logo-cfiles,_gray256,pgm)
pnmtologo := scripts/pnmtologo
+$(pnmtologo): $(objtree)/scripts/pnmtologo
# Create commands like "pnmtologo -t mono -n logo_mac_mono -o ..."
quiet_cmd_logo = LOGO $@
--
1.7.9
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable
2012-10-16 1:53 [PATCH] fbdev: make scripts/pnmtologo dependency portable Yaakov (Cygwin/X)
@ 2012-10-30 13:24 ` Michal Marek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Marek @ 2012-10-30 13:24 UTC (permalink / raw)
To: Yaakov (Cygwin/X); +Cc: linux-kbuild
On 16.10.2012 03:53, Yaakov (Cygwin/X) wrote:
> From: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
> Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on
> scripts/pnmtologo to all autogenerated .c files. An explicit rule
> is required on platforms where the .exe suffix is used for hostprogs.
>
> Signed-off-by: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> ---
> Michal,
>
> This was originally sent to linux-fbdev, but was forwarded to linux-kbuild
> (but not you) on 12 June. It has yet to be applied to Linus' tree yet, though.
>
> Also applies to all 3.x stable branches
>
> drivers/video/logo/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile
> index 3b43781..3854dbb 100644
> --- a/drivers/video/logo/Makefile
> +++ b/drivers/video/logo/Makefile
> @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm)
> extra-y += $(call logo-cfiles,_gray256,pgm)
>
> pnmtologo := scripts/pnmtologo
> +$(pnmtologo): $(objtree)/scripts/pnmtologo
Please add an explanation to the changelog how it works.
scripts/pnmtologo is dependent on $(objtree)/scripts/pnmtologo (same
file??), how does it fix the problem that the file is called
scripts/pnmtologo.exe on Cygwin? I do not see any rule for hostprog.exe
-> hostprog in our makefiles.
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-30 13:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-16 1:53 [PATCH] fbdev: make scripts/pnmtologo dependency portable Yaakov (Cygwin/X)
2012-10-30 13:24 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 23:02 Yaakov (Cygwin/X)
2012-06-12 7:32 ` Geert Uytterhoeven
2012-06-12 7:32 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.