All of lore.kernel.org
 help / color / mirror / Atom feed
From: m-karicheri2@ti.com (Murali Karicheri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver
Date: Thu, 1 Nov 2012 14:34:51 -0400	[thread overview]
Message-ID: <5092C0CB.5020504@ti.com> (raw)
In-Reply-To: <50926E03.8050102@ti.com>

On 11/01/2012 08:41 AM, Sekhar Nori wrote:
> On 10/25/2012 9:41 PM, Murali Karicheri wrote:
>> This is the common clk driver initialization functions for DaVinci
>> SoCs and other SoCs that uses similar hardware architecture.
>> clock.h also defines struct types for clock definitions in a SoC
>> and clock data type for configuring clk-mux. The initialization
>> functions are used by clock initialization code in a specific
>> platform/SoC.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> +struct clk *davinci_plldiv_clk(const char *name, const char *parent,
>> +				struct clk_plldiv_data *data)
>> +{
>> +	/*
>> +	 * This is a PLL divider clock with divider specified by
>> +	 * div_reg in pll_div_data.
>> +	 */
>> +	data->reg = ioremap(data->phys_div_reg, 4);
>> +	if (WARN_ON(!data->reg))
>> +		return NULL;
>> +
>> +	return clk_register_davinci_plldiv(NULL, name, parent, data, &_lock);
> This function does not exist at this point. Looks like you need to swap
> 3/11 with 4/11. Also, you should also add build infrastructure
> (makefile, Kconfig) changes in the same patch that creates the file.
> There is no point in adding those separately.
>
> Thanks,
> Sekhar
>
Sekhar,

So the Makefile, Kconfig and new files should be in the same patch.
Also will re-order the 3/11 and 4/11 in the next revision.

Murali

WARNING: multiple messages have this Message-ID (diff)
From: Murali Karicheri <m-karicheri2@ti.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: <mturquette@linaro.org>, <arnd@arndb.de>,
	<akpm@linux-foundation.org>, <shawn.guo@linaro.org>,
	<rob.herring@calxeda.com>, <linus.walleij@linaro.org>,
	<viresh.linux@gmail.com>, <linux-kernel@vger.kernel.org>,
	<khilman@ti.com>, <linux@arm.linux.org.uk>,
	<sshtylyov@mvista.com>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-keystone@list.ti.com>
Subject: Re: [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver
Date: Thu, 1 Nov 2012 14:34:51 -0400	[thread overview]
Message-ID: <5092C0CB.5020504@ti.com> (raw)
In-Reply-To: <50926E03.8050102@ti.com>

On 11/01/2012 08:41 AM, Sekhar Nori wrote:
> On 10/25/2012 9:41 PM, Murali Karicheri wrote:
>> This is the common clk driver initialization functions for DaVinci
>> SoCs and other SoCs that uses similar hardware architecture.
>> clock.h also defines struct types for clock definitions in a SoC
>> and clock data type for configuring clk-mux. The initialization
>> functions are used by clock initialization code in a specific
>> platform/SoC.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> +struct clk *davinci_plldiv_clk(const char *name, const char *parent,
>> +				struct clk_plldiv_data *data)
>> +{
>> +	/*
>> +	 * This is a PLL divider clock with divider specified by
>> +	 * div_reg in pll_div_data.
>> +	 */
>> +	data->reg = ioremap(data->phys_div_reg, 4);
>> +	if (WARN_ON(!data->reg))
>> +		return NULL;
>> +
>> +	return clk_register_davinci_plldiv(NULL, name, parent, data, &_lock);
> This function does not exist at this point. Looks like you need to swap
> 3/11 with 4/11. Also, you should also add build infrastructure
> (makefile, Kconfig) changes in the same patch that creates the file.
> There is no point in adding those separately.
>
> Thanks,
> Sekhar
>
Sekhar,

So the Makefile, Kconfig and new files should be in the same patch.
Also will re-order the 3/11 and 4/11 in the next revision.

Murali

  reply	other threads:[~2012-11-01 18:34 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 16:11 [PATCH v3 00/11] common clk drivers migration for DaVinci SoCs Murali Karicheri
2012-10-25 16:11 ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 01/11] clk: davinci - add main PLL clock driver Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-28 19:18   ` Linus Walleij
2012-10-28 19:18     ` Linus Walleij
2012-10-31 13:23     ` Murali Karicheri
2012-10-31 13:23       ` Murali Karicheri
2012-10-31 12:29   ` Sekhar Nori
2012-10-31 12:29     ` Sekhar Nori
2012-10-31 13:46     ` Murali Karicheri
2012-10-31 13:46       ` Murali Karicheri
2012-11-01 11:01       ` Sekhar Nori
2012-11-01 11:01         ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 02/11] clk: davinci - add PSC " Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-28 19:24   ` Linus Walleij
2012-10-28 19:24     ` Linus Walleij
2012-10-31 13:23     ` Murali Karicheri
2012-10-31 13:23       ` Murali Karicheri
2013-03-19 10:57     ` Sekhar Nori
2013-03-19 10:57       ` Sekhar Nori
2012-11-03 12:07   ` Sekhar Nori
2012-11-03 12:07     ` Sekhar Nori
2012-11-05 15:10     ` Murali Karicheri
2012-11-05 15:10       ` Murali Karicheri
2012-11-10  2:22       ` Mike Turquette
2012-11-10  2:22         ` Mike Turquette
2012-11-27 15:05         ` Sekhar Nori
2012-11-27 15:05           ` Sekhar Nori
2012-11-27 17:29           ` Mike Turquette
2012-11-27 20:38             ` Murali Karicheri
2012-11-27 20:38               ` Murali Karicheri
2012-11-28 13:22             ` Sekhar Nori
2012-11-28 13:22               ` Sekhar Nori
2013-03-22 11:20               ` Sekhar Nori
2013-03-22 11:20                 ` Sekhar Nori
2013-03-22 20:37                 ` Mike Turquette
2013-03-22 20:37                   ` Mike Turquette
2013-03-25  6:50                   ` Sekhar Nori
2013-03-25  6:50                     ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-28 19:25   ` Linus Walleij
2012-10-28 19:25     ` Linus Walleij
2012-10-31 13:23     ` Murali Karicheri
2012-10-31 13:23       ` Murali Karicheri
2012-11-01 12:41   ` Sekhar Nori
2012-11-01 12:41     ` Sekhar Nori
2012-11-01 18:34     ` Murali Karicheri [this message]
2012-11-01 18:34       ` Murali Karicheri
2012-11-03 12:35   ` Sekhar Nori
2012-11-03 12:35     ` Sekhar Nori
2012-11-05 15:20     ` Murali Karicheri
2012-11-05 15:20       ` Murali Karicheri
2012-11-06  9:31       ` Sekhar Nori
2012-11-06  9:31         ` Sekhar Nori
2012-11-06 15:04         ` Murali Karicheri
2012-11-06 15:04           ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 04/11] clk: davinci - add pll divider clock driver Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-28 19:26   ` Linus Walleij
2012-10-28 19:26     ` Linus Walleij
2012-10-31 13:22     ` Murali Karicheri
2012-10-31 13:22       ` Murali Karicheri
2012-11-02 11:33   ` Sekhar Nori
2012-11-02 11:33     ` Sekhar Nori
2012-11-02 13:53     ` Murali Karicheri
2012-11-02 13:53       ` Murali Karicheri
2012-11-03 12:03       ` Sekhar Nori
2012-11-03 12:03         ` Sekhar Nori
2012-11-05 15:10         ` Murali Karicheri
2012-11-05 15:10           ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 05/11] clk: davinci - add dm644x clock initialization Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-11-03 13:30   ` Sekhar Nori
2012-11-03 13:30     ` Sekhar Nori
2012-11-05 15:42     ` Murali Karicheri
2012-11-05 15:42       ` Murali Karicheri
2012-11-06 10:18       ` Sekhar Nori
2012-11-06 10:18         ` Sekhar Nori
2012-11-05 23:23     ` Murali Karicheri
2012-11-05 23:23       ` Murali Karicheri
2012-11-06  9:40       ` Sekhar Nori
2012-11-06  9:40         ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 06/11] clk: davinci - add build infrastructure for DaVinci clock drivers Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-11-04 13:34   ` Sekhar Nori
2012-11-04 13:34     ` Sekhar Nori
2012-11-05 16:17     ` Murali Karicheri
2012-11-05 16:17       ` Murali Karicheri
2012-11-06  9:48       ` Sekhar Nori
2012-11-06  9:48         ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 07/11] ARM: davinci - restructure header files for common clock migration Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-11-04 14:05   ` Sekhar Nori
2012-11-04 14:05     ` Sekhar Nori
2012-11-05 19:11     ` Murali Karicheri
2012-11-05 19:11       ` Murali Karicheri
2012-11-06 10:03       ` Sekhar Nori
2012-11-06 10:03         ` Sekhar Nori
2012-11-05 21:57     ` Murali Karicheri
2012-11-05 21:57       ` Murali Karicheri
2012-12-03 13:23       ` Sekhar Nori
2012-12-03 13:23         ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 08/11] ARM: davinci - migrating to use common clock init code Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 09/11] ARM: davinci - dm644x: update SoC code to remove the clock data Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 10/11] ARM: davinci - migrate to common clock Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-11-04 13:06   ` Sekhar Nori
2012-11-04 13:06     ` Sekhar Nori
2012-11-05 15:43     ` Murali Karicheri
2012-11-05 15:43       ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 11/11] ARM: davinci - common clock migration: clean up the old code Murali Karicheri
2012-10-25 16:11   ` Murali Karicheri
2012-10-30 17:00 ` [PATCH v3 00/11] common clk drivers migration for DaVinci SoCs Karicheri, Muralidharan
2012-10-30 17:00   ` Karicheri, Muralidharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5092C0CB.5020504@ti.com \
    --to=m-karicheri2@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.