From: Lars-Peter Clausen <lars@metafoo.de>
To: Josh Cartwright <josh.cartwright@ni.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Russell King <linux@arm.linux.org.uk>,
Mike Turquette <mturquette@ti.com>,
John Stultz <johnstul@us.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
John Linn <John.Linn@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 7/8] serial: xilinx_uartps: get clock rate info from dts
Date: Fri, 02 Nov 2012 10:20:33 +0100 [thread overview]
Message-ID: <50939061.9060201@metafoo.de> (raw)
In-Reply-To: <23a299ee5e89cfd17bb9affd8fbb9f41b79cfd46.1351721190.git.josh.cartwright@ni.com>
On 10/31/2012 08:28 PM, Josh Cartwright wrote:
> Add support for specifying clock information for the uart clk via the
> device tree. This eliminates the need to hardcode rates in the device
> tree.
>
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
> ---
> arch/arm/boot/dts/zynq-7000.dtsi | 4 ++--
> drivers/tty/serial/xilinx_uartps.c | 30 +++++++++++++++++-------------
> 2 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index bb3085c..5fb763f 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -44,14 +44,14 @@
> compatible = "xlnx,xuartps";
> reg = <0xE0000000 0x1000>;
> interrupts = <0 27 4>;
> - clock = <50000000>;
> + clocks = <&uart_clk 0>;
> };
>
> uart1: uart@e0001000 {
> compatible = "xlnx,xuartps";
> reg = <0xE0001000 0x1000>;
> interrupts = <0 50 4>;
> - clock = <50000000>;
> + clocks = <&uart_clk 0>;
Shouldn't this be <&uart_clk 1>?
> };
>
> slcr: slcr@f8000000 {
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] serial: xilinx_uartps: get clock rate info from dts
Date: Fri, 02 Nov 2012 10:20:33 +0100 [thread overview]
Message-ID: <50939061.9060201@metafoo.de> (raw)
In-Reply-To: <23a299ee5e89cfd17bb9affd8fbb9f41b79cfd46.1351721190.git.josh.cartwright@ni.com>
On 10/31/2012 08:28 PM, Josh Cartwright wrote:
> Add support for specifying clock information for the uart clk via the
> device tree. This eliminates the need to hardcode rates in the device
> tree.
>
> Signed-off-by: Josh Cartwright <josh.cartwright@ni.com>
> ---
> arch/arm/boot/dts/zynq-7000.dtsi | 4 ++--
> drivers/tty/serial/xilinx_uartps.c | 30 +++++++++++++++++-------------
> 2 files changed, 19 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index bb3085c..5fb763f 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -44,14 +44,14 @@
> compatible = "xlnx,xuartps";
> reg = <0xE0000000 0x1000>;
> interrupts = <0 27 4>;
> - clock = <50000000>;
> + clocks = <&uart_clk 0>;
> };
>
> uart1: uart at e0001000 {
> compatible = "xlnx,xuartps";
> reg = <0xE0001000 0x1000>;
> interrupts = <0 50 4>;
> - clock = <50000000>;
> + clocks = <&uart_clk 0>;
Shouldn't this be <&uart_clk 1>?
> };
>
> slcr: slcr at f8000000 {
next prev parent reply other threads:[~2012-11-02 9:20 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 22:06 [PATCH 0/8] zynq COMMON_CLK support Josh Cartwright
2012-10-31 22:06 ` Josh Cartwright
2012-10-29 18:42 ` [PATCH 2/8] ARM: zynq: move ttc timer code to drivers/clocksource Josh Cartwright
2012-10-29 18:42 ` Josh Cartwright
2012-11-05 11:22 ` Michal Simek
2012-11-05 11:22 ` Michal Simek
2012-11-05 14:49 ` Rob Herring
2012-11-05 14:49 ` Rob Herring
[not found] ` <CAHTX3d++0fGSw7GQHcc-S1X1Qh-rfekpr-E8Jkg2_vFqdCFFTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-05 21:47 ` Josh Cartwright
2012-11-05 21:47 ` Josh Cartwright
2012-11-05 21:47 ` Josh Cartwright
2012-11-12 11:53 ` Michal Simek
2012-11-12 11:53 ` Michal Simek
2012-10-30 12:25 ` [PATCH 6/8] serial: xilinx_uartps: kill CONFIG_OF conditional Josh Cartwright
2012-10-30 12:25 ` Josh Cartwright
2012-10-30 12:25 ` Josh Cartwright
2012-11-05 12:16 ` Michal Simek
2012-11-05 12:16 ` Michal Simek
2012-10-31 17:11 ` [PATCH 1/8] ARM: zynq: move arm-specific sys_timer out of ttc Josh Cartwright
2012-10-31 17:11 ` Josh Cartwright
2012-10-31 17:11 ` Josh Cartwright
2012-11-05 11:20 ` Michal Simek
2012-11-05 11:20 ` Michal Simek
2012-11-05 11:20 ` Michal Simek
2012-10-31 18:24 ` [PATCH 4/8] ARM: zynq: dts: split up device tree Josh Cartwright
2012-10-31 18:24 ` Josh Cartwright
2012-10-31 18:24 ` Josh Cartwright
2012-11-05 11:32 ` Michal Simek
2012-11-05 11:32 ` Michal Simek
2012-10-31 18:58 ` [PATCH 5/8] ARM: zynq: add COMMON_CLK support Josh Cartwright
2012-10-31 18:58 ` Josh Cartwright
2012-11-02 9:33 ` Lars-Peter Clausen
2012-11-02 9:33 ` Lars-Peter Clausen
2012-11-02 13:38 ` Josh Cartwright
2012-11-02 13:38 ` Josh Cartwright
2012-11-02 13:38 ` Josh Cartwright
2012-11-02 15:12 ` Lars-Peter Clausen
2012-11-02 15:12 ` Lars-Peter Clausen
2012-11-02 15:28 ` Josh Cartwright
2012-11-02 15:28 ` Josh Cartwright
2012-11-02 15:28 ` Josh Cartwright
2012-11-05 12:31 ` Michal Simek
2012-11-05 12:31 ` Michal Simek
2012-10-31 19:28 ` [PATCH 7/8] serial: xilinx_uartps: get clock rate info from dts Josh Cartwright
2012-10-31 19:28 ` Josh Cartwright
2012-11-02 9:20 ` Lars-Peter Clausen [this message]
2012-11-02 9:20 ` Lars-Peter Clausen
2012-11-02 13:39 ` Josh Cartwright
2012-11-02 13:39 ` Josh Cartwright
2012-11-02 13:39 ` Josh Cartwright
2012-10-31 19:45 ` [PATCH 3/8] ARM: zynq: dts: add description of the second uart Josh Cartwright
2012-10-31 19:45 ` Josh Cartwright
2012-10-31 19:45 ` Josh Cartwright
2012-11-05 11:35 ` Michal Simek
2012-11-05 11:35 ` Michal Simek
2012-10-31 19:56 ` [PATCH 8/8] clocksource: xilinx_ttc: add OF_CLK support Josh Cartwright
2012-10-31 19:56 ` Josh Cartwright
2012-11-02 2:56 ` Josh Cartwright
2012-11-02 2:56 ` Josh Cartwright
2012-11-05 13:02 ` Michal Simek
2012-11-05 13:02 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50939061.9060201@metafoo.de \
--to=lars@metafoo.de \
--cc=John.Linn@xilinx.com \
--cc=alan@linux.intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=johnstul@us.ibm.com \
--cc=josh.cartwright@ni.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=mturquette@ti.com \
--cc=rob.herring@calxeda.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.