* [Buildroot] [PATCH] package: add bcusdk
2012-10-30 12:24 [Buildroot] [PATCH] package: add libpthsem Gregory Hermant
@ 2012-10-30 12:24 ` Gregory Hermant
2012-10-30 12:45 ` Thomas Petazzoni
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add linknx Gregory Hermant
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Gregory Hermant @ 2012-10-30 12:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
package/Config.in | 1 +
package/bcusdk/Config.in | 11 +++++++
.../bcusdk-0.0.5-fix-pthsem-config-issue.patch | 33 ++++++++++++++++++++
package/bcusdk/bcusdk.mk | 21 +++++++++++++
4 files changed, 66 insertions(+)
create mode 100644 package/bcusdk/Config.in
create mode 100644 package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
create mode 100644 package/bcusdk/bcusdk.mk
diff --git a/package/Config.in b/package/Config.in
index a55a584..a6d0517 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -541,6 +541,7 @@ menu "Networking applications"
source "package/argus/Config.in"
source "package/avahi/Config.in"
source "package/axel/Config.in"
+source "package/bcusdk/Config.in"
source "package/bluez_utils/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/boa/Config.in"
diff --git a/package/bcusdk/Config.in b/package/bcusdk/Config.in
new file mode 100644
index 0000000..81d8882
--- /dev/null
+++ b/package/bcusdk/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_BCUSDK
+ bool "bcusdk"
+ depends on BR2_INSTALL_LIBSTDCPP
+ select BR2_PACKAGE_LIBPTHSEM
+ help
+ A free development environment for BCU1 and BCU2
+
+ http://www.auto.tuwien.ac.at/~mkoegler/eib/
+
+comment "bcusdk requires a toolchain with C++ "
+ depends on !(BR2_INSTALL_LIBSTDCPP)
diff --git a/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch b/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
new file mode 100644
index 0000000..82649f0
--- /dev/null
+++ b/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <gregory.hermant@calao-systems.com>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
+---
+ configure | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
+ if test ".$_pth_version" != .; then
+ _pth_location=`$_dir/pthsem-config --prefix`
+ _pth_type="installed"
+- _pth_cppflags=`$_dir/pthsem-config --cflags`
+- _pth_cflags=`$_dir/pthsem-config --cflags`
++# _pth_cppflags=`$_dir/pthsem-config --cflags`
++# _pth_cflags=`$_dir/pthsem-config --cflags`
+ _pth_ldflags=`$_dir/pthsem-config --ldflags`
+ _pth_libs=`$_dir/pthsem-config --libs --all`
+ _pth_found=yes
+--
+1.7.9.5
+
diff --git a/package/bcusdk/bcusdk.mk b/package/bcusdk/bcusdk.mk
new file mode 100644
index 0000000..9ed615d
--- /dev/null
+++ b/package/bcusdk/bcusdk.mk
@@ -0,0 +1,21 @@
+#############################################################
+#
+# bcusck
+#
+#############################################################
+
+BCUSDK_VERSION = 0.0.5
+BCUSDK_SOURCE = bcusdk_$(BCUSDK_VERSION).tar.gz
+BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib/
+BCUSDK_LICENSE = GPLv2+
+BCUSDK_LICENSE_FILES = COPYING
+BCUSDK_INSTALL_STAGING = YES
+BCUSDK_INSTALL_TARGET = YES
+BCUSDK_CONF_OPT = --enable-onlyeibd --enable-ft12 --enable-pei16 \
+ --enable-eibnetip --enable-eibnetipserver \
+ --enable-eibnetiptunnel --without-pth-test \
+ --with-pth=$(STAGING_DIR)/usr
+
+BCUSDK_DEPENDENCIES = libpthsem
+
+$(eval $(autotools-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] package: add bcusdk
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add bcusdk Gregory Hermant
@ 2012-10-30 12:45 ` Thomas Petazzoni
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-10-30 12:45 UTC (permalink / raw)
To: buildroot
Dear Gregory Hermant,
On Tue, 30 Oct 2012 13:24:01 +0100, Gregory Hermant wrote:
> +comment "bcusdk requires a toolchain with C++ "
> + depends on !(BR2_INSTALL_LIBSTDCPP)
Parenthesis not needed.
> diff --git a/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch b/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
> new file mode 100644
> index 0000000..82649f0
> --- /dev/null
> +++ b/package/bcusdk/bcusdk-0.0.5-fix-pthsem-config-issue.patch
> @@ -0,0 +1,33 @@
> +From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
> +From: Gregory Hermant <gregory.hermant@calao-systems.com>
> +Date: Mon, 22 Oct 2012 15:29:43 +0200
> +Subject: [PATCH] Prevent pthsem-config script to return bad include path.
> +
> +During the bcusdk configuration step, the script pthsem-config
> +is used to return some parameters about the pthsem library location.
> +Unfortunately this script returns host include path and prevents
> +the bcusdk build.
> +
> +Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> +---
> + configure | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/configure b/configure
> +index 843e017..f77d5a9 100755
> +--- a/configure
> ++++ b/configure
> +@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
> + if test ".$_pth_version" != .; then
> + _pth_location=`$_dir/pthsem-config --prefix`
> + _pth_type="installed"
> +- _pth_cppflags=`$_dir/pthsem-config --cflags`
> +- _pth_cflags=`$_dir/pthsem-config --cflags`
> ++# _pth_cppflags=`$_dir/pthsem-config --cflags`
> ++# _pth_cflags=`$_dir/pthsem-config --cflags`
> + _pth_ldflags=`$_dir/pthsem-config --ldflags`
> + _pth_libs=`$_dir/pthsem-config --libs --all`
> + _pth_found=yes
No, that's not the way we handle this problem in Buildroot. In the
pthsem package, you should mungle the pthsem-config script after
installation, in order to adjust the paths. See
package/libpng/libpng.mk for an example.
> +BCUSDK_VERSION = 0.0.5
> +BCUSDK_SOURCE = bcusdk_$(BCUSDK_VERSION).tar.gz
> +BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib/
> +BCUSDK_LICENSE = GPLv2+
> +BCUSDK_LICENSE_FILES = COPYING
> +BCUSDK_INSTALL_STAGING = YES
> +BCUSDK_INSTALL_TARGET = YES
_INSTALL_TARGET=YES not needed, it's the default.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add linknx
2012-10-30 12:24 [Buildroot] [PATCH] package: add libpthsem Gregory Hermant
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add bcusdk Gregory Hermant
@ 2012-10-30 12:24 ` Gregory Hermant
2012-10-30 12:48 ` Thomas Petazzoni
2012-10-31 5:01 ` Baruch Siach
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add knxweb Gregory Hermant
2012-10-30 12:42 ` [Buildroot] [PATCH] package: add libpthsem Thomas Petazzoni
3 siblings, 2 replies; 11+ messages in thread
From: Gregory Hermant @ 2012-10-30 12:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
package/Config.in | 1 +
package/linknx/Config.in | 20 ++++++++++++
.../linknx-0.0.1.30-fix-pthsem-config-issue.patch | 33 ++++++++++++++++++++
...0.0.1.30-link-with-libdl-when-lua-enabled.patch | 27 ++++++++++++++++
package/linknx/linknx.mk | 25 +++++++++++++++
5 files changed, 106 insertions(+)
create mode 100644 package/linknx/Config.in
create mode 100644 package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
create mode 100644 package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
create mode 100644 package/linknx/linknx.mk
diff --git a/package/Config.in b/package/Config.in
index a6d0517..3dd169f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -582,6 +582,7 @@ source "package/kismet/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/lighttpd/Config.in"
endif
+source "package/linknx/Config.in"
source "package/links/Config.in"
source "package/linphone/Config.in"
source "package/lrzsz/Config.in"
diff --git a/package/linknx/Config.in b/package/linknx/Config.in
new file mode 100644
index 0000000..c5b49af
--- /dev/null
+++ b/package/linknx/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LINKNX
+ bool "linknx"
+ select BR2_PACKAGE_LIBPTHSEM
+ help
+ Linknx is only one component of a bigger project.The goal is to get
+ the maximum comfort and flexibility from a KNX domotic system while
+ keeping the smallest possible resource consumption.
+
+ http://belnet.dl.sourceforge.net/sourceforge/linknx/
+
+if BR2_PACKAGE_LINKNX
+
+config BR2_PACKAGE_LINKNX_LUA
+ bool "lua support"
+ depends on BR2_PACKAGE_LINKNX
+ select BR2_PACKAGE_LUA
+ help
+ Enable Lua support.
+
+endif
diff --git a/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch b/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
new file mode 100644
index 0000000..82649f0
--- /dev/null
+++ b/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
@@ -0,0 +1,33 @@
+From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <gregory.hermant@calao-systems.com>
+Date: Mon, 22 Oct 2012 15:29:43 +0200
+Subject: [PATCH] Prevent pthsem-config script to return bad include path.
+
+During the bcusdk configuration step, the script pthsem-config
+is used to return some parameters about the pthsem library location.
+Unfortunately this script returns host include path and prevents
+the bcusdk build.
+
+Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
+---
+ configure | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/configure b/configure
+index 843e017..f77d5a9 100755
+--- a/configure
++++ b/configure
+@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
+ if test ".$_pth_version" != .; then
+ _pth_location=`$_dir/pthsem-config --prefix`
+ _pth_type="installed"
+- _pth_cppflags=`$_dir/pthsem-config --cflags`
+- _pth_cflags=`$_dir/pthsem-config --cflags`
++# _pth_cppflags=`$_dir/pthsem-config --cflags`
++# _pth_cflags=`$_dir/pthsem-config --cflags`
+ _pth_ldflags=`$_dir/pthsem-config --ldflags`
+ _pth_libs=`$_dir/pthsem-config --libs --all`
+ _pth_found=yes
+--
+1.7.9.5
+
diff --git a/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch b/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
new file mode 100644
index 0000000..22fea47
--- /dev/null
+++ b/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
@@ -0,0 +1,27 @@
+From 6e377c72555ffc5f9b729292b802440f155854d7 Mon Sep 17 00:00:00 2001
+From: Gregory Hermant <gregory.hermant@calao-systems.com>
+Date: Mon, 29 Oct 2012 17:45:43 +0100
+Subject: [PATCH] Link with libdl when lua is enabled
+
+
+Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
+---
+ src/Makefile.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/Makefile.in b/src/Makefile.in
+index 9eccf8d..90e02f0 100644
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -184,7 +184,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/ticpp $(PTH_CPPFLAGS) $(LIBCURL_CPPFLAGS) $(LOG4CPP_CFLAGS) $(LUA_CFLAGS)
+-linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm
++linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm -ldl
+ linknx_SOURCES = linknx.cpp logger.cpp ruleserver.cpp objectcontroller.cpp eibclient.c threads.cpp timermanager.cpp persistentstorage.cpp xmlserver.cpp smsgateway.cpp emailgateway.cpp knxconnection.cpp services.cpp suncalc.cpp luacondition.cpp ioport.cpp ruleserver.h objectcontroller.h threads.h timermanager.h persistentstorage.h xmlserver.h smsgateway.h emailgateway.h knxconnection.h services.h suncalc.h luacondition.h ioport.h logger.h
+ all: all-am
+
+--
+1.7.9.5
+
diff --git a/package/linknx/linknx.mk b/package/linknx/linknx.mk
new file mode 100644
index 0000000..219eca4
--- /dev/null
+++ b/package/linknx/linknx.mk
@@ -0,0 +1,25 @@
+#############################################################
+#
+# linknx
+#
+#############################################################
+
+LINKNX_VERSION = 0.0.1.30
+LINKNX_SOURCE = linknx-${LINKNX_VERSION}.tar.gz
+LINKNX_SITE = http://sourceforge.net/projects/linknx/files/linknx/linknx-0.0.1.30/
+LINKNX_LICENSE = GPLv2+
+LINKNX_LICENSE_FILES = COPYING
+LINKNX_INSTALL_STAGING = YES
+LINKNX_INSTALL_TARGET = YES
+LINKNX_CONF_OPT = --without-log4cpp --without-pth-test \
+ --with-pth=$(STAGING_DIR)/usr
+LINKNX_DEPENDENCIES = libpthsem
+
+ifeq ($(BR2_PACKAGE_LUA),y)
+LINKNX_DEPENDENCIES += lua
+LINKNX_CONF_OPT += --with-lua
+else
+LINKNX_CONF_OPT += --without-lua
+endif
+
+$(eval $(autotools-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] package: add linknx
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add linknx Gregory Hermant
@ 2012-10-30 12:48 ` Thomas Petazzoni
2012-10-31 5:01 ` Baruch Siach
1 sibling, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-10-30 12:48 UTC (permalink / raw)
To: buildroot
Dear Gregory Hermant,
On Tue, 30 Oct 2012 13:24:02 +0100, Gregory Hermant wrote:
> +config BR2_PACKAGE_LINKNX
> + bool "linknx"
> + select BR2_PACKAGE_LIBPTHSEM
> + help
> + Linknx is only one component of a bigger project.The goal is to get
Nitpick: missing space after dot.
> + the maximum comfort and flexibility from a KNX domotic system while
> + keeping the smallest possible resource consumption.
This explanation is not very helpful "Linknx is only one component of a
bigger project". Which bigger project?
> +
> + http://belnet.dl.sourceforge.net/sourceforge/linknx/
> +
> +if BR2_PACKAGE_LINKNX
> +
> +config BR2_PACKAGE_LINKNX_LUA
> + bool "lua support"
> + depends on BR2_PACKAGE_LINKNX
Dependency not needed, you are already inside a if
BR2_PACKAGE_LINKNX ... endif clause.
> + select BR2_PACKAGE_LUA
I am not sure we want a 'select' here. For things that require 'big'
stuff like an interpreter, we generally use a 'depends on '.
> + help
> + Enable Lua support.
> +
> +endif
> diff --git a/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch b/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
> new file mode 100644
> index 0000000..82649f0
> --- /dev/null
> +++ b/package/linknx/linknx-0.0.1.30-fix-pthsem-config-issue.patch
> @@ -0,0 +1,33 @@
> +From 8129fd135b0674017854fd722105eb0558cd3987 Mon Sep 17 00:00:00 2001
> +From: Gregory Hermant <gregory.hermant@calao-systems.com>
> +Date: Mon, 22 Oct 2012 15:29:43 +0200
> +Subject: [PATCH] Prevent pthsem-config script to return bad include path.
> +
> +During the bcusdk configuration step, the script pthsem-config
> +is used to return some parameters about the pthsem library location.
> +Unfortunately this script returns host include path and prevents
> +the bcusdk build.
> +
> +Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> +---
> + configure | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/configure b/configure
> +index 843e017..f77d5a9 100755
> +--- a/configure
> ++++ b/configure
> +@@ -15958,8 +15958,8 @@ if test ".$with_pth" != .no; then
> + if test ".$_pth_version" != .; then
> + _pth_location=`$_dir/pthsem-config --prefix`
> + _pth_type="installed"
> +- _pth_cppflags=`$_dir/pthsem-config --cflags`
> +- _pth_cflags=`$_dir/pthsem-config --cflags`
> ++# _pth_cppflags=`$_dir/pthsem-config --cflags`
> ++# _pth_cflags=`$_dir/pthsem-config --cflags`
> + _pth_ldflags=`$_dir/pthsem-config --ldflags`
> + _pth_libs=`$_dir/pthsem-config --libs --all`
> + _pth_found=yes
Same comment as previous package: fix pthsem-config instead of hacking
all other packages on top of it.
Or even better (but takes more time): add pkg-config support to all
those packages.
> +
> diff --git a/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch b/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
> new file mode 100644
> index 0000000..22fea47
> --- /dev/null
> +++ b/package/linknx/linknx-0.0.1.30-link-with-libdl-when-lua-enabled.patch
> @@ -0,0 +1,27 @@
> +From 6e377c72555ffc5f9b729292b802440f155854d7 Mon Sep 17 00:00:00 2001
> +From: Gregory Hermant <gregory.hermant@calao-systems.com>
> +Date: Mon, 29 Oct 2012 17:45:43 +0100
> +Subject: [PATCH] Link with libdl when lua is enabled
> +
> +
> +Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
> +---
> + src/Makefile.in | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/src/Makefile.in b/src/Makefile.in
> +index 9eccf8d..90e02f0 100644
> +--- a/src/Makefile.in
> ++++ b/src/Makefile.in
> +@@ -184,7 +184,7 @@ top_build_prefix = @top_build_prefix@
> + top_builddir = @top_builddir@
> + top_srcdir = @top_srcdir@
> + AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/ticpp $(PTH_CPPFLAGS) $(LIBCURL_CPPFLAGS) $(LOG4CPP_CFLAGS) $(LUA_CFLAGS)
> +-linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm
> ++linknx_LDADD = ../ticpp/libticpp.a $(PTH_LDFLAGS) $(PTH_LIBS) $(LIBCURL) $(LOG4CPP_LIBS) $(LUA_LIBS) -lm -ldl
> + linknx_SOURCES = linknx.cpp logger.cpp ruleserver.cpp objectcontroller.cpp eibclient.c threads.cpp timermanager.cpp persistentstorage.cpp xmlserver.cpp smsgateway.cpp emailgateway.cpp knxconnection.cpp services.cpp suncalc.cpp luacondition.cpp ioport.cpp ruleserver.h objectcontroller.h threads.h timermanager.h persistentstorage.h xmlserver.h smsgateway.h emailgateway.h knxconnection.h services.h suncalc.h luacondition.h ioport.h logger.h
> + all: all-am
> +
> +--
> +1.7.9.5
> +
The Makefile.am should be patched instead, and the package marked
_AUTORECONF=YES.
> diff --git a/package/linknx/linknx.mk b/package/linknx/linknx.mk
> new file mode 100644
> index 0000000..219eca4
> --- /dev/null
> +++ b/package/linknx/linknx.mk
> @@ -0,0 +1,25 @@
> +#############################################################
> +#
> +# linknx
> +#
> +#############################################################
> +
> +LINKNX_VERSION = 0.0.1.30
> +LINKNX_SOURCE = linknx-${LINKNX_VERSION}.tar.gz
> +LINKNX_SITE = http://sourceforge.net/projects/linknx/files/linknx/linknx-0.0.1.30/
Please use a http://downloads.sourceforge.net URL, like we do for all
other Sourceforge-hosted packages.
> +LINKNX_LICENSE = GPLv2+
> +LINKNX_LICENSE_FILES = COPYING
> +LINKNX_INSTALL_STAGING = YES
> +LINKNX_INSTALL_TARGET = YES
Last line not needed.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH] package: add linknx
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add linknx Gregory Hermant
2012-10-30 12:48 ` Thomas Petazzoni
@ 2012-10-31 5:01 ` Baruch Siach
1 sibling, 0 replies; 11+ messages in thread
From: Baruch Siach @ 2012-10-31 5:01 UTC (permalink / raw)
To: buildroot
Hi Gregory,
On Tue, Oct 30, 2012 at 01:24:02PM +0100, Gregory Hermant wrote:
[...]
> +config BR2_PACKAGE_LINKNX
> + bool "linknx"
> + select BR2_PACKAGE_LIBPTHSEM
> + help
> + Linknx is only one component of a bigger project.The goal is to get
> + the maximum comfort and flexibility from a KNX domotic system while
> + keeping the smallest possible resource consumption.
> +
> + http://belnet.dl.sourceforge.net/sourceforge/linknx/
Broken link. Should probably be http://linknx.sourceforge.net/.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add knxweb
2012-10-30 12:24 [Buildroot] [PATCH] package: add libpthsem Gregory Hermant
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add bcusdk Gregory Hermant
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add linknx Gregory Hermant
@ 2012-10-30 12:24 ` Gregory Hermant
2012-10-30 12:55 ` Thomas Petazzoni
2012-10-30 12:42 ` [Buildroot] [PATCH] package: add libpthsem Thomas Petazzoni
3 siblings, 1 reply; 11+ messages in thread
From: Gregory Hermant @ 2012-10-30 12:24 UTC (permalink / raw)
To: buildroot
Signed-off-by: Gregory Hermant <gregory.hermant@calao-systems.com>
---
package/Config.in | 1 +
package/knxweb/Config.in | 6 ++++++
package/knxweb/knxweb.mk | 20 ++++++++++++++++++++
3 files changed, 27 insertions(+)
create mode 100644 package/knxweb/Config.in
create mode 100644 package/knxweb/knxweb.mk
diff --git a/package/Config.in b/package/Config.in
index 3dd169f..2a99882 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -579,6 +579,7 @@ source "package/ipset/Config.in"
source "package/iptables/Config.in"
source "package/iw/Config.in"
source "package/kismet/Config.in"
+source "package/knxweb/Config.in"
if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
source "package/lighttpd/Config.in"
endif
diff --git a/package/knxweb/Config.in b/package/knxweb/Config.in
new file mode 100644
index 0000000..088e6e1
--- /dev/null
+++ b/package/knxweb/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_KNXWEB
+ bool "knxweb"
+ help
+ KnxWeb is a graphical visualization interface for Linknx.
+
+ http://belnet.dl.sourceforge.net/sourceforge/linknx/
diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
new file mode 100644
index 0000000..5ca1760
--- /dev/null
+++ b/package/knxweb/knxweb.mk
@@ -0,0 +1,20 @@
+#############################################################
+#
+# knxweb
+#
+#############################################################
+
+KNXWEB_VERSION = 0.6.1
+KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
+KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
+
+define KNXWEB_INSTALL_TARGET_CMDS
+ mkdir -p $(TARGET_DIR)/var/www
+ cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
+endef
+
+define KNXWEB__UNINSTALL_TARGET_CMDS
+ rm -rf $(TARGET_DIR)/var/www/
+endef
+
+$(eval $(generic-package))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add knxweb
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add knxweb Gregory Hermant
@ 2012-10-30 12:55 ` Thomas Petazzoni
2012-11-06 8:19 ` Grégory Hermant
0 siblings, 1 reply; 11+ messages in thread
From: Thomas Petazzoni @ 2012-10-30 12:55 UTC (permalink / raw)
To: buildroot
Dear Gregory Hermant,
On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
> new file mode 100644
> index 0000000..5ca1760
> --- /dev/null
> +++ b/package/knxweb/knxweb.mk
> @@ -0,0 +1,20 @@
> +#############################################################
> +#
> +# knxweb
> +#
> +#############################################################
> +
> +KNXWEB_VERSION = 0.6.1
> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
The tarball has no license information, this is quite annoying.
> +define KNXWEB_INSTALL_TARGET_CMDS
> + mkdir -p $(TARGET_DIR)/var/www
> + cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
> +endef
> +
> +define KNXWEB__UNINSTALL_TARGET_CMDS
> + rm -rf $(TARGET_DIR)/var/www/
> +endef
Double _ here, so this doesn't work.
However, how does this web interface works? I see a few PHP scripts,
but they don't seem to be essential for the operation of the Web
interface. There's a lot of JS though. Does it communicate with the
server somehow?
I'm surprised that no interpreter like PHP, Lua or Python is needed
here for the server side, that's why I'm asking.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add knxweb
2012-10-30 12:55 ` Thomas Petazzoni
@ 2012-11-06 8:19 ` Grégory Hermant
2012-11-13 20:21 ` Arnout Vandecappelle
0 siblings, 1 reply; 11+ messages in thread
From: Grégory Hermant @ 2012-11-06 8:19 UTC (permalink / raw)
To: buildroot
Hi thomas,
Le 30/10/2012 13:55, Thomas Petazzoni a ?crit :
> Dear Gregory Hermant,
>
> On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
>> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
>> new file mode 100644
>> index 0000000..5ca1760
>> --- /dev/null
>> +++ b/package/knxweb/knxweb.mk
>> @@ -0,0 +1,20 @@
>> +#############################################################
>> +#
>> +# knxweb
>> +#
>> +#############################################################
>> +
>> +KNXWEB_VERSION = 0.6.1
>> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
>> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
>
> The tarball has no license information, this is quite annoying.
How can we manage this kind of package in buildroot ?
>
>> +define KNXWEB_INSTALL_TARGET_CMDS
>> + mkdir -p $(TARGET_DIR)/var/www
>> + cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
>> +endef
>> +
>> +define KNXWEB__UNINSTALL_TARGET_CMDS
>> + rm -rf $(TARGET_DIR)/var/www/
>> +endef
>
> Double _ here, so this doesn't work.
>
> However, how does this web interface works? I see a few PHP scripts,
> but they don't seem to be essential for the operation of the Web
> interface. There's a lot of JS though. Does it communicate with the
> server somehow?
>
knxweb needs a web server with PHP support.
> I'm surprised that no interpreter like PHP, Lua or Python is needed
> here for the server side, that's why I'm asking.
>
> Thanks,
>
> Thomas
>
gregory
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add knxweb
2012-11-06 8:19 ` Grégory Hermant
@ 2012-11-13 20:21 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2012-11-13 20:21 UTC (permalink / raw)
To: buildroot
On 06/11/12 09:19, Gr?gory Hermant wrote:
> Hi thomas,
>
> Le 30/10/2012 13:55, Thomas Petazzoni a ?crit :
>> Dear Gregory Hermant,
>>
>> On Tue, 30 Oct 2012 13:24:03 +0100, Gregory Hermant wrote:
>>> diff --git a/package/knxweb/knxweb.mk b/package/knxweb/knxweb.mk
>>> new file mode 100644
>>> index 0000000..5ca1760
>>> --- /dev/null
>>> +++ b/package/knxweb/knxweb.mk
>>> @@ -0,0 +1,20 @@
>>> +#############################################################
>>> +#
>>> +# knxweb
>>> +#
>>> +#############################################################
>>> +
>>> +KNXWEB_VERSION = 0.6.1
>>> +KNXWEB_SOURCE = knxweb-$(KNXWEB_VERSION).tar.gz
>>> +KNXWEB_SITE = http://sourceforge.net/projects/linknx/files/knxweb/knxweb-0.6.1/
This URL doesn't work - it should be
http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-0.6
For this case, you better refactor
KNXWEB_VERSION_MAJOR = 0.6
KNXWEB_VERSION = $(KNXWEB_VERSION_MAJOR).1
KNXWEB_SITE = http://downloads.sourceforge.net/project/linknx/knxweb/knxweb-$(KNXWEB_VERSION_MAJOR)
Note that you can remove KNXWEB_SOURCE, it is the default.
>>
>> The tarball has no license information, this is quite annoying.
>
> How can we manage this kind of package in buildroot ?
There's no solution, it's just annoying. Or actually, it's more than annoying:
since no explicit permission is given to copy the code, any use beyond simply
downloading it is illegal... So I guess you should put:
KNXWEB_LICENSE = none (no permission is given)
>>
>>> +define KNXWEB_INSTALL_TARGET_CMDS
>>> + mkdir -p $(TARGET_DIR)/var/www
>>> + cp -rdpf $(@D)/* $(TARGET_DIR)/var/www
>>> +endef
>>> +
>>> +define KNXWEB__UNINSTALL_TARGET_CMDS
>>> + rm -rf $(TARGET_DIR)/var/www/
>>> +endef
>>
>> Double _ here, so this doesn't work.
>>
>> However, how does this web interface works? I see a few PHP scripts,
>> but they don't seem to be essential for the operation of the Web
>> interface. There's a lot of JS though. Does it communicate with the
>> server somehow?
>>
> knxweb needs a web server with PHP support.
>
>> I'm surprised that no interpreter like PHP, Lua or Python is needed
>> here for the server side, that's why I'm asking.
At the moment we can't select or depend on a web server. Selecting PHP is
possible, however, so I think you should add that to Config.in (not to the
.mk file because there is no build-time dependency)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH] package: add libpthsem
2012-10-30 12:24 [Buildroot] [PATCH] package: add libpthsem Gregory Hermant
` (2 preceding siblings ...)
2012-10-30 12:24 ` [Buildroot] [PATCH] package: add knxweb Gregory Hermant
@ 2012-10-30 12:42 ` Thomas Petazzoni
3 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2012-10-30 12:42 UTC (permalink / raw)
To: buildroot
Dear Gregory Hermant,
On Tue, 30 Oct 2012 13:24:00 +0100, Gregory Hermant wrote:
> +LIBPTHSEM_AUTORECONF = YES
Really needed?
> +LIBPTHSEM_INSTALL_TARGET = YES
Not needed.
Otherwise, looks good.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread