From: Loic PALLARDY <loic.pallardy@st.com>
To: Omar Ramirez Luna <omar.luna@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Arnd Bergmann <arnd@arndb.de>, Ohad Ben-Cohen <ohad@wizery.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dom Cobley <popcornmix@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>,
Linus Walleij <linus.walleij@linaro.org>,
Suman Anna <s-anna@ti.com>, Juan Gutierrez <jgutierrez@ti.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Tejun Heo <tj@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mailbox: split internal header from API header
Date: Tue, 6 Nov 2012 13:53:29 +0100 [thread overview]
Message-ID: <50990849.4050003@st.com> (raw)
In-Reply-To: <1352170552-29564-3-git-send-email-omar.luna@linaro.org>
On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote:
> Now internal structures can remain hidden to the user and just API
> related functions and defines are made available.
>
> Signed-off-by: Omar Ramirez Luna<omar.luna@linaro.org>
> ---
> drivers/mailbox/mailbox.c | 34 ++++++++++++++++++++++++++++++++
> drivers/mailbox/mailbox.h | 48 +--------------------------------------------
> include/linux/mailbox.h | 22 +++++++++++++++++++
I agree with the file split but I think mailbox framework API should be
more generic.
omap_ prefix should not be used. mailbox_ prefix will be better.
Message type must be more opened like for example:
struct mailbox_msg {
int size;
unsigned char header;
unsigned char *pdata;
};
Regards,
Loic
WARNING: multiple messages have this Message-ID (diff)
From: loic.pallardy@st.com (Loic PALLARDY)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] mailbox: split internal header from API header
Date: Tue, 6 Nov 2012 13:53:29 +0100 [thread overview]
Message-ID: <50990849.4050003@st.com> (raw)
In-Reply-To: <1352170552-29564-3-git-send-email-omar.luna@linaro.org>
On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote:
> Now internal structures can remain hidden to the user and just API
> related functions and defines are made available.
>
> Signed-off-by: Omar Ramirez Luna<omar.luna@linaro.org>
> ---
> drivers/mailbox/mailbox.c | 34 ++++++++++++++++++++++++++++++++
> drivers/mailbox/mailbox.h | 48 +--------------------------------------------
> include/linux/mailbox.h | 22 +++++++++++++++++++
I agree with the file split but I think mailbox framework API should be
more generic.
omap_ prefix should not be used. mailbox_ prefix will be better.
Message type must be more opened like for example:
struct mailbox_msg {
int size;
unsigned char header;
unsigned char *pdata;
};
Regards,
Loic
next prev parent reply other threads:[~2012-11-06 12:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 2:55 [PATCH v2 0/2] drivers: mailbox: omap-mailbox out of plat code Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 2:55 ` [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 3:40 ` Stephen Warren
2012-11-06 3:40 ` Stephen Warren
2012-11-06 8:55 ` Linus Walleij
2012-11-06 8:55 ` Linus Walleij
2012-11-06 8:59 ` Greg Kroah-Hartman
2012-11-06 8:59 ` Greg Kroah-Hartman
2012-11-07 1:10 ` Omar Ramirez Luna
2012-11-07 1:10 ` Omar Ramirez Luna
2012-11-07 1:05 ` Omar Ramirez Luna
2012-11-07 1:05 ` Omar Ramirez Luna
2012-11-06 2:55 ` [PATCH v2 2/2] mailbox: split internal header from API header Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 12:53 ` Loic PALLARDY [this message]
2012-11-06 12:53 ` Loic PALLARDY
2012-11-07 6:41 ` Omar Ramirez Luna
2012-11-07 6:41 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50990849.4050003@st.com \
--to=loic.pallardy@st.com \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=felipe.contreras@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgutierrez@ti.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
--cc=popcornmix@gmail.com \
--cc=s-anna@ti.com \
--cc=tj@kernel.org \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.