From: Jon Hunter <jon-hunter@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: OMAP2+: Prevent redefinition errors for soc.h
Date: Fri, 9 Nov 2012 20:52:04 -0600 [thread overview]
Message-ID: <509DC154.7000808@ti.com> (raw)
In-Reply-To: <20121110002142.GC6801@atomide.com>
On 11/09/2012 06:21 PM, Tony Lindgren wrote:
> * Jon Hunter <jon-hunter@ti.com> [121109 15:59]:
>>
>> Sorry, I meant in the fixes series I have posted for dmtimer, I am
>> adding a new function called omap_dm_timer_populate_errata() that is
>> using cpu_is_xxxx() [1]. I had done this a while back, but now I see
>> that we want to get away from doing that right?
>
> Yes. Looks like everything we have under plat-omap can be moved
> to live under drivers eventually, so let's not use cpu_is_omap
> there either. For legacy boot, you can use pdata->timer_capability
> for passing that?
Yes, but I prefer to keep capability and errata separate. So I have
added an timer_errata variable to the pdata for now.
>> I was planning on sending you a pull request for that series on Monday
>> but now I am wondering if I should fix this now or later. I was hoping
>> this series would make 3.8.
>
> Yeah, sounds like that should be fixed though as we still have a bit
> of time early next week.
Ok, great. I have re-worked and will stress test over the weekend. I
will send out an updated series Monday and then send a pull request
later in the week if you are ok with it.
Cheers
Jon
WARNING: multiple messages have this Message-ID (diff)
From: jon-hunter@ti.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Prevent redefinition errors for soc.h
Date: Fri, 9 Nov 2012 20:52:04 -0600 [thread overview]
Message-ID: <509DC154.7000808@ti.com> (raw)
In-Reply-To: <20121110002142.GC6801@atomide.com>
On 11/09/2012 06:21 PM, Tony Lindgren wrote:
> * Jon Hunter <jon-hunter@ti.com> [121109 15:59]:
>>
>> Sorry, I meant in the fixes series I have posted for dmtimer, I am
>> adding a new function called omap_dm_timer_populate_errata() that is
>> using cpu_is_xxxx() [1]. I had done this a while back, but now I see
>> that we want to get away from doing that right?
>
> Yes. Looks like everything we have under plat-omap can be moved
> to live under drivers eventually, so let's not use cpu_is_omap
> there either. For legacy boot, you can use pdata->timer_capability
> for passing that?
Yes, but I prefer to keep capability and errata separate. So I have
added an timer_errata variable to the pdata for now.
>> I was planning on sending you a pull request for that series on Monday
>> but now I am wondering if I should fix this now or later. I was hoping
>> this series would make 3.8.
>
> Yeah, sounds like that should be fixed though as we still have a bit
> of time early next week.
Ok, great. I have re-worked and will stress test over the weekend. I
will send out an updated series Monday and then send a pull request
later in the week if you are ok with it.
Cheers
Jon
next prev parent reply other threads:[~2012-11-10 2:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 16:19 [PATCH] ARM: OMAP2+: Prevent redefinition errors for soc.h Jon Hunter
2012-11-09 16:19 ` Jon Hunter
2012-11-09 16:22 ` Tony Lindgren
2012-11-09 16:22 ` Tony Lindgren
2012-11-09 16:29 ` Jon Hunter
2012-11-09 16:29 ` Jon Hunter
2012-11-09 21:10 ` Tony Lindgren
2012-11-09 21:10 ` Tony Lindgren
2012-11-09 23:42 ` Jon Hunter
2012-11-09 23:42 ` Jon Hunter
2012-11-09 23:50 ` Tony Lindgren
2012-11-09 23:50 ` Tony Lindgren
2012-11-09 23:57 ` Jon Hunter
2012-11-09 23:57 ` Jon Hunter
2012-11-10 0:21 ` Tony Lindgren
2012-11-10 0:21 ` Tony Lindgren
2012-11-10 2:52 ` Jon Hunter [this message]
2012-11-10 2:52 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509DC154.7000808@ti.com \
--to=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.