* [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
@ 2012-11-10 14:07 ` dron0gus at gmail.com
0 siblings, 0 replies; 10+ messages in thread
From: dron0gus at gmail.com @ 2012-11-10 14:07 UTC (permalink / raw)
To: linux-arm-kernel
From: Andrey Gusakov <dron_gus@mail.ru>
The "camera" clock have only one parent. Define it staticly and
remove unused source clock list.
Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
---
arch/arm/mach-s3c64xx/clock.c | 12 +-----------
1 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c
index b2d08fa..19228f3 100644
--- a/arch/arm/mach-s3c64xx/clock.c
+++ b/arch/arm/mach-s3c64xx/clock.c
@@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = {
.nr_sources = ARRAY_SIZE(clkset_audio2_list),
};
-static struct clk *clkset_camif_list[] = {
- &clk_h2,
-};
-
-static struct clksrc_sources clkset_camif = {
- .sources = clkset_camif_list,
- .nr_sources = ARRAY_SIZE(clkset_camif_list),
-};
-
static struct clk *clkset_mfc_list[] = {
&clk_h2,
&clk_mout_epll.clk,
@@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = {
.name = "camera",
.ctrlbit = S3C_CLKCON_SCLK_CAM,
.enable = s3c64xx_sclk_ctrl,
+ .parent = &clk_h2,
},
.reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 },
- .reg_src = { .reg = NULL, .shift = 0, .size = 0 },
- .sources = &clkset_camif,
}, {
.clk = {
.name = "sclk_mfc",
--
1.7.0.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
2012-11-10 14:07 ` dron0gus at gmail.com
@ 2012-11-10 15:01 ` Tomasz Figa
-1 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2012-11-10 15:01 UTC (permalink / raw)
To: dron0gus
Cc: linux-samsung-soc, kgene.kim, linux-arm-kernel,
sylvester.nawrocki, Andrey Gusakov
Hi Andrey,
On Saturday 10 of November 2012 18:07:57 dron0gus@gmail.com wrote:
> From: Andrey Gusakov <dron_gus@mail.ru>
>
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
>
> Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
> ---
> arch/arm/mach-s3c64xx/clock.c | 12 +-----------
> 1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/clock.c
> b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644
> --- a/arch/arm/mach-s3c64xx/clock.c
> +++ b/arch/arm/mach-s3c64xx/clock.c
> @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = {
> .nr_sources = ARRAY_SIZE(clkset_audio2_list),
> };
>
> -static struct clk *clkset_camif_list[] = {
> - &clk_h2,
> -};
> -
> -static struct clksrc_sources clkset_camif = {
> - .sources = clkset_camif_list,
> - .nr_sources = ARRAY_SIZE(clkset_camif_list),
> -};
> -
> static struct clk *clkset_mfc_list[] = {
> &clk_h2,
> &clk_mout_epll.clk,
> @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = {
> .name = "camera",
> .ctrlbit = S3C_CLKCON_SCLK_CAM,
> .enable = s3c64xx_sclk_ctrl,
> + .parent = &clk_h2,
> },
> .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size
= 4 },
> - .reg_src = { .reg = NULL, .shift = 0, .size = 0 },
> - .sources = &clkset_camif,
> }, {
> .clk = {
> .name = "sclk_mfc",
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz Figa
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
@ 2012-11-10 15:01 ` Tomasz Figa
0 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2012-11-10 15:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrey,
On Saturday 10 of November 2012 18:07:57 dron0gus at gmail.com wrote:
> From: Andrey Gusakov <dron_gus@mail.ru>
>
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
>
> Signed-off-by: Andrey Gusakov <dron0gus@gmail.com>
> ---
> arch/arm/mach-s3c64xx/clock.c | 12 +-----------
> 1 files changed, 1 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/clock.c
> b/arch/arm/mach-s3c64xx/clock.c index b2d08fa..19228f3 100644
> --- a/arch/arm/mach-s3c64xx/clock.c
> +++ b/arch/arm/mach-s3c64xx/clock.c
> @@ -677,15 +677,6 @@ static struct clksrc_sources clkset_audio2 = {
> .nr_sources = ARRAY_SIZE(clkset_audio2_list),
> };
>
> -static struct clk *clkset_camif_list[] = {
> - &clk_h2,
> -};
> -
> -static struct clksrc_sources clkset_camif = {
> - .sources = clkset_camif_list,
> - .nr_sources = ARRAY_SIZE(clkset_camif_list),
> -};
> -
> static struct clk *clkset_mfc_list[] = {
> &clk_h2,
> &clk_mout_epll.clk,
> @@ -750,10 +741,9 @@ static struct clksrc_clk clksrcs[] = {
> .name = "camera",
> .ctrlbit = S3C_CLKCON_SCLK_CAM,
> .enable = s3c64xx_sclk_ctrl,
> + .parent = &clk_h2,
> },
> .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size
= 4 },
> - .reg_src = { .reg = NULL, .shift = 0, .size = 0 },
> - .sources = &clkset_camif,
> }, {
> .clk = {
> .name = "sclk_mfc",
Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz Figa
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
2012-11-10 14:07 ` dron0gus at gmail.com
@ 2012-11-10 21:13 ` Sylwester Nawrocki
-1 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2012-11-10 21:13 UTC (permalink / raw)
To: dron0gus
Cc: linux-samsung-soc, kgene.kim, linux-arm-kernel,
sylvester.nawrocki, Andrey Gusakov
On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote:
> From: Andrey Gusakov<dron_gus@mail.ru>
>
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
>
> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
@ 2012-11-10 21:13 ` Sylwester Nawrocki
0 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2012-11-10 21:13 UTC (permalink / raw)
To: linux-arm-kernel
On 11/10/2012 03:07 PM, dron0gus at gmail.com wrote:
> From: Andrey Gusakov<dron_gus@mail.ru>
>
> The "camera" clock have only one parent. Define it staticly and
> remove unused source clock list.
>
> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
2012-11-10 21:13 ` Sylwester Nawrocki
@ 2012-11-10 21:33 ` Sylwester Nawrocki
-1 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2012-11-10 21:33 UTC (permalink / raw)
To: dron0gus, kgene.kim; +Cc: linux-samsung-soc, linux-arm-kernel, Andrey Gusakov
On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote:
> On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote:
>> From: Andrey Gusakov<dron_gus@mail.ru>
>>
>> The "camera" clock have only one parent. Define it staticly and
Forgot to point out a small typo here: staticly -> statically.
>> remove unused source clock list.
>>
>> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
>
> Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
@ 2012-11-10 21:33 ` Sylwester Nawrocki
0 siblings, 0 replies; 10+ messages in thread
From: Sylwester Nawrocki @ 2012-11-10 21:33 UTC (permalink / raw)
To: linux-arm-kernel
On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote:
> On 11/10/2012 03:07 PM, dron0gus at gmail.com wrote:
>> From: Andrey Gusakov<dron_gus@mail.ru>
>>
>> The "camera" clock have only one parent. Define it staticly and
Forgot to point out a small typo here: staticly -> statically.
>> remove unused source clock list.
>>
>> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
>
> Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
2012-11-10 21:33 ` Sylwester Nawrocki
@ 2012-11-12 5:02 ` Kukjin Kim
-1 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2012-11-12 5:02 UTC (permalink / raw)
To: 'Sylwester Nawrocki', dron0gus
Cc: linux-samsung-soc, linux-arm-kernel, 'Andrey Gusakov'
Sylwester Nawrocki wrote:
>
> On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote:
> > On 11/10/2012 03:07 PM, dron0gus@gmail.com wrote:
> >> From: Andrey Gusakov<dron_gus@mail.ru>
> >>
> >> The "camera" clock have only one parent. Define it staticly and
>
> Forgot to point out a small typo here: staticly -> statically.
>
Thanks for pointing out. I fixed it when I applied.
> >> remove unused source clock list.
> >>
> >> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
> >
> > Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of "camera" clock
@ 2012-11-12 5:02 ` Kukjin Kim
0 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2012-11-12 5:02 UTC (permalink / raw)
To: linux-arm-kernel
Sylwester Nawrocki wrote:
>
> On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote:
> > On 11/10/2012 03:07 PM, dron0gus at gmail.com wrote:
> >> From: Andrey Gusakov<dron_gus@mail.ru>
> >>
> >> The "camera" clock have only one parent. Define it staticly and
>
> Forgot to point out a small typo here: staticly -> statically.
>
Thanks for pointing out. I fixed it when I applied.
> >> remove unused source clock list.
> >>
> >> Signed-off-by: Andrey Gusakov<dron0gus@gmail.com>
> >
> > Reviewed-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 10+ messages in thread