From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 0/2] NVIDIA Tegra DRM driver
Date: Mon, 12 Nov 2012 17:17:18 -0700 [thread overview]
Message-ID: <50A1918E.1000809@wwwdotorg.org> (raw)
In-Reply-To: <1352757358-14001-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
On 11/12/2012 02:55 PM, Thierry Reding wrote:
> This second version of this patch series addresses all the comments
> received so far. Most notably it takes advantage of the debugfs helpers
> provided by the DRM core. Oddly enough this actually increases the line
> count, but that's because the helpers don't fit with the subdevices
> approach as implemented by this driver. However some quick discussions
> with Rob Clark showed that Tegra DRM is not special in this respect but
> other drivers may need the same functionality. Eventually the debugfs
> code could be reworked on top of helpers that are better suited at the
> design of embedded, multi-device DRM drivers.
>
> Other than that there is some removal of code that was actually supposed
> to go into a later patch because it has dependencies that haven't been
> merged yet and some moving around of #defines and the device tree
> bindings documentation. Finally the driver now uses the DRM core's
> drm_compat_ioctl() instead of a custom and unimplemented (!) version.
The series,
Tested-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
(on the Harmony board's HDMI output; I'll test other boards/outputs later).
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Dave Airlie <airlied@redhat.com>,
linux-tegra@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
devicetree-discuss@lists.ozlabs.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] NVIDIA Tegra DRM driver
Date: Mon, 12 Nov 2012 17:17:18 -0700 [thread overview]
Message-ID: <50A1918E.1000809@wwwdotorg.org> (raw)
In-Reply-To: <1352757358-14001-1-git-send-email-thierry.reding@avionic-design.de>
On 11/12/2012 02:55 PM, Thierry Reding wrote:
> This second version of this patch series addresses all the comments
> received so far. Most notably it takes advantage of the debugfs helpers
> provided by the DRM core. Oddly enough this actually increases the line
> count, but that's because the helpers don't fit with the subdevices
> approach as implemented by this driver. However some quick discussions
> with Rob Clark showed that Tegra DRM is not special in this respect but
> other drivers may need the same functionality. Eventually the debugfs
> code could be reworked on top of helpers that are better suited at the
> design of embedded, multi-device DRM drivers.
>
> Other than that there is some removal of code that was actually supposed
> to go into a later patch because it has dependencies that haven't been
> merged yet and some moving around of #defines and the device tree
> bindings documentation. Finally the driver now uses the DRM core's
> drm_compat_ioctl() instead of a custom and unimplemented (!) version.
The series,
Tested-by: Stephen Warren <swarren@nvidia.com>
(on the Harmony board's HDMI output; I'll test other boards/outputs later).
next prev parent reply other threads:[~2012-11-13 0:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:55 [PATCH v2 0/2] NVIDIA Tegra DRM driver Thierry Reding
2012-11-12 21:55 ` Thierry Reding
[not found] ` <1352757358-14001-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-11-12 21:55 ` [PATCH v2 1/2] drm: Add NVIDIA Tegra20 support Thierry Reding
2012-11-12 21:55 ` Thierry Reding
[not found] ` <1352757358-14001-2-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-11-13 7:15 ` Mark Zhang
2012-11-13 7:15 ` Mark Zhang
2012-11-13 7:48 ` Thierry Reding
2012-11-13 8:49 ` Mark Zhang
[not found] ` <50A20994.9000305-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-13 9:37 ` Thierry Reding
2012-11-13 9:37 ` Thierry Reding
[not found] ` <20121113093725.GB8122-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 9:49 ` Mark Zhang
2012-11-13 9:49 ` Mark Zhang
[not found] ` <50A217A8.2000600-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-13 9:54 ` Thierry Reding
2012-11-13 9:54 ` Thierry Reding
[not found] ` <20121113095424.GA982-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 9:58 ` Mark Zhang
2012-11-13 9:58 ` Mark Zhang
2012-11-13 17:40 ` Stephen Warren
2012-11-13 17:40 ` Stephen Warren
[not found] ` <20121113074822.GA8409-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 10:05 ` Thierry Reding
2012-11-13 10:05 ` Thierry Reding
[not found] ` <50A1F3A3.40905-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-13 17:37 ` Stephen Warren
2012-11-13 17:37 ` Stephen Warren
[not found] ` <50A28542.8020406-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-14 2:24 ` Mark Zhang
2012-11-14 2:24 ` Mark Zhang
2012-11-13 9:45 ` Terje Bergström
2012-11-13 9:45 ` Terje Bergström
[not found] ` <50A216D3.1070604-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-13 9:48 ` Thierry Reding
2012-11-13 9:48 ` Thierry Reding
2012-11-12 21:55 ` [PATCH v2 2/2] drm: tegra: Add HDMI support Thierry Reding
2012-11-12 21:55 ` Thierry Reding
[not found] ` <1352757358-14001-3-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
2012-11-13 7:27 ` Mark Zhang
2012-11-13 7:27 ` Mark Zhang
2012-11-13 0:17 ` Stephen Warren [this message]
2012-11-13 0:17 ` [PATCH v2 0/2] NVIDIA Tegra DRM driver Stephen Warren
[not found] ` <50A1918E.1000809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-13 6:47 ` Thierry Reding
2012-11-13 6:47 ` Thierry Reding
[not found] ` <20121113064748.GB31443-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
2012-11-13 17:43 ` Stephen Warren
2012-11-13 17:43 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A1918E.1000809@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.