From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <jbeulich@suse.com>, Wei Wang <wei.wang2@amd.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Concern about AMD IOMMU HPET msi remapping
Date: Mon, 19 Nov 2012 13:33:19 +0000 [thread overview]
Message-ID: <50AA351F.5030301@citrix.com> (raw)
Hello,
In the committed patch
http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/9025a10c0561
The bdf parameter to update_intremap_entry_from_msi_msg() is declared as
u8. The single caller of this function passes bdf as an int (which is
only ever filled with a u16), while the this function passes bdf to
get_{dma,intremap}_requestor_id(), which expect u16's
Is there not a truncation issue by doing this, or am I missing something?
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next reply other threads:[~2012-11-19 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:33 Andrew Cooper [this message]
2012-11-19 14:09 ` Concern about AMD IOMMU HPET msi remapping Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA351F.5030301@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wei.wang2@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.