* Concern about AMD IOMMU HPET msi remapping
@ 2012-11-19 13:33 Andrew Cooper
2012-11-19 14:09 ` Jan Beulich
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cooper @ 2012-11-19 13:33 UTC (permalink / raw)
To: Jan Beulich, Wei Wang; +Cc: xen-devel@lists.xen.org
Hello,
In the committed patch
http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/9025a10c0561
The bdf parameter to update_intremap_entry_from_msi_msg() is declared as
u8. The single caller of this function passes bdf as an int (which is
only ever filled with a u16), while the this function passes bdf to
get_{dma,intremap}_requestor_id(), which expect u16's
Is there not a truncation issue by doing this, or am I missing something?
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Concern about AMD IOMMU HPET msi remapping
2012-11-19 13:33 Concern about AMD IOMMU HPET msi remapping Andrew Cooper
@ 2012-11-19 14:09 ` Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2012-11-19 14:09 UTC (permalink / raw)
To: Wei Wang, Andrew Cooper; +Cc: xen-devel@lists.xen.org
>>> On 19.11.12 at 14:33, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> Hello,
>
> In the committed patch
> http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/9025a10c0561
>
> The bdf parameter to update_intremap_entry_from_msi_msg() is declared as
> u8. The single caller of this function passes bdf as an int (which is
> only ever filled with a u16), while the this function passes bdf to
> get_{dma,intremap}_requestor_id(), which expect u16's
>
> Is there not a truncation issue by doing this, or am I missing something?
Oh, indeed - thanks for spotting. Will fix this right away.
Jan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-19 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 13:33 Concern about AMD IOMMU HPET msi remapping Andrew Cooper
2012-11-19 14:09 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.