All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangyanfei <zhangyanfei@cn.fujitsu.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Avi Kivity <avi@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary
Date: Tue, 20 Nov 2012 17:56:08 +0800	[thread overview]
Message-ID: <50AB53B8.1030309@cn.fujitsu.com> (raw)
In-Reply-To: <20121120003258.GA1292@amt.cnet>

于 2012年11月20日 08:32, Marcelo Tosatti 写道:
> On Fri, Nov 16, 2012 at 06:12:58PM +0800, zhangyanfei wrote:
>> Hello Marcelo,
>>
>> Any thoughts?
> 
> I thought a function call was OK, but its better to have all code in
> vmx.c. Please have an atomic notifier in kexec.c (registered by KVM
> module via atomic_notifier_chain_register etc).
> 
> Other than that, which is largely cosmetic, it looks fine.
> Sorry for not expressing this earlier.
> 
> 

Hmm, Thanks. I will resend a new patch set.

Thanks
Zhang

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: zhangyanfei <zhangyanfei@cn.fujitsu.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: "x86@kernel.org" <x86@kernel.org>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>,
	Avi Kivity <avi@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary
Date: Tue, 20 Nov 2012 17:56:08 +0800	[thread overview]
Message-ID: <50AB53B8.1030309@cn.fujitsu.com> (raw)
In-Reply-To: <20121120003258.GA1292@amt.cnet>

于 2012年11月20日 08:32, Marcelo Tosatti 写道:
> On Fri, Nov 16, 2012 at 06:12:58PM +0800, zhangyanfei wrote:
>> Hello Marcelo,
>>
>> Any thoughts?
> 
> I thought a function call was OK, but its better to have all code in
> vmx.c. Please have an atomic notifier in kexec.c (registered by KVM
> module via atomic_notifier_chain_register etc).
> 
> Other than that, which is largely cosmetic, it looks fine.
> Sorry for not expressing this earlier.
> 
> 

Hmm, Thanks. I will resend a new patch set.

Thanks
Zhang

  reply	other threads:[~2012-11-20  9:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14  9:29 [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary zhangyanfei
2012-11-14  9:29 ` zhangyanfei
2012-11-14  9:31 ` [PATCH v4 1/2] x86/kexec: VMCLEAR vmcss on all cpus " zhangyanfei
2012-11-14  9:31   ` zhangyanfei
2012-11-14  9:32 ` [PATCH v4 2/2] KVM: set/unset crash_clear_loaded_vmcss and vmclear_skipped in kvm_intel module zhangyanfei
2012-11-14  9:32   ` zhangyanfei
2012-11-14  9:32   ` zhangyanfei
2012-11-16 10:12 ` [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary zhangyanfei
2012-11-16 10:12   ` zhangyanfei
2012-11-20  0:32   ` Marcelo Tosatti
2012-11-20  0:32     ` Marcelo Tosatti
2012-11-20  9:56     ` zhangyanfei [this message]
2012-11-20  9:56       ` zhangyanfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB53B8.1030309@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=avi@redhat.com \
    --cc=kexec@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.