From: Stefan Priebe <s.priebe@profihost.ag>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
ceph-devel@vger.kernel.org, pve-devel@pve.proxmox.com,
josh.durgin@inktank.com
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Tue, 20 Nov 2012 20:16:35 +0100 [thread overview]
Message-ID: <50ABD713.3050300@profihost.ag> (raw)
In-Reply-To: <20121120162922.GA8665@stefanha-thinkpad.redhat.com>
Hi Stefan,
Am 20.11.2012 17:29, schrieb Stefan Hajnoczi:
> On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote:
>> rbd / rados tends to return pretty often length of writes
>> or discarded blocks. These values might be bigger than int.
>>
>> Signed-off-by: Stefan Priebe <s.priebe@profihost.ag>
>> ---
>> block/rbd.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Looks good but I want to check whether this fixes an bug you've hit?
> Please indicate details of the bug and how to reproduce it in the commit
> message.
you get various I/O errors in client. As negative return values indicate
I/O errors. When now a big positive value is returned by librbd
block/rbd tries to store this one in acb->ret which is an int. Then it
wraps around and is negative. After that block/rbd thinks this is an I/O
error and report this to the guest.
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Priebe <s.priebe@profihost.ag>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: pbonzini@redhat.com, ceph-devel@vger.kernel.org,
qemu-devel@nongnu.org, pve-devel@pve.proxmox.com,
josh.durgin@inktank.com
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Tue, 20 Nov 2012 20:16:35 +0100 [thread overview]
Message-ID: <50ABD713.3050300@profihost.ag> (raw)
In-Reply-To: <20121120162922.GA8665@stefanha-thinkpad.redhat.com>
Hi Stefan,
Am 20.11.2012 17:29, schrieb Stefan Hajnoczi:
> On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote:
>> rbd / rados tends to return pretty often length of writes
>> or discarded blocks. These values might be bigger than int.
>>
>> Signed-off-by: Stefan Priebe <s.priebe@profihost.ag>
>> ---
>> block/rbd.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Looks good but I want to check whether this fixes an bug you've hit?
> Please indicate details of the bug and how to reproduce it in the commit
> message.
you get various I/O errors in client. As negative return values indicate
I/O errors. When now a big positive value is returned by librbd
block/rbd tries to store this one in acb->ret which is an int. Then it
wraps around and is negative. After that block/rbd thinks this is an I/O
error and report this to the guest.
Stefan
next prev parent reply other threads:[~2012-11-20 19:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:44 [PATCH] use int64_t for return values from rbd instead of int Stefan Priebe
2012-11-20 12:44 ` [Qemu-devel] " Stefan Priebe
2012-11-20 16:29 ` Stefan Hajnoczi
2012-11-20 16:29 ` Stefan Hajnoczi
2012-11-20 19:16 ` Stefan Priebe [this message]
2012-11-20 19:16 ` Stefan Priebe
2012-11-21 6:41 ` Stefan Hajnoczi
2012-11-21 6:41 ` Stefan Hajnoczi
2012-11-21 7:47 ` Stefan Priebe - Profihost AG
2012-11-21 7:47 ` Stefan Priebe - Profihost AG
2012-11-21 8:26 ` Stefan Hajnoczi
2012-11-21 8:26 ` Stefan Hajnoczi
[not found] ` <20121121082616.GB13504-lxVrvc10SDTaErKTczak/Dh473NlOPsLVpNB7YpNyf8@public.gmane.org>
2012-11-21 8:33 ` Stefan Priebe - Profihost AG
2012-11-21 8:33 ` Stefan Priebe - Profihost AG
2012-11-21 8:43 ` Stefan Hajnoczi
2012-11-21 8:43 ` Stefan Hajnoczi
2012-11-21 17:03 ` Stefan Weil
2012-11-21 17:03 ` [Qemu-devel] " Stefan Weil
2012-11-21 20:53 ` Stefan Priebe - Profihost AG
2012-11-21 20:53 ` Stefan Priebe - Profihost AG
2012-11-21 22:32 ` Peter Maydell
2012-11-21 22:32 ` [Qemu-devel] " Peter Maydell
[not found] ` <CAFEAcA-cAx88UZRQjHT7uk_oj8P+tXBJ+hb9v0N1Wym8FUMkHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22 8:23 ` Stefan Priebe - Profihost AG
2012-11-22 8:23 ` Stefan Priebe - Profihost AG
2012-11-22 8:40 ` Peter Maydell
2012-11-22 8:40 ` [Qemu-devel] " Peter Maydell
[not found] ` <CAFEAcA86AomWmobTObpw80rMNWM30JzAKqHZXWxmB48+GU3VYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22 9:08 ` Stefan Priebe - Profihost AG
2012-11-22 9:08 ` Stefan Priebe - Profihost AG
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 21:26 Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ABD713.3050300@profihost.ag \
--to=s.priebe@profihost.ag \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@inktank.com \
--cc=pbonzini@redhat.com \
--cc=pve-devel@pve.proxmox.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.