From: Stefan Priebe - Profihost AG <s.priebe-2Lf/h1ldwEHR5kwTpVNS9A@public.gmane.org>
To: Peter Maydell <peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Stefan Hajnoczi
<stefanha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stefan Weil <sw-QDXxdeohBKYb1SvskN2V4Q@public.gmane.org>,
qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org,
pve-devel-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org,
pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
josh.durgin-4GqslpFJ+cxBDgjK7y7TUQ@public.gmane.org,
ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Thu, 22 Nov 2012 09:23:49 +0100 [thread overview]
Message-ID: <50ADE115.4060707@profihost.ag> (raw)
In-Reply-To: <CAFEAcA-cAx88UZRQjHT7uk_oj8P+tXBJ+hb9v0N1Wym8FUMkHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Am 21.11.2012 23:32, schrieb Peter Maydell:
> On 21 November 2012 17:03, Stefan Weil <sw-QDXxdeohBKYb1SvskN2V4Q@public.gmane.org> wrote:
>> Why do you use int64_t instead of off_t?
>> If the value is related to file sizes, off_t would be a good choice.
>
> Looking at the librbd API (which is what the size and ret
> values come from), it uses size_t and ssize_t for these.
> So I think probably ssize_t is the right type for ret
> (and size) in our structs here.
This sounds reasonable but does ssize_t support negative values? For
error values.
Greets,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, pve-devel@pve.proxmox.com,
pbonzini@redhat.com, josh.durgin@inktank.com,
ceph-devel@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Thu, 22 Nov 2012 09:23:49 +0100 [thread overview]
Message-ID: <50ADE115.4060707@profihost.ag> (raw)
In-Reply-To: <CAFEAcA-cAx88UZRQjHT7uk_oj8P+tXBJ+hb9v0N1Wym8FUMkHQ@mail.gmail.com>
Am 21.11.2012 23:32, schrieb Peter Maydell:
> On 21 November 2012 17:03, Stefan Weil <sw@weilnetz.de> wrote:
>> Why do you use int64_t instead of off_t?
>> If the value is related to file sizes, off_t would be a good choice.
>
> Looking at the librbd API (which is what the size and ret
> values come from), it uses size_t and ssize_t for these.
> So I think probably ssize_t is the right type for ret
> (and size) in our structs here.
This sounds reasonable but does ssize_t support negative values? For
error values.
Greets,
Stefan
next prev parent reply other threads:[~2012-11-22 8:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:44 [PATCH] use int64_t for return values from rbd instead of int Stefan Priebe
2012-11-20 12:44 ` [Qemu-devel] " Stefan Priebe
2012-11-20 16:29 ` Stefan Hajnoczi
2012-11-20 16:29 ` Stefan Hajnoczi
2012-11-20 19:16 ` Stefan Priebe
2012-11-20 19:16 ` Stefan Priebe
2012-11-21 6:41 ` Stefan Hajnoczi
2012-11-21 6:41 ` Stefan Hajnoczi
2012-11-21 7:47 ` Stefan Priebe - Profihost AG
2012-11-21 7:47 ` Stefan Priebe - Profihost AG
2012-11-21 8:26 ` Stefan Hajnoczi
2012-11-21 8:26 ` Stefan Hajnoczi
[not found] ` <20121121082616.GB13504-lxVrvc10SDTaErKTczak/Dh473NlOPsLVpNB7YpNyf8@public.gmane.org>
2012-11-21 8:33 ` Stefan Priebe - Profihost AG
2012-11-21 8:33 ` Stefan Priebe - Profihost AG
2012-11-21 8:43 ` Stefan Hajnoczi
2012-11-21 8:43 ` Stefan Hajnoczi
2012-11-21 17:03 ` Stefan Weil
2012-11-21 17:03 ` [Qemu-devel] " Stefan Weil
2012-11-21 20:53 ` Stefan Priebe - Profihost AG
2012-11-21 20:53 ` Stefan Priebe - Profihost AG
2012-11-21 22:32 ` Peter Maydell
2012-11-21 22:32 ` [Qemu-devel] " Peter Maydell
[not found] ` <CAFEAcA-cAx88UZRQjHT7uk_oj8P+tXBJ+hb9v0N1Wym8FUMkHQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22 8:23 ` Stefan Priebe - Profihost AG [this message]
2012-11-22 8:23 ` Stefan Priebe - Profihost AG
2012-11-22 8:40 ` Peter Maydell
2012-11-22 8:40 ` [Qemu-devel] " Peter Maydell
[not found] ` <CAFEAcA86AomWmobTObpw80rMNWM30JzAKqHZXWxmB48+GU3VYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-22 9:08 ` Stefan Priebe - Profihost AG
2012-11-22 9:08 ` Stefan Priebe - Profihost AG
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 21:26 Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ADE115.4060707@profihost.ag \
--to=s.priebe-2lf/h1ldwehr5kwtpvns9a@public.gmane.org \
--cc=ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=josh.durgin-4GqslpFJ+cxBDgjK7y7TUQ@public.gmane.org \
--cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peter.maydell-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=pve-devel-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org \
--cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
--cc=stefanha-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sw-QDXxdeohBKYb1SvskN2V4Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.