From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP
Date: Wed, 21 Nov 2012 13:31:36 +0100 [thread overview]
Message-ID: <50ACC9A8.9060409@free-electrons.com> (raw)
In-Reply-To: <20121121122610.GM3290@n2100.arm.linux.org.uk>
On 11/21/2012 01:26 PM, Russell King - ARM Linux wrote:
> On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote:
>> Sorry, my mistake (I was thinking on my feet) since secondary_startup is
>> declared in a C file, right? How about:
>>
>> ldr lr, =secondary_startup
>> b ll_set_cpu_coherent
>
> Why? Do we really want LR to be the _virtual_ address? No we don't,
> because secondary_startup expects to be called with the MMU off.
>
> So I go back to my original comment. What's wrong with:
>
> bl ll_set_cpu_coherent
> b secondary_startup
>
> ?
Nothing wrong, it works perfectly.
Whereas indeed the code proposed by Will didn't work very well.
I will take Russell's suggestion.
Thanks,
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Russell King - ARM Linux <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Cc: Lior Amsalem <alior-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Ike Pan <ike.pan-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Nadav Haklai <nadavh-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Ian Molton <ian.molton-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>,
David Marlin <dmarlin-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Yehuda Yitschak <yehuday-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Jani Monoses
<jani.monoses-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Tawfik Bayouk <tawfik-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Dan Frazier
<dann.frazier-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
Eran Ben-Avi <benavi-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Leif Lindholm <Leif.Lindholm-5wv7dgnIgG8@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
"jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org"
<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XWGXanvQGlWp@public.gmane.org>
Subject: Re: [PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP
Date: Wed, 21 Nov 2012 13:31:36 +0100 [thread overview]
Message-ID: <50ACC9A8.9060409@free-electrons.com> (raw)
In-Reply-To: <20121121122610.GM3290-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 11/21/2012 01:26 PM, Russell King - ARM Linux wrote:
> On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote:
>> Sorry, my mistake (I was thinking on my feet) since secondary_startup is
>> declared in a C file, right? How about:
>>
>> ldr lr, =secondary_startup
>> b ll_set_cpu_coherent
>
> Why? Do we really want LR to be the _virtual_ address? No we don't,
> because secondary_startup expects to be called with the MMU off.
>
> So I go back to my original comment. What's wrong with:
>
> bl ll_set_cpu_coherent
> b secondary_startup
>
> ?
Nothing wrong, it works perfectly.
Whereas indeed the code proposed by Will didn't work very well.
I will take Russell's suggestion.
Thanks,
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-11-21 12:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 21:15 [PATCH V5 0/5] SMP support for Armada XP Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-20 21:15 ` [PATCH V5 1/5] arm: mvebu: Added support for coherency fabric in mach-mvebu Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-21 10:36 ` Will Deacon
2012-11-21 10:36 ` Will Deacon
2012-11-21 11:53 ` Gregory CLEMENT
2012-11-21 11:53 ` Gregory CLEMENT
2012-11-21 14:12 ` Gregory CLEMENT
2012-11-21 14:12 ` Gregory CLEMENT
2012-11-20 21:15 ` [PATCH V5 2/5] arm: mvebu: Added initial support for power managmement service unit Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-20 21:15 ` [PATCH V5 3/5] arm: mvebu: Added IPI support via doorbells Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-20 21:15 ` [PATCH V5 4/5] arm: mm: Added support for PJ4B cpu and init routines Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-20 21:15 ` [PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP Gregory CLEMENT
2012-11-20 21:15 ` Gregory CLEMENT
2012-11-21 10:41 ` Will Deacon
2012-11-21 10:41 ` Will Deacon
2012-11-21 11:57 ` Gregory CLEMENT
2012-11-21 11:57 ` Gregory CLEMENT
2012-11-21 12:22 ` Will Deacon
2012-11-21 12:22 ` Will Deacon
2012-11-21 12:26 ` Russell King - ARM Linux
2012-11-21 12:26 ` Russell King - ARM Linux
2012-11-21 12:31 ` Gregory CLEMENT [this message]
2012-11-21 12:31 ` Gregory CLEMENT
2012-11-21 13:13 ` Will Deacon
2012-11-21 13:13 ` Will Deacon
2012-11-21 11:38 ` Russell King - ARM Linux
2012-11-21 11:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACC9A8.9060409@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.