From: Stephen Warren <swarren@wwwdotorg.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Michal Marek <mmarek@suse.cz>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule
Date: Wed, 28 Nov 2012 11:33:39 -0700 [thread overview]
Message-ID: <50B65903.1050400@wwwdotorg.org> (raw)
In-Reply-To: <1354058956-7199-1-git-send-email-swarren@wwwdotorg.org>
On 11/27/2012 04:29 PM, Stephen Warren wrote:
> All architectures that use cmd_dtc do so in almost the same way. Create
> a central build rule to avoid duplication. The one difference is that
> most current uses of dtc build $(obj)/%.dtb from $(src)/dts/%.dts rather
> than building the .dtb in the same directory as the .dts file. This
> difference will be eliminated arch-by-arch in future patches.
>
> MIPS is the exception here; it already uses the exact same rule as the
> new common rule, so the duplicate is removed in this patch to avoid any
> conflict. arch/mips changes courtesy of Ralf Baechle.
>
> Update Documentation/kbuild to remove the explicit call to cmd_dtc from
> the example, now that the rule exists in a centralized location.
Ben, Paul,
Following this patch (http://lkml.org/lkml/2012/11/27/555), I posted a
series of patches to convert almost all architectures to using the
centralized rule. The one architecture I didn't convert was PowerPC.
I didn't convert it because arch/powerpc/boot/Makefile contains a large
number of rules (to generate *Image.% where % is a board name) that
depend on %.dtb, which is expected to be in arch/powerpc/boot rather
than arch/powerpc/boot/dts. Now, I guess it's possible to convert them
all to expect the .dtb files to be in dts/ and also have
arch/powerpc/boot/Makefile call make in boot/dts/ to make each required
.dtb file. However, the patch would be a bit larger than all the other
architecture patches. Do you want me to do that conversion, or would you
rather I leave PowerPC alone? Thanks for any feedback.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: Michal Marek <mmarek@suse.cz>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <rob.herring@calxeda.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule
Date: Wed, 28 Nov 2012 11:33:39 -0700 [thread overview]
Message-ID: <50B65903.1050400@wwwdotorg.org> (raw)
In-Reply-To: <1354058956-7199-1-git-send-email-swarren@wwwdotorg.org>
On 11/27/2012 04:29 PM, Stephen Warren wrote:
> All architectures that use cmd_dtc do so in almost the same way. Create
> a central build rule to avoid duplication. The one difference is that
> most current uses of dtc build $(obj)/%.dtb from $(src)/dts/%.dts rather
> than building the .dtb in the same directory as the .dts file. This
> difference will be eliminated arch-by-arch in future patches.
>
> MIPS is the exception here; it already uses the exact same rule as the
> new common rule, so the duplicate is removed in this patch to avoid any
> conflict. arch/mips changes courtesy of Ralf Baechle.
>
> Update Documentation/kbuild to remove the explicit call to cmd_dtc from
> the example, now that the rule exists in a centralized location.
Ben, Paul,
Following this patch (http://lkml.org/lkml/2012/11/27/555), I posted a
series of patches to convert almost all architectures to using the
centralized rule. The one architecture I didn't convert was PowerPC.
I didn't convert it because arch/powerpc/boot/Makefile contains a large
number of rules (to generate *Image.% where % is a board name) that
depend on %.dtb, which is expected to be in arch/powerpc/boot rather
than arch/powerpc/boot/dts. Now, I guess it's possible to convert them
all to expect the .dtb files to be in dts/ and also have
arch/powerpc/boot/Makefile call make in boot/dts/ to make each required
.dtb file. However, the patch would be a bit larger than all the other
architecture patches. Do you want me to do that conversion, or would you
rather I leave PowerPC alone? Thanks for any feedback.
next prev parent reply other threads:[~2012-11-28 18:33 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 23:29 [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:50 ` Olof Johansson
2012-11-27 23:50 ` Olof Johansson
2012-12-03 16:15 ` Rob Herring
2012-12-03 16:15 ` Rob Herring
2012-12-03 17:26 ` Stephen Warren
2012-12-03 17:26 ` Stephen Warren
2012-12-26 14:27 ` Shawn Guo
2012-12-26 14:27 ` Shawn Guo
2012-12-26 14:27 ` Shawn Guo
2012-12-26 14:27 ` Shawn Guo
2012-12-29 0:43 ` Stephen Warren
2012-12-29 0:43 ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 3/7] arm64: use new common dtc rule Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-29 14:30 ` Catalin Marinas
2012-11-29 14:30 ` Catalin Marinas
2012-11-29 14:30 ` Catalin Marinas
2012-12-03 17:27 ` Stephen Warren
2012-12-03 17:27 ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 4/7] openrisc: " Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 5/7] c6x: " Stephen Warren
2012-11-28 18:09 ` Mark Salter
2012-11-27 23:29 ` [PATCH V7 6/7] microblaze: " Stephen Warren
2012-11-27 23:29 ` [PATCH V7 7/7] xtensa: " Stephen Warren
2012-11-28 17:44 ` [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule Catalin Marinas
2012-11-28 17:44 ` Catalin Marinas
2012-11-28 17:44 ` Catalin Marinas
2012-11-28 18:33 ` Stephen Warren [this message]
2012-11-28 18:33 ` Stephen Warren
2012-11-28 23:28 ` Benjamin Herrenschmidt
2012-11-28 23:28 ` Benjamin Herrenschmidt
2012-11-30 16:01 ` Rob Herring
2012-11-30 16:01 ` Rob Herring
2012-11-30 16:01 ` Rob Herring
2012-11-30 19:34 ` Stephen Warren
2012-11-30 19:34 ` Stephen Warren
2012-11-30 19:34 ` Stephen Warren
2012-12-01 4:43 ` Max Filippov
2012-12-01 4:43 ` Max Filippov
2012-12-01 4:43 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B65903.1050400@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmarek@suse.cz \
--cc=paulus@samba.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.