All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-arch@vger.kernel.org, Russell King <linux@arm.linux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>,
	Stephen Warren <swarren@nvidia.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory
Date: Mon, 03 Dec 2012 10:26:24 -0700	[thread overview]
Message-ID: <50BCE0C0.8000708@wwwdotorg.org> (raw)
In-Reply-To: <50BCD030.7020908@gmail.com>

On 12/03/2012 09:15 AM, Rob Herring wrote:
> On 11/27/2012 05:29 PM, Stephen Warren wrote:
>> From: Grant Likely <grant.likely@secretlab.ca>
>>
>> The current rules have the .dtb files build in a different directory
>> from the .dts files. The only reason for this is that it was what
>> PowerPC has done historically. This patch changes ARM to use the generic
>> dtb rule which builds .dtb files in the same directory as the source .dts.
> 
> [snip]
> 
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index a17d5ab..cb217f8 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -136,4 +136,12 @@ dtb-$(CONFIG_ARCH_VT8500) += vt8500-bv07.dtb \
>>  	wm8650-mid.dtb
>>  dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb
>>  
>> +targets += dtbs
>>  endif
>> +
>> +dtbs: $(addprefix $(obj)/, $(dtb-y))
>> +	# *.dtb used to be generated in the directory above. Clean out the
>> +	# old build results so people don't accidentally use them.
>> +	rm -f $(obj)/../*.dtb
> 
> Do you intend for this to print out? Seems a little noisy to me for a
> one-time problem. Are you trying to tell users the dtb files moved or
> just prevent them from using the old ones? Quietly removing them would
> still accomplish the latter.

Oh, I just wasn't thinking; I guess this should be @rm or similar. Will
you fix this up locally since you've applied the patches?

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory
Date: Mon, 03 Dec 2012 10:26:24 -0700	[thread overview]
Message-ID: <50BCE0C0.8000708@wwwdotorg.org> (raw)
In-Reply-To: <50BCD030.7020908@gmail.com>

On 12/03/2012 09:15 AM, Rob Herring wrote:
> On 11/27/2012 05:29 PM, Stephen Warren wrote:
>> From: Grant Likely <grant.likely@secretlab.ca>
>>
>> The current rules have the .dtb files build in a different directory
>> from the .dts files. The only reason for this is that it was what
>> PowerPC has done historically. This patch changes ARM to use the generic
>> dtb rule which builds .dtb files in the same directory as the source .dts.
> 
> [snip]
> 
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index a17d5ab..cb217f8 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -136,4 +136,12 @@ dtb-$(CONFIG_ARCH_VT8500) += vt8500-bv07.dtb \
>>  	wm8650-mid.dtb
>>  dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb
>>  
>> +targets += dtbs
>>  endif
>> +
>> +dtbs: $(addprefix $(obj)/, $(dtb-y))
>> +	# *.dtb used to be generated in the directory above. Clean out the
>> +	# old build results so people don't accidentally use them.
>> +	rm -f $(obj)/../*.dtb
> 
> Do you intend for this to print out? Seems a little noisy to me for a
> one-time problem. Are you trying to tell users the dtb files moved or
> just prevent them from using the old ones? Quietly removing them would
> still accomplish the latter.

Oh, I just wasn't thinking; I guess this should be @rm or similar. Will
you fix this up locally since you've applied the patches?

  reply	other threads:[~2012-12-03 17:26 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 23:29 [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 2/7] ARM: dt: change .dtb build rules to build in dts directory Stephen Warren
2012-11-27 23:29   ` Stephen Warren
2012-11-27 23:29   ` Stephen Warren
2012-11-27 23:50   ` Olof Johansson
2012-11-27 23:50     ` Olof Johansson
2012-12-03 16:15   ` Rob Herring
2012-12-03 16:15     ` Rob Herring
2012-12-03 17:26     ` Stephen Warren [this message]
2012-12-03 17:26       ` Stephen Warren
2012-12-26 14:27   ` Shawn Guo
2012-12-26 14:27     ` Shawn Guo
2012-12-26 14:27     ` Shawn Guo
2012-12-26 14:27     ` Shawn Guo
2012-12-29  0:43     ` Stephen Warren
2012-12-29  0:43       ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 3/7] arm64: use new common dtc rule Stephen Warren
2012-11-27 23:29   ` Stephen Warren
2012-11-29 14:30   ` Catalin Marinas
2012-11-29 14:30     ` Catalin Marinas
2012-11-29 14:30     ` Catalin Marinas
2012-12-03 17:27     ` Stephen Warren
2012-12-03 17:27       ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 4/7] openrisc: " Stephen Warren
2012-11-27 23:29   ` Stephen Warren
2012-11-27 23:29 ` [PATCH V7 5/7] c6x: " Stephen Warren
2012-11-28 18:09   ` Mark Salter
2012-11-27 23:29 ` [PATCH V7 6/7] microblaze: " Stephen Warren
2012-11-27 23:29 ` [PATCH V7 7/7] xtensa: " Stephen Warren
2012-11-28 17:44 ` [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule Catalin Marinas
2012-11-28 17:44   ` Catalin Marinas
2012-11-28 17:44   ` Catalin Marinas
2012-11-28 18:33 ` Stephen Warren
2012-11-28 18:33   ` Stephen Warren
2012-11-28 23:28   ` Benjamin Herrenschmidt
2012-11-28 23:28     ` Benjamin Herrenschmidt
2012-11-30 16:01 ` Rob Herring
2012-11-30 16:01   ` Rob Herring
2012-11-30 16:01   ` Rob Herring
2012-11-30 19:34   ` Stephen Warren
2012-11-30 19:34     ` Stephen Warren
2012-11-30 19:34     ` Stephen Warren
2012-12-01  4:43   ` Max Filippov
2012-12-01  4:43     ` Max Filippov
2012-12-01  4:43     ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50BCE0C0.8000708@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=arnd@arndb.de \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mmarek@suse.cz \
    --cc=olof@lixom.net \
    --cc=robherring2@gmail.com \
    --cc=sam@ravnborg.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.