From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Vaibhav Hiremath <hvaibhav@ti.com>
Subject: Re: [PATCH V2 4/4] ARM: OMAP2+: Fix sparse warnings in timer.c
Date: Thu, 29 Nov 2012 10:46:38 +0530 [thread overview]
Message-ID: <50B6EFB6.1060103@ti.com> (raw)
In-Reply-To: <1354140300-16825-5-git-send-email-jon-hunter@ti.com>
On Thursday 29 November 2012 03:35 AM, Jon Hunter wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> Sparse generates the following warnings when compiling mach-omap2/timer.c.
>
> CHECK arch/arm/mach-omap2/timer.c
> arch/arm/mach-omap2/timer.c:193:13: warning: symbol 'omap_dmtimer_init'
> was not declared. Should it be static?
> arch/arm/mach-omap2/timer.c:213:12: warning: symbol
> 'omap_dm_timer_get_errata' was not declared. Should it be static?
>
> Add static to function declaration to fix warnings.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/4] ARM: OMAP2+: Fix sparse warnings in timer.c
Date: Thu, 29 Nov 2012 10:46:38 +0530 [thread overview]
Message-ID: <50B6EFB6.1060103@ti.com> (raw)
In-Reply-To: <1354140300-16825-5-git-send-email-jon-hunter@ti.com>
On Thursday 29 November 2012 03:35 AM, Jon Hunter wrote:
> From: Vaibhav Hiremath <hvaibhav@ti.com>
>
> Sparse generates the following warnings when compiling mach-omap2/timer.c.
>
> CHECK arch/arm/mach-omap2/timer.c
> arch/arm/mach-omap2/timer.c:193:13: warning: symbol 'omap_dmtimer_init'
> was not declared. Should it be static?
> arch/arm/mach-omap2/timer.c:213:12: warning: symbol
> 'omap_dm_timer_get_errata' was not declared. Should it be static?
>
> Add static to function declaration to fix warnings.
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2012-11-29 5:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 22:04 [PATCH V2 0/4] ARM: OMAP2+: Timer build warnings and error fixes Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 1/4] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 2/4] ARM: OMAP4: Fix build error and " Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 3/4] ARM: AM335x: Fix " Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-29 5:15 ` Santosh Shilimkar
2012-11-29 5:15 ` Santosh Shilimkar
2012-11-29 7:10 ` Igor Grinberg
2012-11-29 7:10 ` Igor Grinberg
2012-11-28 22:05 ` [PATCH V2 4/4] ARM: OMAP2+: Fix sparse warnings " Jon Hunter
2012-11-28 22:05 ` Jon Hunter
2012-11-29 5:16 ` Santosh Shilimkar [this message]
2012-11-29 5:16 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B6EFB6.1060103@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=hvaibhav@ti.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.