From: Igor Grinberg <grinberg@compulab.co.il>
To: Jon Hunter <jon-hunter@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 3/4] ARM: AM335x: Fix warning in timer.c
Date: Thu, 29 Nov 2012 09:10:48 +0200 [thread overview]
Message-ID: <50B70A78.3010704@compulab.co.il> (raw)
In-Reply-To: <1354140300-16825-4-git-send-email-jon-hunter@ti.com>
On 11/29/12 00:04, Jon Hunter wrote:
> When compiling the kernel with configuration options ...
>
> # CONFIG_ARCH_OMAP2 is not set
> # CONFIG_ARCH_OMAP3 is not set
> # CONFIG_ARCH_OMAP4 is not set
> # CONFIG_SOC_OMAP5 is not set
> CONFIG_SOC_AM33XX=y
>
> ... the following build warning is seen.
>
> CC arch/arm/mach-omap2/timer.o
> arch/arm/mach-omap2/timer.c:395:19: warning: ‘omap2_sync32k_clocksource_init’
> defined but not used [-Wunused-function]
>
> This issue was introduced by commit 6f80b3b (ARM: OMAP2+: timer: remove
> CONFIG_OMAP_32K_TIMER) where the omap2_sync32k_clocksource_init() is no
> longer referenced by the timer initialisation function for the AM335x
> device as it has no 32k-sync timer.
>
> Fix this by adding the "__maybe_unused" compiler directive to the
> omap2_sync32k_clocksource_init() function to indicate that this function
> may be used for certain configurations.
>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: grinberg@compulab.co.il (Igor Grinberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 3/4] ARM: AM335x: Fix warning in timer.c
Date: Thu, 29 Nov 2012 09:10:48 +0200 [thread overview]
Message-ID: <50B70A78.3010704@compulab.co.il> (raw)
In-Reply-To: <1354140300-16825-4-git-send-email-jon-hunter@ti.com>
On 11/29/12 00:04, Jon Hunter wrote:
> When compiling the kernel with configuration options ...
>
> # CONFIG_ARCH_OMAP2 is not set
> # CONFIG_ARCH_OMAP3 is not set
> # CONFIG_ARCH_OMAP4 is not set
> # CONFIG_SOC_OMAP5 is not set
> CONFIG_SOC_AM33XX=y
>
> ... the following build warning is seen.
>
> CC arch/arm/mach-omap2/timer.o
> arch/arm/mach-omap2/timer.c:395:19: warning: ?omap2_sync32k_clocksource_init?
> defined but not used [-Wunused-function]
>
> This issue was introduced by commit 6f80b3b (ARM: OMAP2+: timer: remove
> CONFIG_OMAP_32K_TIMER) where the omap2_sync32k_clocksource_init() is no
> longer referenced by the timer initialisation function for the AM335x
> device as it has no 32k-sync timer.
>
> Fix this by adding the "__maybe_unused" compiler directive to the
> omap2_sync32k_clocksource_init() function to indicate that this function
> may be used for certain configurations.
>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
>
> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
--
Regards,
Igor.
next prev parent reply other threads:[~2012-11-29 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 22:04 [PATCH V2 0/4] ARM: OMAP2+: Timer build warnings and error fixes Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 1/4] ARM: OMAP2+: Fix realtime_counter_init warning in timer.c Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 2/4] ARM: OMAP4: Fix build error and " Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-28 22:04 ` [PATCH V2 3/4] ARM: AM335x: Fix " Jon Hunter
2012-11-28 22:04 ` Jon Hunter
2012-11-29 5:15 ` Santosh Shilimkar
2012-11-29 5:15 ` Santosh Shilimkar
2012-11-29 7:10 ` Igor Grinberg [this message]
2012-11-29 7:10 ` Igor Grinberg
2012-11-28 22:05 ` [PATCH V2 4/4] ARM: OMAP2+: Fix sparse warnings " Jon Hunter
2012-11-28 22:05 ` Jon Hunter
2012-11-29 5:16 ` Santosh Shilimkar
2012-11-29 5:16 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B70A78.3010704@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.