From: "Arend van Spriel" <arend@broadcom.com>
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
backports@vger.kernel.org, alexander.stein@systec-electronic.com,
brudley@broadcom.com, rvossen@broadcom.com, frankyl@broadcom.com,
kanyan@broadcom.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list@broadcom.com, kyungmin.park@samsung.com,
s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, daniel.vetter@ffwll.ch,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
srinidhi.kasagar@stericsson.com, linus.walleij@linaro.org,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t
Date: Fri, 30 Nov 2012 22:21:33 +0100 [thread overview]
Message-ID: <50B9235D.7050309@broadcom.com> (raw)
In-Reply-To: <CAB=NE6UVA1As_07HOvCbi4oK+CgbNNeeNMfz8agB-00ZRP973w@mail.gmail.com>
On 11/30/2012 09:25 PM, Luis R. Rodriguez wrote:
> On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez
> <mcgrof@do-not-panic.com> wrote:
>> On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel <arend@broadcom.com> wrote:
>>> So what is the rationale here. During mainlining our drivers we had to
>>> remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle
>>> (chapter 5 Typedefs) is spending a number of lines explaining why.
>>>
>>> So is spinlock_t an exception to this rule simply because the kernel
>>> uses spinlock_t all over the place.
>>
>> Yes.
>
> Let me provide a better explanation. In practice drivers should not be
> creating their own typedefs given that generally the reasons to create
> them do not exist for drivers. The kernel may provide their own though
> for reasons explained in CodingStyle and in such cases the drivers
> should use these supplied typedefs.
Ok. Fine by me. It just looked like a case of saying a and doing b.
Thanks for taking time giving the better explanation :-)
Gr. AvS
WARNING: multiple messages have this Message-ID (diff)
From: arend@broadcom.com (Arend van Spriel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t
Date: Fri, 30 Nov 2012 22:21:33 +0100 [thread overview]
Message-ID: <50B9235D.7050309@broadcom.com> (raw)
In-Reply-To: <CAB=NE6UVA1As_07HOvCbi4oK+CgbNNeeNMfz8agB-00ZRP973w@mail.gmail.com>
On 11/30/2012 09:25 PM, Luis R. Rodriguez wrote:
> On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez
> <mcgrof@do-not-panic.com> wrote:
>> On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel <arend@broadcom.com> wrote:
>>> So what is the rationale here. During mainlining our drivers we had to
>>> remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle
>>> (chapter 5 Typedefs) is spending a number of lines explaining why.
>>>
>>> So is spinlock_t an exception to this rule simply because the kernel
>>> uses spinlock_t all over the place.
>>
>> Yes.
>
> Let me provide a better explanation. In practice drivers should not be
> creating their own typedefs given that generally the reasons to create
> them do not exist for drivers. The kernel may provide their own though
> for reasons explained in CodingStyle and in such cases the drivers
> should use these supplied typedefs.
Ok. Fine by me. It just looked like a case of saying a and doing b.
Thanks for taking time giving the better explanation :-)
Gr. AvS
next prev parent reply other threads:[~2012-11-30 21:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 20:45 [PATCH 0/6] drivers: convert struct spinlock to spinlock_t Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 1/6] ux500: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 21:04 ` [PATCH] checkpatch: Warn when declaring "struct spinlock foo;" Joe Perches
2012-12-01 18:11 ` [PATCH 1/6] ux500: convert struct spinlock to spinlock_t Linus Walleij
2012-12-01 18:11 ` Linus Walleij
2012-11-29 20:45 ` [PATCH 2/6] i915: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:49 ` Daniel Vetter
2012-11-29 20:49 ` Daniel Vetter
2012-11-29 20:45 ` [PATCH 3/6] s5p-fimc: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 4/6] s5p-jpeg: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 5/6] brcmfmac: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 6/6] ie6xx_wdt: " Luis R. Rodriguez
2012-11-29 20:45 ` Luis R. Rodriguez
2012-11-30 8:38 ` [PATCH 0/6] drivers: " Arend van Spriel
2012-11-30 8:38 ` Arend van Spriel
2012-11-30 19:18 ` Luis R. Rodriguez
2012-11-30 19:18 ` Luis R. Rodriguez
2012-11-30 20:25 ` Luis R. Rodriguez
2012-11-30 20:25 ` Luis R. Rodriguez
2012-11-30 20:25 ` Luis R. Rodriguez
2012-11-30 21:21 ` Arend van Spriel [this message]
2012-11-30 21:21 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B9235D.7050309@broadcom.com \
--to=arend@broadcom.com \
--cc=alexander.stein@systec-electronic.com \
--cc=backports@vger.kernel.org \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frankyl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kanyan@broadcom.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=rvossen@broadcom.com \
--cc=s.nawrocki@samsung.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.