From: Larry Finger <Larry.Finger@lwfinger.net>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
yongjun_wei@trendmicro.com.cn, jim.cromie@gmail.com,
marcos.souza.org@gmail.com, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl8712: avoid a useless call to memset().
Date: Wed, 05 Dec 2012 04:07:03 +0000 [thread overview]
Message-ID: <50BEC867.7090209@lwfinger.net> (raw)
In-Reply-To: <1354670522-27144-1-git-send-email-tipecaml@gmail.com>
On 12/04/2012 07:22 PM, Cyril Roelandt wrote:
> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> has just been zeroed by a call to memset().
>
> Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 3a64790..2c73319 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -1131,10 +1131,11 @@ static int r8711_wx_get_wap(struct net_device *dev,
> struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
>
> wrqu->ap_addr.sa_family = ARPHRD_ETHER;
> - memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
> if (check_fwstate(pmlmepriv, _FW_LINKED |
> WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE)) {
> memcpy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress, ETH_ALEN);
> + } else {
> + memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
> }
> return 0;
> }
>
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
yongjun_wei@trendmicro.com.cn, jim.cromie@gmail.com,
marcos.souza.org@gmail.com, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: rtl8712: avoid a useless call to memset().
Date: Tue, 04 Dec 2012 22:07:03 -0600 [thread overview]
Message-ID: <50BEC867.7090209@lwfinger.net> (raw)
In-Reply-To: <1354670522-27144-1-git-send-email-tipecaml@gmail.com>
On 12/04/2012 07:22 PM, Cyril Roelandt wrote:
> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> has just been zeroed by a call to memset().
>
> Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 3a64790..2c73319 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -1131,10 +1131,11 @@ static int r8711_wx_get_wap(struct net_device *dev,
> struct ndis_wlan_bssid_ex *pcur_bss = &pmlmepriv->cur_network.network;
>
> wrqu->ap_addr.sa_family = ARPHRD_ETHER;
> - memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
> if (check_fwstate(pmlmepriv, _FW_LINKED |
> WIFI_ADHOC_MASTER_STATE|WIFI_AP_STATE)) {
> memcpy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress, ETH_ALEN);
> + } else {
> + memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
> }
> return 0;
> }
>
next prev parent reply other threads:[~2012-12-05 4:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 1:22 [PATCH] staging: rtl8712: avoid a useless call to memset() Cyril Roelandt
2012-12-05 1:22 ` Cyril Roelandt
2012-12-05 4:07 ` Larry Finger [this message]
2012-12-05 4:07 ` Larry Finger
2012-12-05 7:11 ` Dan Carpenter
2012-12-05 7:11 ` Dan Carpenter
2012-12-09 0:31 ` Cyril Roelandt
2012-12-09 0:31 ` Cyril Roelandt
2012-12-10 8:55 ` Dan Carpenter
2012-12-10 8:55 ` Dan Carpenter
2012-12-05 8:12 ` walter harms
2012-12-05 8:12 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BEC867.7090209@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jim.cromie@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=tipecaml@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.