From: Cyril Roelandt <tipecaml@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
kernel-janitors@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
marcos.souza.org@gmail.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8712: avoid a useless call to memset().
Date: Sun, 09 Dec 2012 00:31:50 +0000 [thread overview]
Message-ID: <50C3DBF6.2080103@gmail.com> (raw)
In-Reply-To: <20121205071156.GL6568@mwanda>
On 12/05/2012 08:11 AM, Dan Carpenter wrote:
> On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote:
>> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
>> has just been zeroed by a call to memset().
>>
>
> I look at it like the original code is fine. Your version is also
> fine but is it worth the churn? Also the curly braces are not
> needed.
>
Sorry about the braces.
I just thought the code would be easier to understand this way, but it's
probably OK to leave it as it currently is too.
WBR,
Cyril Roelandt.
WARNING: multiple messages have this Message-ID (diff)
From: Cyril Roelandt <tipecaml@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
kernel-janitors@vger.kernel.org, yongjun_wei@trendmicro.com.cn,
marcos.souza.org@gmail.com, Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtl8712: avoid a useless call to memset().
Date: Sun, 09 Dec 2012 01:31:50 +0100 [thread overview]
Message-ID: <50C3DBF6.2080103@gmail.com> (raw)
In-Reply-To: <20121205071156.GL6568@mwanda>
On 12/05/2012 08:11 AM, Dan Carpenter wrote:
> On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote:
>> In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
>> has just been zeroed by a call to memset().
>>
>
> I look at it like the original code is fine. Your version is also
> fine but is it worth the churn? Also the curly braces are not
> needed.
>
Sorry about the braces.
I just thought the code would be easier to understand this way, but it's
probably OK to leave it as it currently is too.
WBR,
Cyril Roelandt.
next prev parent reply other threads:[~2012-12-09 0:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 1:22 [PATCH] staging: rtl8712: avoid a useless call to memset() Cyril Roelandt
2012-12-05 1:22 ` Cyril Roelandt
2012-12-05 4:07 ` Larry Finger
2012-12-05 4:07 ` Larry Finger
2012-12-05 7:11 ` Dan Carpenter
2012-12-05 7:11 ` Dan Carpenter
2012-12-09 0:31 ` Cyril Roelandt [this message]
2012-12-09 0:31 ` Cyril Roelandt
2012-12-10 8:55 ` Dan Carpenter
2012-12-10 8:55 ` Dan Carpenter
2012-12-05 8:12 ` walter harms
2012-12-05 8:12 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C3DBF6.2080103@gmail.com \
--to=tipecaml@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.souza.org@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.