* [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
@ 2012-12-07 12:50 Wei Yongjun
2012-12-10 1:38 ` Inki Dae
2012-12-10 6:14 ` 김승우
0 siblings, 2 replies; 4+ messages in thread
From: Wei Yongjun @ 2012-12-07 12:50 UTC (permalink / raw)
To: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, airlied
Cc: yongjun_wei, dri-devel, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, function arm_iommu_create_mapping() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
index 09db198..3b3d3a6 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
@@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,
priv->da_space_size,
priv->da_space_order);
- if (!mapping)
+ if (IS_ERR(mapping))
return -ENOMEM;
dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
2012-12-07 12:50 [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping() Wei Yongjun
@ 2012-12-10 1:38 ` Inki Dae
2012-12-10 6:14 ` 김승우
1 sibling, 0 replies; 4+ messages in thread
From: Inki Dae @ 2012-12-10 1:38 UTC (permalink / raw)
To: Wei Yongjun
Cc: sw0312.kim, yongjun_wei, dri-devel, linux-kernel, kyungmin.park
[-- Attachment #1.1: Type: text/plain, Size: 1347 bytes --]
Applied.
Thanks,
Inki Dae
2012/12/7 Wei Yongjun <weiyj.lk@gmail.com>
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, function arm_iommu_create_mapping() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> index 09db198..3b3d3a6 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
> mapping = arm_iommu_create_mapping(&platform_bus_type,
> priv->da_start,
> priv->da_space_size,
> priv->da_space_order);
> - if (!mapping)
> + if (IS_ERR(mapping))
> return -ENOMEM;
>
> dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
[-- Attachment #1.2: Type: text/html, Size: 1965 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
2012-12-07 12:50 [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping() Wei Yongjun
2012-12-10 1:38 ` Inki Dae
@ 2012-12-10 6:14 ` 김승우
2012-12-10 6:29 ` Inki Dae
1 sibling, 1 reply; 4+ messages in thread
From: 김승우 @ 2012-12-10 6:14 UTC (permalink / raw)
To: Wei Yongjun
Cc: inki.dae, jy0922.shim, kyungmin.park, airlied, yongjun_wei,
linux-kernel, dri-devel, sw0312.kim
On 2012년 12월 07일 21:50, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, function arm_iommu_create_mapping() returns
> ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> index 09db198..3b3d3a6 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device *drm_dev)
> mapping = arm_iommu_create_mapping(&platform_bus_type, priv->da_start,
> priv->da_space_size,
> priv->da_space_order);
> - if (!mapping)
> + if (IS_ERR(mapping))
> return -ENOMEM;
One more fix is needed here.
- return -ENOMEM;
+ return PTR_ERR(mapping);
>
> dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
--
Seung-Woo Kim
Samsung Software R&D Center
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping()
2012-12-10 6:14 ` 김승우
@ 2012-12-10 6:29 ` Inki Dae
0 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2012-12-10 6:29 UTC (permalink / raw)
To: sw0312.kim, 'Wei Yongjun'
Cc: jy0922.shim, kyungmin.park, airlied, yongjun_wei, linux-kernel,
dri-devel
> -----Original Message-----
> From: 김승우 [mailto:sw0312.kim@samsung.com]
> Sent: Monday, December 10, 2012 3:14 PM
> To: Wei Yongjun
> Cc: inki.dae@samsung.com; jy0922.shim@samsung.com;
> kyungmin.park@samsung.com; airlied@linux.ie; yongjun_wei@trendmicro.com.cn;
> linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org;
> sw0312.kim@samsung.com
> Subject: Re: [PATCH -next] drm/exynos/iommu: fix return value check in
> drm_create_iommu_mapping()
>
>
>
> On 2012년 12월 07일 21:50, Wei Yongjun wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > In case of error, function arm_iommu_create_mapping() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_iommu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > index 09db198..3b3d3a6 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_iommu.c
> > @@ -56,7 +56,7 @@ int drm_create_iommu_mapping(struct drm_device
> *drm_dev)
> > mapping = arm_iommu_create_mapping(&platform_bus_type, priv-
> >da_start,
> > priv->da_space_size,
> > priv->da_space_order);
> > - if (!mapping)
> > + if (IS_ERR(mapping))
> > return -ENOMEM;
>
> One more fix is needed here.
> - return -ENOMEM;
> + return PTR_ERR(mapping);
Oh, good point, I missed. Please re-send it.
Thanks,
Inki Dae
>
> >
> > dev->dma_parms = devm_kzalloc(dev, sizeof(*dev->dma_parms),
> >
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
>
> --
> Seung-Woo Kim
> Samsung Software R&D Center
> --
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-10 6:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-07 12:50 [PATCH -next] drm/exynos/iommu: fix return value check in drm_create_iommu_mapping() Wei Yongjun
2012-12-10 1:38 ` Inki Dae
2012-12-10 6:14 ` 김승우
2012-12-10 6:29 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.