All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zlatko Calusic <zlatko.calusic@iskon.hr>
To: Mel Gorman <mgorman@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kswapd craziness in 3.7
Date: Mon, 10 Dec 2012 19:33:10 +0100	[thread overview]
Message-ID: <50C62AE6.3030000@iskon.hr> (raw)
In-Reply-To: <20121210180141.GK1009@suse.de>

On 10.12.2012 19:01, Mel Gorman wrote:
> In this last-minute disaster, I'm not thinking properly at all any more. The
> shrink slab disabling should have happened before the loop_again but even
> then it's wrong because it's just covering over the problem.
>
> The way order and testorder interact with how balanced is calculated means
> that we potentially call shrink_slab() multiple times and that thing is
> global in nature and basically uncontrolled. You could argue that we should
> only call shrink_slab() if order-0 watermarks are not met but that will
> not necessarily prevent kswapd reclaiming too much. It keeps going back
> to balance_pgdat needing its list of requirements drawn up and receive
> some major surgery and we're not going to do that as a quick hack.
>

I was about to apply the patch that you sent, and reboot the server, but 
it seems there's no point because the patch is flawed?

Anyway, if and when you have a proper one, I'll be glad to test it for 
you and report results.
-- 
Zlatko

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Zlatko Calusic <zlatko.calusic@iskon.hr>
To: Mel Gorman <mgorman@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kswapd craziness in 3.7
Date: Mon, 10 Dec 2012 19:33:10 +0100	[thread overview]
Message-ID: <50C62AE6.3030000@iskon.hr> (raw)
In-Reply-To: <20121210180141.GK1009@suse.de>

On 10.12.2012 19:01, Mel Gorman wrote:
> In this last-minute disaster, I'm not thinking properly at all any more. The
> shrink slab disabling should have happened before the loop_again but even
> then it's wrong because it's just covering over the problem.
>
> The way order and testorder interact with how balanced is calculated means
> that we potentially call shrink_slab() multiple times and that thing is
> global in nature and basically uncontrolled. You could argue that we should
> only call shrink_slab() if order-0 watermarks are not met but that will
> not necessarily prevent kswapd reclaiming too much. It keeps going back
> to balance_pgdat needing its list of requirements drawn up and receive
> some major surgery and we're not going to do that as a quick hack.
>

I was about to apply the patch that you sent, and reboot the server, but 
it seems there's no point because the patch is flawed?

Anyway, if and when you have a proper one, I'll be glad to test it for 
you and report results.
-- 
Zlatko

  reply	other threads:[~2012-12-10 18:33 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 20:48 kswapd craziness in 3.7 Johannes Weiner
2012-11-27 20:48 ` Johannes Weiner
2012-11-27 20:48 ` [patch] mm: vmscan: fix kswapd endless loop on higher order allocation Johannes Weiner
2012-11-27 20:48   ` Johannes Weiner
2012-11-27 20:58 ` kswapd craziness in 3.7 Linus Torvalds
2012-11-27 20:58   ` Linus Torvalds
2012-11-27 21:16   ` Rik van Riel
2012-11-27 21:16     ` Rik van Riel
2012-11-27 21:49     ` Johannes Weiner
2012-11-27 21:49       ` Johannes Weiner
2012-11-27 22:02       ` Rik van Riel
2012-11-27 22:02         ` Rik van Riel
2012-11-27 22:26         ` Johannes Weiner
2012-11-27 22:26           ` Johannes Weiner
2012-11-27 23:19           ` Linus Torvalds
2012-11-27 23:19             ` Linus Torvalds
2012-11-28 10:13             ` Mel Gorman
2012-11-28 10:13               ` Mel Gorman
2012-11-28 10:51               ` Thorsten Leemhuis
2012-11-28 10:51                 ` Thorsten Leemhuis
2012-11-28 16:42               ` Mel Gorman
2012-11-28 16:42                 ` Mel Gorman
2012-11-28 22:52               ` Andrew Morton
2012-11-28 22:52                 ` Andrew Morton
2012-11-28 23:54                 ` Mel Gorman
2012-11-28 23:54                   ` Mel Gorman
2012-11-29  0:14                   ` Andrew Morton
2012-11-29  0:14                     ` Andrew Morton
2012-11-29 15:30                   ` Thorsten Leemhuis
2012-11-29 15:30                     ` Thorsten Leemhuis
2012-11-29 17:05                     ` Johannes Weiner
2012-11-29 17:05                       ` Johannes Weiner
2012-11-30 12:39                       ` Thorsten Leemhuis
2012-11-30 12:39                         ` Thorsten Leemhuis
2012-12-01  0:45                         ` Johannes Weiner
2012-12-01  0:45                           ` Johannes Weiner
2012-12-03  8:30                           ` Thorsten Leemhuis
2012-12-03  8:30                             ` Thorsten Leemhuis
2012-12-03 13:08                             ` Fedora repo (was: Re: kswapd craziness in 3.7) Borislav Petkov
2012-12-03 13:08                               ` Borislav Petkov
2012-12-03 19:42                             ` kswapd craziness in 3.7 Johannes Weiner
2012-12-03 19:42                               ` Johannes Weiner
2012-12-04 21:42                               ` Johannes Weiner
2012-12-04 21:42                                 ` Johannes Weiner
2012-12-05  3:01                                 ` Bruno Wolff III
2012-12-05  3:01                                   ` Bruno Wolff III
2012-12-06 17:37                                   ` Bruno Wolff III
2012-12-06 17:37                                     ` Bruno Wolff III
2012-12-06 19:31                                     ` Linus Torvalds
2012-12-06 19:31                                       ` Linus Torvalds
2012-12-06 19:43                                       ` Rik van Riel
2012-12-06 19:43                                         ` Rik van Riel
2012-12-06 20:23                                       ` Johannes Weiner
2012-12-06 20:23                                         ` Johannes Weiner
2012-12-06 20:32                                         ` Rik van Riel
2012-12-06 20:32                                           ` Rik van Riel
2012-12-08 12:06                                       ` Zlatko Calusic
2012-12-08 12:06                                         ` Zlatko Calusic
2012-12-08 21:22                                         ` Zlatko Calusic
2012-12-08 21:22                                           ` Zlatko Calusic
2012-12-09  1:01                                           ` Linus Torvalds
2012-12-09  1:01                                             ` Linus Torvalds
2012-12-09 21:59                                             ` Zdenek Kabelac
2012-12-09 21:59                                               ` Zdenek Kabelac
2012-12-10 11:03                                             ` Mel Gorman
2012-12-10 11:03                                               ` Mel Gorman
2012-12-10 16:39                                               ` Johannes Weiner
2012-12-10 16:39                                                 ` Johannes Weiner
2012-12-10 18:01                                                 ` Mel Gorman
2012-12-10 18:01                                                   ` Mel Gorman
2012-12-10 18:33                                                   ` Zlatko Calusic [this message]
2012-12-10 18:33                                                     ` Zlatko Calusic
2012-12-10 19:13                                                     ` Linus Torvalds
2012-12-10 19:13                                                       ` Linus Torvalds
2012-12-10 20:35                                                       ` Zlatko Calusic
2012-12-10 20:35                                                         ` Zlatko Calusic
2012-12-10 21:28                                                         ` Linus Torvalds
2012-12-10 21:28                                                           ` Linus Torvalds
2012-12-10 21:42                                                           ` Borislav Petkov
2012-12-10 21:42                                                             ` Borislav Petkov
2012-12-10 21:47                                                             ` Linus Torvalds
2012-12-10 21:47                                                               ` Linus Torvalds
2012-12-10 21:54                                                               ` Borislav Petkov
2012-12-10 21:54                                                                 ` Borislav Petkov
2012-12-10 22:15                                                                 ` Zlatko Calusic
2012-12-10 22:15                                                                   ` Zlatko Calusic
2012-12-10 23:27                                                           ` Hugh Dickins
2012-12-10 23:27                                                             ` Hugh Dickins
2012-12-11  0:19                                                         ` Zlatko Calusic
2012-12-11 21:56                                                           ` Zlatko Calusic
2012-12-11 21:56                                                             ` Zlatko Calusic
2012-12-19 22:24                                                           ` Zlatko Calusic
2012-12-19 22:24                                                             ` Zlatko Calusic
2012-12-10 18:29                                               ` Zlatko Calusic
2012-12-10 18:29                                                 ` Zlatko Calusic
2012-12-06  8:09                               ` Thorsten Leemhuis
2012-12-06  8:09                                 ` Thorsten Leemhuis
2012-11-27 21:29   ` Johannes Weiner
2012-11-27 21:29     ` Johannes Weiner
2012-11-28 13:35   ` Zdenek Kabelac
2012-11-28 13:35     ` Zdenek Kabelac
2012-11-28 14:04     ` Jiri Slaby
2012-11-28 14:04       ` Jiri Slaby
2012-11-28  9:45 ` Mel Gorman
2012-11-28  9:45   ` Mel Gorman
2012-12-03 15:23   ` Zdenek Kabelac
2012-12-03 15:23     ` Zdenek Kabelac
2012-12-03 19:18     ` Johannes Weiner
2012-12-03 19:18       ` Johannes Weiner
2012-12-04  9:05       ` Zdenek Kabelac
2012-12-04  9:05         ` Zdenek Kabelac
2012-12-04  9:15         ` Jiri Slaby
2012-12-04  9:15           ` Jiri Slaby
2012-12-04 16:11           ` Johannes Weiner
2012-12-04 16:11             ` Johannes Weiner
2012-12-04 16:22             ` Jiri Slaby
2012-12-04 16:22               ` Jiri Slaby
2012-12-04 19:50               ` Johannes Weiner
2012-12-04 19:50                 ` Johannes Weiner
2012-12-08 10:35             ` Jiri Slaby
2012-12-08 10:35               ` Jiri Slaby
2012-12-04 16:15         ` Johannes Weiner
2012-12-04 16:15           ` Johannes Weiner
2012-12-06 13:51         ` Zdenek Kabelac
2012-12-06 13:51           ` Zdenek Kabelac
2012-12-03 13:14 ` Jiri Slaby
2012-12-03 13:14   ` Jiri Slaby
2012-12-04  8:55   ` Jiri Slaby
2012-12-04  8:55     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50C62AE6.3030000@iskon.hr \
    --to=zlatko.calusic@iskon.hr \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=riel@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.