From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: add sleep mode management for hogs
Date: Tue, 11 Dec 2012 14:11:48 -0700 [thread overview]
Message-ID: <50C7A194.7070102@wwwdotorg.org> (raw)
In-Reply-To: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com>
On 12/11/2012 06:59 AM, Linus Walleij wrote:
> From: Julien Delacou <julien.delacou@stericsson.com>
>
> This fix allows handling sleep mode for hogged
> pins in pinctrl. It provides functions to set pins
> to sleep/default configurations according to their
> current state from the individual pinctrl drivers.
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev);
> +extern int pinctrl_force_default(struct pinctrl_dev *pctldev);
Since I assume those function are only supposed to be used by pinctrl
drivers themselves, should the prototypes go into drivers/pinctrl/core.h
or similar, rather than something in include/linux/pinctrl?
Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module?
Aside from that,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Stephen Warren <swarren@nvidia.com>,
Anmar Oueja <anmar.oueja@linaro.org>,
Julien Delacou <julien.delacou@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs
Date: Tue, 11 Dec 2012 14:11:48 -0700 [thread overview]
Message-ID: <50C7A194.7070102@wwwdotorg.org> (raw)
In-Reply-To: <1355234393-17368-1-git-send-email-linus.walleij@stericsson.com>
On 12/11/2012 06:59 AM, Linus Walleij wrote:
> From: Julien Delacou <julien.delacou@stericsson.com>
>
> This fix allows handling sleep mode for hogged
> pins in pinctrl. It provides functions to set pins
> to sleep/default configurations according to their
> current state from the individual pinctrl drivers.
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev);
> +extern int pinctrl_force_default(struct pinctrl_dev *pctldev);
Since I assume those function are only supposed to be used by pinctrl
drivers themselves, should the prototypes go into drivers/pinctrl/core.h
or similar, rather than something in include/linux/pinctrl?
Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module?
Aside from that,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2012-12-11 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 13:59 [PATCH 1/2] pinctrl: add sleep mode management for hogs Linus Walleij
2012-12-11 13:59 ` Linus Walleij
2012-12-11 21:11 ` Stephen Warren [this message]
2012-12-11 21:11 ` Stephen Warren
2012-12-12 19:31 ` Linus Walleij
2012-12-12 19:31 ` Linus Walleij
2012-12-13 8:18 ` Julien DELACOU
2012-12-13 8:18 ` Julien DELACOU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C7A194.7070102@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.