[Xenomai] Init issue with rtcan_flexcan

[Xenomai] Init issue with rtcan_flexcan

[Thierry Bultel]

Hi,
some days ago I have posted a patch for the rtcan_flexcan to be
correctly probed on the iMX6q

It is functional, but I have not tested it enough, I am sorry about that.
It only works if the linux flexcan driver module has been used once before.

Else I have got IRQs but no packet go to the upper layer, I think it is
stuck in passive state, I am investigating on it.

Regards
Thierry

Re: [Xenomai] Init issue with rtcan_flexcan

[Wolfgang Grandegger]

On 12/14/2012 03:23 PM, Thierry Bultel wrote:
> Hi,
> some days ago I have posted a patch for the rtcan_flexcan to be
> correctly probed on the iMX6q
> 
> It is functional, but I have not tested it enough, I am sorry about that.
> It only works if the linux flexcan driver module has been used once before.
> 
> Else I have got IRQs but no packet go to the upper layer, I think it is
> stuck in passive state, I am investigating on it.

It would be nice if you could port the missing patches from the mainline
Linux kernel to rtcan_flexcan.

Thanks,

Wolfgang.

Re: [Xenomai] Init issue with rtcan_flexcan

[Henri Roosen]

On Fri, Dec 14, 2012 at 5:38 PM, Wolfgang Grandegger <wg@grandegger.com>wrote:

> On 12/14/2012 03:23 PM, Thierry Bultel wrote:
> > Hi,
> > some days ago I have posted a patch for the rtcan_flexcan to be
> > correctly probed on the iMX6q
> >
> > It is functional, but I have not tested it enough, I am sorry about that.
> > It only works if the linux flexcan driver module has been used once
> before.
> >
> > Else I have got IRQs but no packet go to the upper layer, I think it is
> > stuck in passive state, I am investigating on it.
>
> It would be nice if you could port the missing patches from the mainline
> Linux kernel to rtcan_flexcan.
>

I have ported code from the mainline linux flexcan driver that fixes the
behavior described by Thierry. Please find attached:
0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch

The attached patches can be applied to the current mainline xenomai git
(anywhere after commit-3ddc61cda095a9ae51277608d7fd4e9c2c481625). They make
Thierry's patch obsolete.

I have tested the rtcan_flexcan driver in the non-CONFIG_OF configuration
only. On a wandboard with iMX6Solo using the freescale 3.0 kernel. I only
compile tested the CONFIG_OF configuration for the current ipipe master
(3.8) because wandboard solo is not yet supported by OpenFirmware. It would
be great if someone could test the OF version.

Thanks,
Henri


> Thanks,
>
> Wolfgang.
>
>
> _______________________________________________
> Xenomai mailing list
> Xenomai@xenomai.org
> http://www.xenomai.org/mailman/listinfo/xenomai
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
Type: application/octet-stream
Size: 4683 bytes
Desc: not available
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20130605/276cd6fe/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch
Type: application/octet-stream
Size: 8590 bytes
Desc: not available
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20130605/276cd6fe/attachment-0001.obj>

Re: [Xenomai] Init issue with rtcan_flexcan

[Wolfgang Grandegger]

Hi Henri,

On 06/05/2013 09:15 AM, Henri Roosen wrote:
> On Fri, Dec 14, 2012 at 5:38 PM, Wolfgang Grandegger <wg@grandegger.com>wrote:
> 
>> On 12/14/2012 03:23 PM, Thierry Bultel wrote:
>>> Hi,
>>> some days ago I have posted a patch for the rtcan_flexcan to be
>>> correctly probed on the iMX6q
>>>
>>> It is functional, but I have not tested it enough, I am sorry about that.
>>> It only works if the linux flexcan driver module has been used once
>> before.
>>>
>>> Else I have got IRQs but no packet go to the upper layer, I think it is
>>> stuck in passive state, I am investigating on it.
>>
>> It would be nice if you could port the missing patches from the mainline
>> Linux kernel to rtcan_flexcan.
>>
> 
> I have ported code from the mainline linux flexcan driver that fixes the
> behavior described by Thierry. Please find attached:
> 0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
> 0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch
> 
> The attached patches can be applied to the current mainline xenomai git
> (anywhere after commit-3ddc61cda095a9ae51277608d7fd4e9c2c481625). They make
> Thierry's patch obsolete.
> 
> I have tested the rtcan_flexcan driver in the non-CONFIG_OF configuration
> only. On a wandboard with iMX6Solo using the freescale 3.0 kernel. I only
> compile tested the CONFIG_OF configuration for the current ipipe master
> (3.8) because wandboard solo is not yet supported by OpenFirmware. It would
> be great if someone could test the OF version.

Thanks for your contribution. Looks good at a first glance. Just need to
check back- (and forward-) compatibility. I will also try to get access
to boards using Flexcan. Hope to find some time over the WE.

Wolfgang.

Re: [Xenomai] Init issue with rtcan_flexcan

[Wolfgang Grandegger]

Hi Henri,

On 06/06/2013 09:07 AM, Wolfgang Grandegger wrote:
> Hi Henri,
> 
> On 06/05/2013 09:15 AM, Henri Roosen wrote:
>> On Fri, Dec 14, 2012 at 5:38 PM, Wolfgang Grandegger <wg@grandegger.com>wrote:
>>
>>> On 12/14/2012 03:23 PM, Thierry Bultel wrote:
>>>> Hi,
>>>> some days ago I have posted a patch for the rtcan_flexcan to be
>>>> correctly probed on the iMX6q
>>>>
>>>> It is functional, but I have not tested it enough, I am sorry about that.
>>>> It only works if the linux flexcan driver module has been used once
>>> before.
>>>>
>>>> Else I have got IRQs but no packet go to the upper layer, I think it is
>>>> stuck in passive state, I am investigating on it.
>>>
>>> It would be nice if you could port the missing patches from the mainline
>>> Linux kernel to rtcan_flexcan.
>>>
>>
>> I have ported code from the mainline linux flexcan driver that fixes the
>> behavior described by Thierry. Please find attached:
>> 0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
>> 0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch
>>
>> The attached patches can be applied to the current mainline xenomai git
>> (anywhere after commit-3ddc61cda095a9ae51277608d7fd4e9c2c481625). They make
>> Thierry's patch obsolete.
>>
>> I have tested the rtcan_flexcan driver in the non-CONFIG_OF configuration
>> only. On a wandboard with iMX6Solo using the freescale 3.0 kernel. I only
>> compile tested the CONFIG_OF configuration for the current ipipe master
>> (3.8) because wandboard solo is not yet supported by OpenFirmware. It would
>> be great if someone could test the OF version.
> 
> Thanks for your contribution. Looks good at a first glance. Just need to
> check back- (and forward-) compatibility. I will also try to get access
> to boards using Flexcan. Hope to find some time over the WE.

So far I didn't get a chance to test you driver modifications. Anyway,
the patch looks good. Gilles, could you please add my

"Acked-by: Wolfgang Grandegger <wg@grandegger.com>"

and apply the patch, thanks.

Thanks for your contribution,

Wolfgang.

Re: [Xenomai] Init issue with rtcan_flexcan

[Gilles Chanteperdrix]

On 06/19/2013 10:26 PM, Wolfgang Grandegger wrote:

> Hi Henri,
>
> On 06/06/2013 09:07 AM, Wolfgang Grandegger wrote:
>> Hi Henri,
>>
>> On 06/05/2013 09:15 AM, Henri Roosen wrote:
>>> On Fri, Dec 14, 2012 at 5:38 PM, Wolfgang Grandegger<wg@grandegger.com>wrote:
>>>
>>>> On 12/14/2012 03:23 PM, Thierry Bultel wrote:
>>>>> Hi,
>>>>> some days ago I have posted a patch for the rtcan_flexcan to be
>>>>> correctly probed on the iMX6q
>>>>>
>>>>> It is functional, but I have not tested it enough, I am sorry about that.
>>>>> It only works if the linux flexcan driver module has been used once
>>>> before.
>>>>>
>>>>> Else I have got IRQs but no packet go to the upper layer, I think it is
>>>>> stuck in passive state, I am investigating on it.
>>>>
>>>> It would be nice if you could port the missing patches from the mainline
>>>> Linux kernel to rtcan_flexcan.
>>>>
>>>
>>> I have ported code from the mainline linux flexcan driver that fixes the
>>> behavior described by Thierry. Please find attached:
>>> 0001-make-rtcan_flexcan-driver-compatible-with-non-OpenFi.patch
>>> 0002-Fix-rtcan_flexcan-for-mx6-for-OpenFirmware-platforms.patch
>>>
>>> The attached patches can be applied to the current mainline xenomai git
>>> (anywhere after commit-3ddc61cda095a9ae51277608d7fd4e9c2c481625). They make
>>> Thierry's patch obsolete.
>>>
>>> I have tested the rtcan_flexcan driver in the non-CONFIG_OF configuration
>>> only. On a wandboard with iMX6Solo using the freescale 3.0 kernel. I only
>>> compile tested the CONFIG_OF configuration for the current ipipe master
>>> (3.8) because wandboard solo is not yet supported by OpenFirmware. It would
>>> be great if someone could test the OF version.
>>
>> Thanks for your contribution. Looks good at a first glance. Just need to
>> check back- (and forward-) compatibility. I will also try to get access
>> to boards using Flexcan. Hope to find some time over the WE.
>
> So far I didn't get a chance to test you driver modifications. Anyway,
> the patch looks good. Gilles, could you please add my
>
> "Acked-by: Wolfgang Grandegger<wg@grandegger.com>"
>
> and apply the patch, thanks.


Merged, thanks.

-- 
                                                                 Gilles.