From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Fioravante, Matthew E." <Matthew.Fioravante@jhuapl.edu>
Cc: George Dunlap <dunlapg@umich.edu>,
Ian Campbell <Ian.Campbell@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] Disable caml-stubdom by default
Date: Fri, 14 Dec 2012 16:34:40 +0100 [thread overview]
Message-ID: <50CB4710.8010502@citrix.com> (raw)
In-Reply-To: <068F06DC4D106941B297C0C5F9F446EA48BDDDC20D@aplesstripe.dom1.jhuapl.edu>
On 14/12/12 15:33, Fioravante, Matthew E. wrote:
> Caml was disabled in the original stubdom default build targets. I should not have enabled it in my original stubdom autoconf patch.
Does caml-stubdom require something else apart from caml itself? If not
I think it should be enabled by default if caml is detected (like we do
for the caml xenstore in the tools).
> ________________________________________
> From: dunlapg@gmail.com [dunlapg@gmail.com] On Behalf Of George Dunlap [dunlapg@umich.edu]
> Sent: Thursday, December 13, 2012 12:47 PM
> To: Fioravante, Matthew E.
> Cc: Ian Campbell; xen-devel@lists.xen.org
> Subject: Re: [Xen-devel] [PATCH] Disable caml-stubdom by default
>
> Is there a rationale for this? If so, it should probably be in the commit message.
>
> -George
>
>
> On Thu, Dec 13, 2012 at 3:31 PM, Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>> wrote:
> Signed-off-by: Matthew Fioravante <matthew.fioravante@jhuapl.edu<mailto:matthew.fioravante@jhuapl.edu>>
> ---
> stubdom/configure.ac<http://configure.ac> | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/stubdom/configure.ac<http://configure.ac> b/stubdom/configure.ac<http://configure.ac>
> index db44d4a..384a94a 100644
> --- a/stubdom/configure.ac<http://configure.ac>
> +++ b/stubdom/configure.ac<http://configure.ac>
> @@ -18,7 +18,7 @@ m4_include([../m4/depends.m4])
> # Enable/disable stub domains
> AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
> AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> -AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_DISABLE([caml-stubdom], [caml])
> AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
> AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
> AX_STUBDOM_CONDITIONAL([vtpm-stubdom], [vtpm])
> --
> 1.7.10.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org<mailto:Xen-devel@lists.xen.org>
> http://lists.xen.org/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
next prev parent reply other threads:[~2012-12-14 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 15:31 [PATCH] Disable caml-stubdom by default Matthew Fioravante
2012-12-13 17:47 ` George Dunlap
2012-12-14 14:33 ` Fioravante, Matthew E.
2012-12-14 15:34 ` Roger Pau Monné [this message]
2012-12-14 16:20 ` Fioravante, Matthew E.
2012-12-18 14:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50CB4710.8010502@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Matthew.Fioravante@jhuapl.edu \
--cc=dunlapg@umich.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.